mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-21 16:18:55 +00:00
alelpoan's fix (emit hermes:zoom:changed after restore) is correct, but the bug's root is duplication: setAndPersistZoomLevel and restorePersistedZoomLevel each independently did setZoomLevel + send, and restore forgot the send. Collapse both (and the lifecycle re-assert) into a single applyZoomLevel() helper in zoom.ts that always applies-then-notifies — the regression can't recur by omitting a send. Replace the source-grep test (which broke on main: the sibling source-assertion pet test it copied was refactored to a behavioral one, dropping the fs/path imports it relied on) with behavioral coverage of the funnel, matching zoom.ts's "unit-testable without booting a BrowserWindow" convention. Co-authored-by: alelpoan <alelpoan@proton.me>
160 lines
4.8 KiB
TypeScript
160 lines
4.8 KiB
TypeScript
/**
|
|
* Unit tests for the pure zoom helpers: clamping garbage input, the
|
|
* percent <-> zoom-level conversion the settings UI relies on, and the
|
|
* roundtrip stability of the preset percentages.
|
|
*/
|
|
|
|
import assert from 'node:assert/strict'
|
|
|
|
import { test } from 'vitest'
|
|
|
|
import {
|
|
applyZoomLevel,
|
|
clampZoomLevel,
|
|
installZoomReassertOnWindowEvents,
|
|
percentToZoomLevel,
|
|
ZOOM_REASSERT_WINDOW_EVENTS,
|
|
ZOOM_STORAGE_KEY,
|
|
zoomLevelToPercent,
|
|
zoomWiringForWindowKind
|
|
} from './zoom'
|
|
|
|
test('storage key stays stable so persisted zoom survives upgrades', () => {
|
|
assert.equal(ZOOM_STORAGE_KEY, 'hermes:desktop:zoomLevel')
|
|
})
|
|
|
|
test('clampZoomLevel rejects garbage and enforces bounds', () => {
|
|
assert.equal(clampZoomLevel(NaN), 0)
|
|
assert.equal(clampZoomLevel(Infinity), 0)
|
|
assert.equal(clampZoomLevel(undefined), 0)
|
|
assert.equal(clampZoomLevel('2'), 0)
|
|
assert.equal(clampZoomLevel(0.3), 0.3)
|
|
assert.equal(clampZoomLevel(-42), -9)
|
|
assert.equal(clampZoomLevel(42), 9)
|
|
})
|
|
|
|
test('level 0 is exactly 100 percent', () => {
|
|
assert.equal(zoomLevelToPercent(0), 100)
|
|
assert.equal(percentToZoomLevel(100), 0)
|
|
})
|
|
|
|
test('percentToZoomLevel rejects garbage', () => {
|
|
assert.equal(percentToZoomLevel(NaN), 0)
|
|
assert.equal(percentToZoomLevel(0), 0)
|
|
assert.equal(percentToZoomLevel(-50), 0)
|
|
assert.equal(percentToZoomLevel(undefined), 0)
|
|
})
|
|
|
|
test('preset percentages roundtrip within rounding', () => {
|
|
for (const percent of [90, 100, 110, 125, 150, 175]) {
|
|
assert.equal(zoomLevelToPercent(percentToZoomLevel(percent)), percent)
|
|
}
|
|
})
|
|
|
|
test('conversion is monotonic across the preset range', () => {
|
|
const levels = [90, 100, 110, 125, 150, 175].map(percentToZoomLevel)
|
|
|
|
for (let i = 1; i < levels.length; i++) {
|
|
assert.ok(levels[i] > levels[i - 1])
|
|
}
|
|
})
|
|
|
|
test('extreme percentages clamp to the level bounds', () => {
|
|
assert.equal(percentToZoomLevel(1), -9)
|
|
assert.equal(percentToZoomLevel(1_000_000), 9)
|
|
})
|
|
|
|
test('installZoomReassertOnWindowEvents wires show and restore', () => {
|
|
const handlers = new Map()
|
|
|
|
const win = {
|
|
isDestroyed: () => false,
|
|
on(event, listener) {
|
|
handlers.set(event, listener)
|
|
}
|
|
}
|
|
|
|
let calls = 0
|
|
installZoomReassertOnWindowEvents(win, () => {
|
|
calls += 1
|
|
})
|
|
|
|
assert.deepEqual([...handlers.keys()], [...ZOOM_REASSERT_WINDOW_EVENTS])
|
|
handlers.get('show')()
|
|
handlers.get('restore')()
|
|
assert.equal(calls, 2)
|
|
})
|
|
|
|
test('installZoomReassertOnWindowEvents skips destroyed windows', () => {
|
|
const handlers = new Map()
|
|
let destroyed = false
|
|
|
|
const win = {
|
|
isDestroyed: () => destroyed,
|
|
on(event, listener) {
|
|
handlers.set(event, listener)
|
|
}
|
|
}
|
|
|
|
let calls = 0
|
|
installZoomReassertOnWindowEvents(win, () => {
|
|
calls += 1
|
|
})
|
|
destroyed = true
|
|
handlers.get('show')()
|
|
assert.equal(calls, 0)
|
|
})
|
|
|
|
// Zoom-wiring contract: chat windows keep global UI zoom, the pet overlay
|
|
// opts out. Tested via the extracted config — no source-text regex.
|
|
test('chat windows opt into zoom', () => {
|
|
assert.deepEqual(zoomWiringForWindowKind('chat'), { zoom: true })
|
|
})
|
|
|
|
test('pet overlay opts out of zoom', () => {
|
|
assert.deepEqual(zoomWiringForWindowKind('petOverlay'), { zoom: false })
|
|
})
|
|
|
|
test('unknown window kinds default to chat (zoom enabled)', () => {
|
|
assert.deepEqual(zoomWiringForWindowKind('unknown'), { zoom: true })
|
|
assert.deepEqual(zoomWiringForWindowKind(undefined), { zoom: true })
|
|
})
|
|
|
|
// The UI Scale settings control drifts out of sync after a restart when zoom
|
|
// is applied to the window but the renderer is never told: its $zoomPercent
|
|
// store (see store/zoom.ts) only updates from zoom.get() (once, on load) and
|
|
// 'hermes:zoom:changed' events. applyZoomLevel is the single funnel every zoom
|
|
// path (user set, restore-on-load, lifecycle re-assert) shares, so applying a
|
|
// level always notifies — the regression can't come back by forgetting a send.
|
|
function fakeWebContents() {
|
|
const calls: Array<[string, ...unknown[]]> = []
|
|
|
|
return {
|
|
calls,
|
|
setZoomLevel: (level: number) => calls.push(['setZoomLevel', level]),
|
|
send: (channel: string, payload: unknown) => calls.push(['send', channel, payload])
|
|
}
|
|
}
|
|
|
|
test('applyZoomLevel applies the level then notifies the renderer', () => {
|
|
const wc = fakeWebContents()
|
|
const applied = applyZoomLevel(wc, 3)
|
|
|
|
assert.equal(applied, 3)
|
|
assert.deepEqual(wc.calls, [
|
|
['setZoomLevel', 3],
|
|
['send', 'hermes:zoom:changed', { level: 3, percent: zoomLevelToPercent(3) }]
|
|
])
|
|
})
|
|
|
|
test('applyZoomLevel clamps garbage before applying and notifying', () => {
|
|
const wc = fakeWebContents()
|
|
const applied = applyZoomLevel(wc, 999)
|
|
const clamped = clampZoomLevel(999)
|
|
|
|
assert.equal(applied, clamped)
|
|
assert.deepEqual(wc.calls, [
|
|
['setZoomLevel', clamped],
|
|
['send', 'hermes:zoom:changed', { level: clamped, percent: zoomLevelToPercent(clamped) }]
|
|
])
|
|
})
|