mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-05-08 03:01:47 +00:00
76d2dcdc8e
The original #21086 report was theme-accent opaque fills behind JSON payload values in the Kanban Task Drawer's EVENTS section. The first iteration of this fix was narrow — add ``!important`` to the specific drawer/payload overrides. But "all themes" includes user-installable themes we haven't written yet, and any theme doing the normal ``code { background: ... !important }`` dance would break this again. Replace the whack-a-mole approach with a structural reset: 1. Inside ``.hermes-kanban`` (and the ``.hermes-kanban-drawer`` portal container), reset EVERY ``<code>`` and ``<pre>`` to transparent with ``!important``. This is the new default. 2. Opt back in ONLY on the classes that carry intentional pill styling: - ``.hermes-kanban .hermes-kanban-md code`` (inline code in task Markdown body) — ``:not()`` scoped to exclude fenced blocks. - ``.hermes-kanban pre.hermes-kanban-md-code`` (fenced block wrapper) — higher specificity than the reset so it wins cleanly. Net effect: any theme — shipped or third-party — can ship whatever global ``code``/``pre`` rule it wants; kanban surfaces stay clean unless the theme deliberately targets our internal class names, which would be a conscious override rather than an accidental breakage. Verified live against a hostile synthetic theme that paints ``code``, ``pre``, AND ``.hermes-kanban code`` / ``.hermes-kanban pre`` with ``background: !important`` fills. Every kanban surface stayed correct (transparent where expected, intentional pill fill where expected). Also verified across all 7 shipped themes by pointing a headless browser at a live dashboard. | Surface | Expected | Got | |----------------------------------------------------|--------------------|-------------------| | Outside ``.hermes-kanban`` (sanity) | hostile fill | hostile fill ✓ | | Drawer ``.hermes-kanban-event-payload`` (the bug) | transparent | transparent ✓ | | Drawer bare ``<code>`` | transparent | transparent ✓ | | Drawer bare ``<pre>`` | transparent | transparent ✓ | | Markdown inline ``<code>`` | subtle pill | subtle pill ✓ | | Markdown fenced block ``.hermes-kanban-md-code`` | subtle pill | subtle pill ✓ | | Markdown fenced inner ``<code>`` | transparent | transparent ✓ | Closes #21086. |
||
|---|---|---|
| .. | ||
| context_engine | ||
| disk-cleanup | ||
| example-dashboard/dashboard | ||
| google_meet | ||
| hermes-achievements | ||
| image_gen | ||
| kanban | ||
| memory | ||
| model-providers | ||
| observability/langfuse | ||
| platforms | ||
| spotify | ||
| strike-freedom-cockpit | ||
| __init__.py | ||