mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-04-25 00:51:20 +00:00
48ecb98f8a
Adds role='leaf'|'orchestrator' to delegate_task. With max_spawn_depth>=2, an orchestrator child retains the 'delegation' toolset and can spawn its own workers; leaf children cannot delegate further (identical to today). Default posture is flat — max_spawn_depth=1 means a depth-0 parent's children land at the depth-1 floor and orchestrator role silently degrades to leaf. Users opt into nested delegation by raising max_spawn_depth to 2 or 3 in config.yaml. Also threads acp_command/acp_args through the main agent loop's delegate dispatch (previously silently dropped in the schema) via a new _dispatch_delegate_task helper, and adds a DelegateEvent enum with legacy-string back-compat for gateway/ACP/CLI progress consumers. Config (hermes_cli/config.py defaults): delegation.max_concurrent_children: 3 # floor-only, no upper cap delegation.max_spawn_depth: 1 # 1=flat (default), 2-3 unlock nested delegation.orchestrator_enabled: true # global kill switch Salvaged from @pefontana's PR #11215. Overrides vs. the original PR: concurrency stays at 3 (PR bumped to 5 + cap 8 — we keep the floor only, no hard ceiling); max_spawn_depth defaults to 1 (PR defaulted to 2 which silently enabled one level of orchestration for every user). Co-authored-by: pefontana <fontana.pedro93@gmail.com>
36 lines
1.6 KiB
Python
36 lines
1.6 KiB
Python
"""Regression tests for removed dead config keys.
|
|
|
|
This file guards against accidental re-introduction of config keys that were
|
|
documented or declared at some point but never actually wired up to read code.
|
|
Future dead-config regressions can accumulate here.
|
|
"""
|
|
|
|
import inspect
|
|
|
|
|
|
def test_delegation_default_toolsets_removed_from_cli_config():
|
|
"""delegation.default_toolsets was dead config — never read by
|
|
_load_config() or anywhere else. Removed.
|
|
|
|
Guards against accidental re-introduction in cli.py's CLI_CONFIG default
|
|
dict. If this test fails, someone re-added the key without wiring it up
|
|
to _load_config() in tools/delegate_tool.py.
|
|
|
|
We inspect the source of load_cli_config() instead of asserting on the
|
|
runtime CLI_CONFIG dict because CLI_CONFIG is populated by deep-merging
|
|
the user's ~/.hermes/config.yaml over the defaults (cli.py:359-366).
|
|
A contributor who still has the legacy key set in their own config
|
|
would cause a false failure, and HERMES_HOME patching via conftest
|
|
doesn't help because cli._hermes_home is frozen at module import time
|
|
(cli.py:76) — before any autouse fixture can fire. Source inspection
|
|
sidesteps all of that: it tests the defaults literal directly.
|
|
"""
|
|
from cli import load_cli_config
|
|
|
|
source = inspect.getsource(load_cli_config)
|
|
assert '"default_toolsets"' not in source, (
|
|
"delegation.default_toolsets was removed because it was never read. "
|
|
"Do not re-add it to cli.py's CLI_CONFIG default dict; "
|
|
"use tools/delegate_tool.py's DEFAULT_TOOLSETS module constant or "
|
|
"wire a new config key through _load_config()."
|
|
)
|