mirror of https://github.com/NousResearch/hermes-agent.git synced 2026-07-28 18:19:28 +00:00

History

teknium1 75e0d52034 fix(windows): sweep remaining bare read_text/write_text sites + linter rule AST-driven pass over every Path.read_text()/write_text() without an explicit encoding= across non-test code: 71 sites in 34 files (skills_hub, hermes_cli/main+profiles+service_manager+container_boot, mem0/hindsight/honcho plugins, achievements dashboard, release/CI scripts, productivity+comfyui skill helpers, agent/*). Verified zero positional-encoding collisions before insertion; per-file compile() check after. Adds a check-windows-footguns rule flagging bare single-line read_text/write_text (multi-line forms stay covered by the AST guard test from #38985). Together with the salvaged contributor commits this retires the ~169-site bare file-I/O class (#37423's long tail).		2026-07-24 17:10:39 -07:00
..
conftest.py	fix(windows): sweep remaining bare read_text/write_text sites + linter rule	2026-07-24 17:10:39 -07:00
pytest.ini	fix(skills/comfyui): bug fixes, cloud parity, expanded coverage, examples, tests	2026-04-29 20:48:01 -07:00
README.md	fix(skills/comfyui): bug fixes, cloud parity, expanded coverage, examples, tests	2026-04-29 20:48:01 -07:00
test_check_deps.py	fix(skills/comfyui): correct hallucinated node names and registry slugs	2026-04-29 20:48:01 -07:00
test_cloud_integration.py	chore: ruff auto-fix PLR6201 resweep — tuple → set in membership tests (#27355 )	2026-05-17 02:29:41 -07:00
test_common.py	fix(windows): sweep remaining bare read_text/write_text sites + linter rule	2026-07-24 17:10:39 -07:00
test_extract_schema.py	chore: prune unused imports and duplicate import redefinitions	2026-05-28 22:26:25 -07:00
test_run_workflow.py	fix(windows): sweep remaining bare read_text/write_text sites + linter rule	2026-07-24 17:10:39 -07:00

README.md

ComfyUI Skill Tests

Pytest suite covering the skill's scripts. Pure-stdlib unit tests run without any setup; cloud integration tests need a Comfy Cloud API key.

Running

# Unit tests only (no network required) — runs in <1s
python3 -m pytest tests/ -c tests/pytest.ini -o addopts="-p no:xdist"

# Including cloud integration tests
COMFY_CLOUD_API_KEY="comfyui-..." python3 -m pytest tests/ \
  -c tests/pytest.ini -o addopts="-p no:xdist"

# Just cloud tests
COMFY_CLOUD_API_KEY="comfyui-..." python3 -m pytest tests/test_cloud_integration.py \
  -c tests/pytest.ini -o addopts="-p no:xdist" -v

The -c and -o overrides isolate this suite from any parent pyproject.toml pytest config (e.g. the -n auto from a parent repo).

Test files

File	Coverage
`test_common.py`	Cloud detection, URL routing, format validation, embeddings, paths, seeds, model-list parsing, folder aliases
`test_extract_schema.py`	Connection tracing, positive/negative prompt detection, dedup logic, embedding deps
`test_run_workflow.py`	Param injection (incl. -1 seed, link refusal), output download walk, runner construction
`test_check_deps.py`	Model-name fuzzy matching, install command suggestions
`test_cloud_integration.py`	Live cloud API contract tests (auto-skipped without API key)

Adding tests

When you change a script:

Add a unit test if the change is pure logic (cloud detection, parsing, etc.)
Add a cloud integration test if the change depends on cloud API behavior (use pytestmark = pytest.mark.cloud so it auto-skips without a key)
Workflow fixtures live in conftest.py (sd15_workflow, flux_workflow, video_workflow)

Why the explicit `-c` / `-o`?

The parent hermes-agent repo's pyproject.toml enables pytest-xdist by default (-n auto). This suite is small enough that parallelism isn't worth the complexity, and pytest-xdist isn't always installed in the user's environment. The -c tests/pytest.ini -o addopts="-p no:xdist" flags make the suite run identically regardless of the parent project's config.