mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-05-29 06:31:32 +00:00
First migration of an existing built-in platform adapter to the plugin system established by IRC / Teams / LINE / Google Chat. Closes #24325; advances the umbrella refactor in #3823. Matches Teams' shape exactly — adapter under ``plugins/platforms/discord/`` with the standard ``__init__.py`` / ``adapter.py`` / ``plugin.yaml`` shell, ``register(ctx)`` entry point, **no back-compat shim** at the old import path, and full parity for the four hooks Teams uses plus the ``apply_yaml_config_fn`` hook that landed in #25443 (the Discord plugin is the first consumer of that hook): * ``standalone_sender_fn`` — out-of-process cron delivery via REST API * ``setup_fn`` — interactive ``hermes setup gateway`` wizard * ``apply_yaml_config_fn`` — translate ``config.yaml`` ``discord:`` keys into ``DISCORD_*`` env vars (replaces the hardcoded block in ``gateway/config.py``) * ``is_connected`` — declares connection state from ``DISCORD_BOT_TOKEN`` * ``check_fn`` — lazy-installs ``discord.py`` on demand * plus ``allowed_users_env``, ``allow_all_env``, ``cron_deliver_env_var``, ``max_message_length``, ``emoji``, ``required_env``, ``install_hint`` * ``gateway/platforms/discord.py`` (5,101 LOC) → ``plugins/platforms/discord/adapter.py`` (git rename, R090). * New ``plugins/platforms/discord/{__init__.py, plugin.yaml}`` with ``requires_env`` / ``optional_env`` declarations. * Append ``register(ctx)`` block + new hook implementations (``_standalone_send``, ``interactive_setup``, ``_apply_yaml_config``, ``_clean_discord_user_ids``, ``_is_connected``, ``_build_adapter``, plus helpers ``_DISCORD_CHANNEL_TYPE_PROBE_CACHE`` etc.) to the adapter. * Replace the ``Platform.DISCORD elif`` branch in ``GatewayRunner._create_adapter()`` (−9 LOC) with a generic post-creation hook (+6 LOC) in the registry path: any plugin adapter that declares a ``gateway_runner`` attribute now gets it auto-injected. Webhook's built-in branch is unchanged (it doesn't go through the registry path). * Move ``_send_discord`` (190 LOC) and helpers (``_DISCORD_CHANNEL_TYPE_PROBE_CACHE``, ``_remember_channel_is_forum``, ``_probe_is_forum_cached``, ``_derive_forum_thread_name``) from ``tools/send_message_tool.py`` into the plugin as ``_standalone_send``. * Wire via ``standalone_sender_fn=_standalone_send`` (Teams pattern; same gap fixed in #21804 for other plugin platforms). * Replace the Discord ``elif`` in ``tools/send_message_tool.py`` ``_send_to_platform`` with a 10-line registry-hook dispatch. * Drop the ``DiscordAdapter`` import and the ``Platform.DISCORD: DiscordAdapter.MAX_MESSAGE_LENGTH`` ``_MAX_LENGTHS`` entry — the registry's ``max_message_length=2000`` covers it. * Move ``_setup_discord`` and ``_clean_discord_user_ids`` (68 LOC) from ``hermes_cli/setup.py`` into the plugin as ``interactive_setup``. * Wire via ``setup_fn=interactive_setup``. CLI helpers (``prompt``, ``print_info``, etc.) are lazy-imported so the plugin's module-load surface stays minimal. * Remove ``"discord": _s._setup_discord`` from ``hermes_cli/gateway.py::_builtin_setup_fn``. * Remove the entire 32-line ``_PLATFORMS["discord"]`` static dict entry — Discord's setup metadata is now discovered dynamically via ``_all_platforms()`` from the registry entry. * Move the 59-line ``discord_cfg`` YAML→env bridge from ``gateway/config.py::load_gateway_config()`` into the plugin as ``_apply_yaml_config``. Covers ``require_mention``, ``thread_require_mention``, ``free_response_channels``, ``auto_thread``, ``reactions``, ``ignored_channels``, ``allowed_channels``, ``no_thread_channels``, ``allow_mentions.{everyone,roles,users, replied_user}``, and ``reply_to_mode`` (including the YAML 1.1 ``off``-as-False coercion and the ``extra.reply_to_mode`` fallback). * Wire via ``apply_yaml_config_fn=_apply_yaml_config``. * The hook runs BEFORE ``_apply_env_overrides`` and after the generic shared-key loop, exactly as documented in ``website/docs/developer-guide/adding-platform-adapters.md``. * Behavior is preserved exactly — every assignment still uses ``not os.getenv(...)`` guards so env vars take precedence over YAML. All 78 references to the old import path are rewritten — no back-compat shim: * 51 ``from gateway.platforms.discord import X`` → ``from plugins.platforms.discord.adapter import X`` * 5 ``import gateway.platforms.discord as discord_platform`` → ``import plugins.platforms.discord.adapter as discord_platform`` * 1 ``from gateway.platforms import discord as discord_mod`` → ``from plugins.platforms.discord import adapter as discord_mod`` * 21 ``mock.patch("gateway.platforms.discord.X")`` strings → ``mock.patch("plugins.platforms.discord.adapter.X")`` * 1 docstring reference in ``hermes_cli/commands.py`` * 1 import in ``tools/send_message_tool.py`` (now removed entirely) The import-safety test in ``tests/gateway/test_discord_imports.py`` is updated to purge the new canonical module name from ``sys.modules``. **38 files changed, +621 / −473** — net positive due to the YAML hook implementation (89 new LOC in the plugin trading for 59 deleted in core), but every line moved has a clear plugin home now. The git rename is detected at R090 because the adapter gained ~340 LOC of moved-in hook implementations (``_standalone_send`` + ``interactive_setup`` + ``_apply_yaml_config`` + helpers). * All 568 Discord-specific tests pass across 25 ``test_discord_*.py`` files plus voice/send/text-batching/reload-skills/stream-consumer/ integration tests. * All 147 tests in the YAML-touching subset (``test_discord_reply_mode``, ``test_discord_free_response``, ``test_discord_allowed_channels``, ``test_discord_allowed_mentions``, ``test_discord_channel_controls``, ``test_discord_reactions``, ``test_discord_thread_persistence``, ``test_runtime_footer``) pass — this is the strongest signal that the YAML→env hook behaves identically to the legacy block. * Broader gateway/cron/integration sweep (1297 tests) introduces zero new failures vs ``main``. Pre-existing failures in ``tests/gateway/test_tts_media_routing.py`` and ``tests/e2e/test_platform_commands.py`` reproduce identically on the unchanged ``main`` revision. * Plugin discovery sanity check confirms Discord registers alongside the other four platform plugins: Registered platforms: ['discord', 'google_chat', 'irc', 'line', 'teams'] These Discord-shaped tendrils in core were **deliberately not moved** — they are generic platform-registry concerns affecting every platform, not Discord-specific: * ``gateway/config.py:1205`` ``DISCORD_BOT_TOKEN → config.token`` env enablement — same shape Telegram has. The existing ``env_enablement_fn`` registry hook only seeds ``extra``, not ``.token``, so it can't replace this without an adapter refactor to read from ``extra["bot_token"]``. * ``gateway/run.py`` voice-mode hooks (``self.adapters.get(Platform.DISCORD)`` for ``start_voice_mode``/``stop_voice_mode``), role-based auth, ``DISCORD_ALLOW_BOTS`` branch in ``_is_user_authorized``, ``_UPDATE_ALLOWED_PLATFORMS`` frozenset, and the per-platform allowlist maps — generic platform-registry concerns. * ``Platform.DISCORD`` enum literal — stable identifier used as dict keys throughout the codebase; removing it is a separate refactor with no real benefit. * ``tools/discord_tool.py`` and ``tools/environments/local.py`` — first-class agent tools and env-passthrough config, neither is the gateway adapter. Each of these is worth its own scoping issue when the time comes.
437 lines
16 KiB
Python
437 lines
16 KiB
Python
"""
|
|
Tests for send_image_file() on Telegram, Discord, and Slack platforms,
|
|
and MEDIA: .png extraction/routing in the base platform adapter.
|
|
|
|
Covers: local image file sending, file-not-found handling, fallback on error,
|
|
MEDIA: tag extraction for image extensions, and routing to send_image_file.
|
|
"""
|
|
|
|
import asyncio
|
|
import os
|
|
import sys
|
|
from unittest.mock import AsyncMock, MagicMock, patch
|
|
|
|
import pytest
|
|
|
|
from gateway.config import PlatformConfig
|
|
from gateway.platforms.base import BasePlatformAdapter, SendResult
|
|
|
|
|
|
def _run(coro):
|
|
"""Run a coroutine in a fresh event loop for sync-style tests."""
|
|
return asyncio.run(coro)
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# MEDIA: extraction tests for image files
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
class TestExtractMediaImages:
|
|
"""Test that MEDIA: tags with image extensions are correctly extracted."""
|
|
|
|
def test_png_image_extracted(self):
|
|
content = "Here is the screenshot:\nMEDIA:/home/user/.hermes/browser_screenshots/shot.png"
|
|
media, cleaned = BasePlatformAdapter.extract_media(content)
|
|
assert len(media) == 1
|
|
assert media[0][0] == "/home/user/.hermes/browser_screenshots/shot.png"
|
|
assert "MEDIA:" not in cleaned
|
|
assert "Here is the screenshot" in cleaned
|
|
|
|
def test_jpg_image_extracted(self):
|
|
content = "MEDIA:/tmp/photo.jpg"
|
|
media, cleaned = BasePlatformAdapter.extract_media(content)
|
|
assert len(media) == 1
|
|
assert media[0][0] == "/tmp/photo.jpg"
|
|
|
|
def test_webp_image_extracted(self):
|
|
content = "MEDIA:/tmp/image.webp"
|
|
media, _ = BasePlatformAdapter.extract_media(content)
|
|
assert len(media) == 1
|
|
|
|
def test_mixed_audio_and_image(self):
|
|
content = "MEDIA:/audio.ogg\nMEDIA:/screenshot.png"
|
|
media, _ = BasePlatformAdapter.extract_media(content)
|
|
assert len(media) == 2
|
|
paths = [m[0] for m in media]
|
|
assert "/audio.ogg" in paths
|
|
assert "/screenshot.png" in paths
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Telegram send_image_file tests
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
def _ensure_telegram_mock():
|
|
"""Install mock telegram modules so TelegramAdapter can be imported."""
|
|
if "telegram" in sys.modules and hasattr(sys.modules["telegram"], "__file__"):
|
|
return
|
|
|
|
telegram_mod = MagicMock()
|
|
telegram_mod.ext.ContextTypes.DEFAULT_TYPE = type(None)
|
|
telegram_mod.constants.ParseMode.MARKDOWN_V2 = "MarkdownV2"
|
|
telegram_mod.constants.ChatType.GROUP = "group"
|
|
telegram_mod.constants.ChatType.SUPERGROUP = "supergroup"
|
|
telegram_mod.constants.ChatType.CHANNEL = "channel"
|
|
telegram_mod.constants.ChatType.PRIVATE = "private"
|
|
|
|
for name in ("telegram", "telegram.ext", "telegram.constants", "telegram.request"):
|
|
sys.modules.setdefault(name, telegram_mod)
|
|
|
|
|
|
_ensure_telegram_mock()
|
|
|
|
from gateway.platforms.telegram import TelegramAdapter # noqa: E402
|
|
|
|
|
|
class TestTelegramSendImageFile:
|
|
@pytest.fixture
|
|
def adapter(self):
|
|
config = PlatformConfig(enabled=True, token="fake-token")
|
|
a = TelegramAdapter(config)
|
|
a._bot = MagicMock()
|
|
return a
|
|
|
|
def test_sends_local_image_as_photo(self, adapter, tmp_path):
|
|
"""send_image_file should call bot.send_photo with the opened file."""
|
|
img = tmp_path / "screenshot.png"
|
|
img.write_bytes(b"\x89PNG\r\n\x1a\n" + b"\x00" * 100) # Minimal PNG-like
|
|
|
|
mock_msg = MagicMock()
|
|
mock_msg.message_id = 42
|
|
adapter._bot.send_photo = AsyncMock(return_value=mock_msg)
|
|
|
|
result = _run(
|
|
adapter.send_image_file(chat_id="12345", image_path=str(img))
|
|
)
|
|
assert result.success
|
|
assert result.message_id == "42"
|
|
adapter._bot.send_photo.assert_awaited_once()
|
|
|
|
# Verify photo arg was a file object (opened in rb mode)
|
|
call_kwargs = adapter._bot.send_photo.call_args
|
|
assert call_kwargs.kwargs["chat_id"] == 12345
|
|
|
|
def test_returns_error_when_file_missing(self, adapter):
|
|
"""send_image_file should return error for nonexistent file."""
|
|
result = _run(
|
|
adapter.send_image_file(chat_id="12345", image_path="/nonexistent/image.png")
|
|
)
|
|
assert not result.success
|
|
assert "not found" in result.error
|
|
|
|
def test_returns_error_when_not_connected(self, adapter):
|
|
"""send_image_file should return error when bot is None."""
|
|
adapter._bot = None
|
|
result = _run(
|
|
adapter.send_image_file(chat_id="12345", image_path="/tmp/img.png")
|
|
)
|
|
assert not result.success
|
|
assert "Not connected" in result.error
|
|
|
|
def test_caption_truncated_to_1024(self, adapter, tmp_path):
|
|
"""Telegram captions have a 1024 char limit."""
|
|
img = tmp_path / "shot.png"
|
|
img.write_bytes(b"\x89PNG" + b"\x00" * 50)
|
|
|
|
mock_msg = MagicMock()
|
|
mock_msg.message_id = 1
|
|
adapter._bot.send_photo = AsyncMock(return_value=mock_msg)
|
|
|
|
long_caption = "A" * 2000
|
|
_run(
|
|
adapter.send_image_file(chat_id="12345", image_path=str(img), caption=long_caption)
|
|
)
|
|
|
|
call_kwargs = adapter._bot.send_photo.call_args.kwargs
|
|
assert len(call_kwargs["caption"]) == 1024
|
|
|
|
def test_thread_id_forwarded(self, adapter, tmp_path):
|
|
"""metadata thread_id is forwarded as message_thread_id (required for Telegram forum groups)."""
|
|
img = tmp_path / "shot.png"
|
|
img.write_bytes(b"\x89PNG" + b"\x00" * 50)
|
|
|
|
mock_msg = MagicMock()
|
|
mock_msg.message_id = 43
|
|
adapter._bot.send_photo = AsyncMock(return_value=mock_msg)
|
|
|
|
_run(
|
|
adapter.send_image_file(
|
|
chat_id="12345",
|
|
image_path=str(img),
|
|
metadata={"thread_id": "789"},
|
|
)
|
|
)
|
|
|
|
call_kwargs = adapter._bot.send_photo.call_args.kwargs
|
|
assert call_kwargs["message_thread_id"] == 789
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Discord send_image_file tests
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
def _ensure_discord_mock():
|
|
"""Install mock discord module so DiscordAdapter can be imported."""
|
|
if "discord" in sys.modules and hasattr(sys.modules["discord"], "__file__"):
|
|
return
|
|
|
|
discord_mod = MagicMock()
|
|
discord_mod.Intents.default.return_value = MagicMock()
|
|
discord_mod.Client = MagicMock
|
|
discord_mod.File = MagicMock
|
|
|
|
for name in ("discord", "discord.ext", "discord.ext.commands"):
|
|
sys.modules.setdefault(name, discord_mod)
|
|
|
|
|
|
_ensure_discord_mock()
|
|
|
|
import discord as discord_mod_ref # noqa: E402
|
|
from plugins.platforms.discord.adapter import DiscordAdapter # noqa: E402
|
|
|
|
|
|
class TestDiscordSendImageFile:
|
|
@pytest.fixture
|
|
def adapter(self):
|
|
config = PlatformConfig(enabled=True, token="fake-token")
|
|
a = DiscordAdapter(config)
|
|
a._client = MagicMock()
|
|
return a
|
|
|
|
def test_sends_local_image_as_attachment(self, adapter, tmp_path):
|
|
"""send_image_file should create discord.File and send to channel."""
|
|
img = tmp_path / "screenshot.png"
|
|
img.write_bytes(b"\x89PNG" + b"\x00" * 50)
|
|
|
|
mock_channel = MagicMock()
|
|
mock_msg = MagicMock()
|
|
mock_msg.id = 99
|
|
mock_channel.send = AsyncMock(return_value=mock_msg)
|
|
adapter._client.get_channel = MagicMock(return_value=mock_channel)
|
|
|
|
result = _run(
|
|
adapter.send_image_file(chat_id="67890", image_path=str(img))
|
|
)
|
|
assert result.success
|
|
assert result.message_id == "99"
|
|
mock_channel.send.assert_awaited_once()
|
|
|
|
def test_send_document_uploads_file_attachment(self, adapter, tmp_path):
|
|
"""send_document should upload a native Discord attachment."""
|
|
pdf = tmp_path / "sample.pdf"
|
|
pdf.write_bytes(b"%PDF-1.4\n%\xe2\xe3\xcf\xd3\n")
|
|
|
|
mock_channel = MagicMock()
|
|
mock_msg = MagicMock()
|
|
mock_msg.id = 100
|
|
mock_channel.send = AsyncMock(return_value=mock_msg)
|
|
adapter._client.get_channel = MagicMock(return_value=mock_channel)
|
|
|
|
with patch.object(discord_mod_ref, "File", MagicMock()) as file_cls:
|
|
result = _run(
|
|
adapter.send_document(
|
|
chat_id="67890",
|
|
file_path=str(pdf),
|
|
file_name="renamed.pdf",
|
|
metadata={"thread_id": "123"},
|
|
)
|
|
)
|
|
|
|
assert result.success
|
|
assert result.message_id == "100"
|
|
assert "file" in mock_channel.send.call_args.kwargs
|
|
assert file_cls.call_args.kwargs["filename"] == "renamed.pdf"
|
|
|
|
def test_send_video_uploads_file_attachment(self, adapter, tmp_path):
|
|
"""send_video should upload a native Discord attachment."""
|
|
video = tmp_path / "clip.mp4"
|
|
video.write_bytes(b"\x00\x00\x00\x18ftypmp42" + b"\x00" * 50)
|
|
|
|
mock_channel = MagicMock()
|
|
mock_msg = MagicMock()
|
|
mock_msg.id = 101
|
|
mock_channel.send = AsyncMock(return_value=mock_msg)
|
|
adapter._client.get_channel = MagicMock(return_value=mock_channel)
|
|
|
|
with patch.object(discord_mod_ref, "File", MagicMock()) as file_cls:
|
|
result = _run(
|
|
adapter.send_video(
|
|
chat_id="67890",
|
|
video_path=str(video),
|
|
metadata={"thread_id": "123"},
|
|
)
|
|
)
|
|
|
|
assert result.success
|
|
assert result.message_id == "101"
|
|
assert "file" in mock_channel.send.call_args.kwargs
|
|
assert file_cls.call_args.kwargs["filename"] == "clip.mp4"
|
|
|
|
def test_returns_error_when_file_missing(self, adapter):
|
|
result = _run(
|
|
adapter.send_image_file(chat_id="67890", image_path="/nonexistent.png")
|
|
)
|
|
assert not result.success
|
|
assert "not found" in result.error
|
|
|
|
def test_returns_error_when_not_connected(self, adapter):
|
|
adapter._client = None
|
|
result = _run(
|
|
adapter.send_image_file(chat_id="67890", image_path="/tmp/img.png")
|
|
)
|
|
assert not result.success
|
|
assert "Not connected" in result.error
|
|
|
|
def test_handles_missing_channel(self, adapter):
|
|
adapter._client.get_channel = MagicMock(return_value=None)
|
|
adapter._client.fetch_channel = AsyncMock(return_value=None)
|
|
|
|
result = _run(
|
|
adapter.send_image_file(chat_id="99999", image_path="/tmp/img.png")
|
|
)
|
|
assert not result.success
|
|
assert "not found" in result.error
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Slack send_image_file tests
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
def _ensure_slack_mock():
|
|
"""Install mock slack_bolt module so SlackAdapter can be imported."""
|
|
if "slack_bolt" in sys.modules and hasattr(sys.modules["slack_bolt"], "__file__"):
|
|
return
|
|
|
|
slack_mod = MagicMock()
|
|
for name in ("slack_bolt", "slack_bolt.async_app", "slack_sdk", "slack_sdk.web.async_client"):
|
|
sys.modules.setdefault(name, slack_mod)
|
|
|
|
|
|
_ensure_slack_mock()
|
|
|
|
from gateway.platforms.slack import SlackAdapter # noqa: E402
|
|
|
|
|
|
class TestSlackSendImageFile:
|
|
@pytest.fixture
|
|
def adapter(self):
|
|
config = PlatformConfig(enabled=True, token="xoxb-fake")
|
|
a = SlackAdapter(config)
|
|
a._app = MagicMock()
|
|
return a
|
|
|
|
def test_sends_local_image_via_upload(self, adapter, tmp_path):
|
|
"""send_image_file should call files_upload_v2 with the local path."""
|
|
img = tmp_path / "screenshot.png"
|
|
img.write_bytes(b"\x89PNG" + b"\x00" * 50)
|
|
|
|
mock_result = MagicMock()
|
|
adapter._app.client.files_upload_v2 = AsyncMock(return_value=mock_result)
|
|
|
|
result = _run(
|
|
adapter.send_image_file(chat_id="C12345", image_path=str(img))
|
|
)
|
|
assert result.success
|
|
adapter._app.client.files_upload_v2.assert_awaited_once()
|
|
|
|
call_kwargs = adapter._app.client.files_upload_v2.call_args.kwargs
|
|
assert call_kwargs["file"] == str(img)
|
|
assert call_kwargs["filename"] == "screenshot.png"
|
|
assert call_kwargs["channel"] == "C12345"
|
|
|
|
def test_returns_error_when_file_missing(self, adapter):
|
|
result = _run(
|
|
adapter.send_image_file(chat_id="C12345", image_path="/nonexistent.png")
|
|
)
|
|
assert not result.success
|
|
assert "not found" in result.error
|
|
|
|
def test_returns_error_when_not_connected(self, adapter):
|
|
adapter._app = None
|
|
result = _run(
|
|
adapter.send_image_file(chat_id="C12345", image_path="/tmp/img.png")
|
|
)
|
|
assert not result.success
|
|
assert "Not connected" in result.error
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# browser_vision screenshot cleanup tests
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
class TestScreenshotCleanup:
|
|
def test_cleanup_removes_old_screenshots(self, tmp_path):
|
|
"""_cleanup_old_screenshots should remove files older than max_age_hours."""
|
|
import time
|
|
from tools.browser_tool import _cleanup_old_screenshots, _last_screenshot_cleanup_by_dir
|
|
|
|
_last_screenshot_cleanup_by_dir.clear()
|
|
|
|
# Create a "fresh" file
|
|
fresh = tmp_path / "browser_screenshot_fresh.png"
|
|
fresh.write_bytes(b"new")
|
|
|
|
# Create an "old" file and backdate its mtime
|
|
old = tmp_path / "browser_screenshot_old.png"
|
|
old.write_bytes(b"old")
|
|
old_time = time.time() - (25 * 3600) # 25 hours ago
|
|
os.utime(str(old), (old_time, old_time))
|
|
|
|
_cleanup_old_screenshots(tmp_path, max_age_hours=24)
|
|
|
|
assert fresh.exists(), "Fresh screenshot should not be removed"
|
|
assert not old.exists(), "Old screenshot should be removed"
|
|
|
|
def test_cleanup_is_throttled_per_directory(self, tmp_path):
|
|
import time
|
|
from tools.browser_tool import _cleanup_old_screenshots, _last_screenshot_cleanup_by_dir
|
|
|
|
_last_screenshot_cleanup_by_dir.clear()
|
|
|
|
old = tmp_path / "browser_screenshot_old.png"
|
|
old.write_bytes(b"old")
|
|
old_time = time.time() - (25 * 3600)
|
|
os.utime(str(old), (old_time, old_time))
|
|
|
|
_cleanup_old_screenshots(tmp_path, max_age_hours=24)
|
|
assert not old.exists()
|
|
|
|
old.write_bytes(b"old-again")
|
|
os.utime(str(old), (old_time, old_time))
|
|
_cleanup_old_screenshots(tmp_path, max_age_hours=24)
|
|
|
|
assert old.exists(), "Repeated cleanup should be skipped while throttled"
|
|
|
|
def test_cleanup_ignores_non_screenshot_files(self, tmp_path):
|
|
"""Only files matching browser_screenshot_*.png should be cleaned."""
|
|
import time
|
|
from tools.browser_tool import _cleanup_old_screenshots, _last_screenshot_cleanup_by_dir
|
|
|
|
_last_screenshot_cleanup_by_dir.clear()
|
|
|
|
other_file = tmp_path / "important_data.txt"
|
|
other_file.write_bytes(b"keep me")
|
|
old_time = time.time() - (48 * 3600)
|
|
os.utime(str(other_file), (old_time, old_time))
|
|
|
|
_cleanup_old_screenshots(tmp_path, max_age_hours=24)
|
|
|
|
assert other_file.exists(), "Non-screenshot files should not be touched"
|
|
|
|
def test_cleanup_handles_empty_dir(self, tmp_path):
|
|
"""Cleanup should not fail on empty directory."""
|
|
from tools.browser_tool import _cleanup_old_screenshots, _last_screenshot_cleanup_by_dir
|
|
_last_screenshot_cleanup_by_dir.clear()
|
|
_cleanup_old_screenshots(tmp_path, max_age_hours=24) # Should not raise
|
|
|
|
def test_cleanup_handles_nonexistent_dir(self):
|
|
"""Cleanup should not fail if directory doesn't exist."""
|
|
from pathlib import Path
|
|
from tools.browser_tool import _cleanup_old_screenshots, _last_screenshot_cleanup_by_dir
|
|
_last_screenshot_cleanup_by_dir.clear()
|
|
_cleanup_old_screenshots(Path("/nonexistent/dir"), max_age_hours=24) # Should not raise
|