mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-04-25 00:51:20 +00:00
2367c6ffd5
First pass of test-suite reduction to address flaky CI and bloat. Removed tests that fall into these change-detector patterns: 1. Source-grep tests (tests/gateway/test_feishu.py, test_email.py): tests that call inspect.getsource() on production modules and grep for string literals. Break on any refactor/rename even when behavior is correct. 2. Platform enum tautologies (every gateway/test_X.py): assertions like `Platform.X.value == 'x'` duplicated across ~9 adapter test files. 3. Toolset/PLATFORM_HINTS/setup-wizard registry-presence checks: tests that only verify a key exists in a dict. Data-layout tests, not behavior. 4. Argparse wiring tests (test_argparse_flag_propagation, test_subparser_routing _fallback): tests that do parser.parse_args([...]) then assert args.field. Tests Python's argparse, not our code. 5. Pure dispatch tests (test_plugins_cmd.TestPluginsCommandDispatch): patch cmd_X, call plugins_command with matching action, assert mock called. Tests the if/elif chain, not behavior. 6. Kwarg-to-mock verification (test_auxiliary_client ~45 tests, test_web_tools_config, test_gemini_cloudcode, test_retaindb_plugin): tests that mock the external API client, call our function, and assert exact kwargs. Break on refactor even when behavior is preserved. 7. Schedule-internal "function-was-called" tests (acp/test_server scheduling tests): tests that patch own helper method, then assert it was called. Kept behavioral tests throughout: error paths (pytest.raises), security tests (path traversal, SSRF, redaction), message alternation invariants, provider API format conversion, streaming logic, memory contract, real config load/merge tests. Net reduction: 169 tests removed. 38 empty classes cleaned up. Collected before: 12,522 tests Collected after: 12,353 tests
93 lines
3.6 KiB
Python
93 lines
3.6 KiB
Python
"""Tests for parent→subparser flag propagation.
|
|
|
|
When flags like --yolo, -w, -s exist on both the parent parser and the 'chat'
|
|
subparser, placing the flag BEFORE the subcommand (e.g. 'hermes --yolo chat')
|
|
must not silently drop the flag value.
|
|
|
|
Regression test for: argparse subparser default=False overwriting parent's
|
|
parsed True when the same argument is defined on both parsers.
|
|
|
|
Fix: chat subparser uses default=argparse.SUPPRESS for all duplicated flags,
|
|
so the subparser only sets the attribute when the user explicitly provides it.
|
|
"""
|
|
|
|
import argparse
|
|
import os
|
|
import sys
|
|
from unittest.mock import patch
|
|
|
|
import pytest
|
|
|
|
|
|
def _build_parser():
|
|
"""Build the hermes argument parser from the real code.
|
|
|
|
We import the real main() and extract the parser it builds.
|
|
Since main() is a large function that does much more than parse args,
|
|
we replicate just the parser structure here to avoid side effects.
|
|
"""
|
|
parser = argparse.ArgumentParser(prog="hermes")
|
|
parser.add_argument("--resume", "-r", metavar="SESSION", default=None)
|
|
parser.add_argument(
|
|
"--continue", "-c", dest="continue_last", nargs="?",
|
|
const=True, default=None, metavar="SESSION_NAME",
|
|
)
|
|
parser.add_argument("--worktree", "-w", action="store_true", default=False)
|
|
parser.add_argument("--skills", "-s", action="append", default=None)
|
|
parser.add_argument("--yolo", action="store_true", default=False)
|
|
parser.add_argument("--pass-session-id", action="store_true", default=False)
|
|
|
|
subparsers = parser.add_subparsers(dest="command")
|
|
chat = subparsers.add_parser("chat")
|
|
# These MUST use argparse.SUPPRESS to avoid overwriting parent values
|
|
chat.add_argument("--yolo", action="store_true",
|
|
default=argparse.SUPPRESS)
|
|
chat.add_argument("--worktree", "-w", action="store_true",
|
|
default=argparse.SUPPRESS)
|
|
chat.add_argument("--skills", "-s", action="append",
|
|
default=argparse.SUPPRESS)
|
|
chat.add_argument("--pass-session-id", action="store_true",
|
|
default=argparse.SUPPRESS)
|
|
chat.add_argument("--resume", "-r", metavar="SESSION_ID",
|
|
default=argparse.SUPPRESS)
|
|
chat.add_argument(
|
|
"--continue", "-c", dest="continue_last", nargs="?",
|
|
const=True, default=argparse.SUPPRESS, metavar="SESSION_NAME",
|
|
)
|
|
return parser
|
|
|
|
|
|
class TestYoloEnvVar:
|
|
"""Verify --yolo sets HERMES_YOLO_MODE regardless of flag position.
|
|
|
|
This tests the actual cmd_chat logic pattern (getattr → os.environ).
|
|
"""
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def _clean_env(self):
|
|
os.environ.pop("HERMES_YOLO_MODE", None)
|
|
yield
|
|
os.environ.pop("HERMES_YOLO_MODE", None)
|
|
|
|
def _simulate_cmd_chat_yolo_check(self, args):
|
|
"""Replicate the exact check from cmd_chat in main.py."""
|
|
if getattr(args, "yolo", False):
|
|
os.environ["HERMES_YOLO_MODE"] = "1"
|
|
|
|
def test_yolo_before_chat_sets_env(self):
|
|
parser = _build_parser()
|
|
args = parser.parse_args(["--yolo", "chat"])
|
|
self._simulate_cmd_chat_yolo_check(args)
|
|
assert os.environ.get("HERMES_YOLO_MODE") == "1"
|
|
|
|
def test_yolo_after_chat_sets_env(self):
|
|
parser = _build_parser()
|
|
args = parser.parse_args(["chat", "--yolo"])
|
|
self._simulate_cmd_chat_yolo_check(args)
|
|
assert os.environ.get("HERMES_YOLO_MODE") == "1"
|
|
|
|
def test_no_yolo_no_env(self):
|
|
parser = _build_parser()
|
|
args = parser.parse_args(["chat"])
|
|
self._simulate_cmd_chat_yolo_check(args)
|
|
assert os.environ.get("HERMES_YOLO_MODE") is None
|