mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-04-25 00:51:20 +00:00
cac6178104
Background process watchers (notify_on_complete, check_interval) created
synthetic SessionSource objects without user_id/user_name. While the
internal=True bypass (1d8d4f28) prevented false pairing for agent-
generated notifications, the missing identity caused:
- Garbage entries in pairing rate limiters (discord:None, telegram:None)
- 'User None' in approval messages and logs
- No user identity available for future code paths that need it
Additionally, platform messages arriving without from_user (Telegram
service messages, channel forwards, anonymous admin actions) could still
trigger false pairing because they are not internal events.
Fix:
1. Propagate user_id/user_name through the full watcher chain:
session_context.py → gateway/run.py → terminal_tool.py →
process_registry.py (including checkpoint persistence/recovery)
2. Add None user_id guard in _handle_message() — silently drop
non-internal messages with no user identity instead of triggering
the pairing flow.
Salvaged from PRs #7664 (kagura-agent, ContextVar approach),
#6540 (MestreY0d4-Uninter, tests), and #7709 (guang384, None guard).
Closes #6341, #6485, #7643
Relates to #6516, #7392
132 lines
5.1 KiB
Python
132 lines
5.1 KiB
Python
import os
|
|
|
|
from gateway.config import Platform
|
|
from gateway.run import GatewayRunner
|
|
from gateway.session import SessionContext, SessionSource
|
|
from gateway.session_context import (
|
|
get_session_env,
|
|
set_session_vars,
|
|
clear_session_vars,
|
|
)
|
|
|
|
|
|
def test_set_session_env_sets_contextvars(monkeypatch):
|
|
"""_set_session_env should populate contextvars, not os.environ."""
|
|
runner = object.__new__(GatewayRunner)
|
|
source = SessionSource(
|
|
platform=Platform.TELEGRAM,
|
|
chat_id="-1001",
|
|
chat_name="Group",
|
|
chat_type="group",
|
|
user_id="123456",
|
|
user_name="alice",
|
|
thread_id="17585",
|
|
)
|
|
context = SessionContext(source=source, connected_platforms=[], home_channels={})
|
|
|
|
monkeypatch.delenv("HERMES_SESSION_PLATFORM", raising=False)
|
|
monkeypatch.delenv("HERMES_SESSION_CHAT_ID", raising=False)
|
|
monkeypatch.delenv("HERMES_SESSION_CHAT_NAME", raising=False)
|
|
monkeypatch.delenv("HERMES_SESSION_USER_ID", raising=False)
|
|
monkeypatch.delenv("HERMES_SESSION_USER_NAME", raising=False)
|
|
monkeypatch.delenv("HERMES_SESSION_THREAD_ID", raising=False)
|
|
|
|
tokens = runner._set_session_env(context)
|
|
|
|
# Values should be readable via get_session_env (contextvar path)
|
|
assert get_session_env("HERMES_SESSION_PLATFORM") == "telegram"
|
|
assert get_session_env("HERMES_SESSION_CHAT_ID") == "-1001"
|
|
assert get_session_env("HERMES_SESSION_CHAT_NAME") == "Group"
|
|
assert get_session_env("HERMES_SESSION_USER_ID") == "123456"
|
|
assert get_session_env("HERMES_SESSION_USER_NAME") == "alice"
|
|
assert get_session_env("HERMES_SESSION_THREAD_ID") == "17585"
|
|
|
|
# os.environ should NOT be touched
|
|
assert os.getenv("HERMES_SESSION_PLATFORM") is None
|
|
assert os.getenv("HERMES_SESSION_THREAD_ID") is None
|
|
|
|
# Clean up
|
|
runner._clear_session_env(tokens)
|
|
|
|
|
|
def test_clear_session_env_restores_previous_state(monkeypatch):
|
|
"""_clear_session_env should restore contextvars to their pre-handler values."""
|
|
runner = object.__new__(GatewayRunner)
|
|
|
|
monkeypatch.delenv("HERMES_SESSION_PLATFORM", raising=False)
|
|
monkeypatch.delenv("HERMES_SESSION_CHAT_ID", raising=False)
|
|
monkeypatch.delenv("HERMES_SESSION_CHAT_NAME", raising=False)
|
|
monkeypatch.delenv("HERMES_SESSION_USER_ID", raising=False)
|
|
monkeypatch.delenv("HERMES_SESSION_USER_NAME", raising=False)
|
|
monkeypatch.delenv("HERMES_SESSION_THREAD_ID", raising=False)
|
|
|
|
source = SessionSource(
|
|
platform=Platform.TELEGRAM,
|
|
chat_id="-1001",
|
|
chat_name="Group",
|
|
chat_type="group",
|
|
user_id="123456",
|
|
user_name="alice",
|
|
thread_id="17585",
|
|
)
|
|
context = SessionContext(source=source, connected_platforms=[], home_channels={})
|
|
|
|
tokens = runner._set_session_env(context)
|
|
assert get_session_env("HERMES_SESSION_PLATFORM") == "telegram"
|
|
assert get_session_env("HERMES_SESSION_USER_ID") == "123456"
|
|
|
|
runner._clear_session_env(tokens)
|
|
|
|
# After clear, contextvars should return to defaults (empty)
|
|
assert get_session_env("HERMES_SESSION_PLATFORM") == ""
|
|
assert get_session_env("HERMES_SESSION_CHAT_ID") == ""
|
|
assert get_session_env("HERMES_SESSION_CHAT_NAME") == ""
|
|
assert get_session_env("HERMES_SESSION_USER_ID") == ""
|
|
assert get_session_env("HERMES_SESSION_USER_NAME") == ""
|
|
assert get_session_env("HERMES_SESSION_THREAD_ID") == ""
|
|
|
|
|
|
def test_get_session_env_falls_back_to_os_environ(monkeypatch):
|
|
"""get_session_env should fall back to os.environ when contextvar is unset."""
|
|
monkeypatch.setenv("HERMES_SESSION_PLATFORM", "discord")
|
|
|
|
# No contextvar set — should read from os.environ
|
|
assert get_session_env("HERMES_SESSION_PLATFORM") == "discord"
|
|
|
|
# Now set a contextvar — should prefer it
|
|
tokens = set_session_vars(platform="telegram")
|
|
assert get_session_env("HERMES_SESSION_PLATFORM") == "telegram"
|
|
|
|
# Restore — should fall back to os.environ again
|
|
clear_session_vars(tokens)
|
|
assert get_session_env("HERMES_SESSION_PLATFORM") == "discord"
|
|
|
|
|
|
def test_get_session_env_default_when_nothing_set(monkeypatch):
|
|
"""get_session_env returns default when neither contextvar nor env is set."""
|
|
monkeypatch.delenv("HERMES_SESSION_PLATFORM", raising=False)
|
|
|
|
assert get_session_env("HERMES_SESSION_PLATFORM") == ""
|
|
assert get_session_env("HERMES_SESSION_PLATFORM", "fallback") == "fallback"
|
|
|
|
|
|
def test_set_session_env_handles_missing_optional_fields():
|
|
"""_set_session_env should handle None chat_name and thread_id gracefully."""
|
|
runner = object.__new__(GatewayRunner)
|
|
source = SessionSource(
|
|
platform=Platform.TELEGRAM,
|
|
chat_id="-1001",
|
|
chat_name=None,
|
|
chat_type="private",
|
|
thread_id=None,
|
|
)
|
|
context = SessionContext(source=source, connected_platforms=[], home_channels={})
|
|
|
|
tokens = runner._set_session_env(context)
|
|
|
|
assert get_session_env("HERMES_SESSION_PLATFORM") == "telegram"
|
|
assert get_session_env("HERMES_SESSION_CHAT_ID") == "-1001"
|
|
assert get_session_env("HERMES_SESSION_CHAT_NAME") == ""
|
|
assert get_session_env("HERMES_SESSION_THREAD_ID") == ""
|
|
|
|
runner._clear_session_env(tokens)
|