hermes-agent/tests/test_toolset_distributions.py
Teknium 6b81590c55
test: prune low-value tests suite-wide (wave 1) — 46,820 → 28,106 test functions
Systematic prune per AGENTS.md test policy, one pass over every major
test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli,
cron, tui_gateway, honcho/openviking, root-level):

- DELETE: source-reading tests (read_text/getsource on prod files),
  change-detector tests (exact catalog counts, model-name snapshots,
  config version literals), mock-echo tests (assert a mock returns what
  it was told), assertion-free/trivial tests, near-duplicate
  parametrizations (boundaries + one representative kept), async/sync
  twin duplicates, cosmetic within-file variations.
- KEEP (mandatory): security/redaction/approval guards, message-role
  alternation invariants, prompt-caching/deterministic-call-id
  invariants, issue-number regression tests (deduped), E2E tests.
- 6 test files deleted outright (script-style/no-assert or fully
  redundant); conftest.py, fakes/, fixtures/ untouched.
- tests/acp/conftest.py added: autouse fixture stubs the live
  models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server
  tests performed on every session create — test_server.py 147s → 3.4s,
  and the tests are now genuinely hermetic.
- Sleep-based slowness shrunk where safe (codex_ttfb_watchdog,
  compression_concurrent_fork, etc.); no wall-clock assertion tightened.

Verification: full hermetic suite via scripts/run_tests.sh —
2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall
(baseline: 583s wall, 13,564s subprocess CPU).
2026-07-29 13:10:23 -07:00

66 lines
1.8 KiB
Python

"""Tests for toolset_distributions.py — distribution CRUD, sampling, validation."""
import pytest
from toolset_distributions import (
DISTRIBUTIONS,
get_distribution,
list_distributions,
sample_toolsets_from_distribution,
validate_distribution,
)
class TestGetDistribution:
def test_known_distribution(self):
dist = get_distribution("default")
assert dist is not None
assert "description" in dist
assert "toolsets" in dist
class TestListDistributions:
def test_returns_copy(self):
d1 = list_distributions()
d2 = list_distributions()
assert d1 is not d2
assert d1 == d2
class TestValidateDistribution:
def test_valid(self):
assert validate_distribution("default") is True
assert validate_distribution("research") is True
class TestSampleToolsetsFromDistribution:
def test_minimal_returns_web_only(self):
result = sample_toolsets_from_distribution("minimal")
assert "web" in result
def test_returns_list_of_strings(self):
result = sample_toolsets_from_distribution("balanced")
assert isinstance(result, list)
for item in result:
assert isinstance(item, str)
class TestDistributionStructure:
def test_all_have_required_keys(self):
for name, dist in DISTRIBUTIONS.items():
assert "description" in dist, f"{name} missing description"
assert "toolsets" in dist, f"{name} missing toolsets"
assert isinstance(dist["toolsets"], dict), f"{name} toolsets not a dict"
def test_probabilities_are_valid_range(self):
for name, dist in DISTRIBUTIONS.items():
for ts_name, prob in dist["toolsets"].items():
assert 0 < prob <= 100, f"{name}.{ts_name} has invalid probability {prob}"