mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-02 12:13:05 +00:00
Bring apps/desktop and ui-tui to a clean state for typecheck, eslint,
and prettier:
- Run prettier across both trees (printWidth/wrap drift; prettier is not
CI-enforced for these JS projects, so main had accumulated drift).
- Apply eslint --fix for padding-line-between-statements and perfectionist
import/export sorting.
- Manual fixes for non-auto-fixable rules:
- remove unused node:net import in electron/main.cjs (uses Electron net)
- replace inline `typeof import(...)` annotations with top-level
`import type * as EnvModule` in two ui-tui test files
- scoped eslint-disable no-control-regex on intentional sentinel/ANSI
regexes (mathUnicode.ts, text.ts)
- resolve react-hooks/exhaustive-deps per-case: correct swapped/missing
deps, collapse redundant session.* members, and justified disables on
settings mount-only data-load effects to preserve run-once behavior
No behavior changes; test pass/fail counts are unchanged from the main
baseline.
210 lines
8.6 KiB
TypeScript
210 lines
8.6 KiB
TypeScript
import { describe, expect, it } from 'vitest'
|
|
|
|
import {
|
|
activeSessionCountLabel,
|
|
canTypeOrchestratorPrompt,
|
|
clampOrchestratorSelection,
|
|
closeFallbackAfterClose,
|
|
currentSessionSelectionIndex,
|
|
draftModelArgFromPickerValue,
|
|
draftModelDisplayLabel,
|
|
draftTitleFromPrompt,
|
|
fixedSessionColumnStyle,
|
|
isNewSessionRow,
|
|
newSessionMarkerColor,
|
|
newSessionRowIndex,
|
|
orchestratorContextHint,
|
|
orchestratorContextHintSegments,
|
|
orchestratorGlobalHotkeyHint,
|
|
orchestratorGlobalHotkeyHintSegments,
|
|
orchestratorHintSegmentColor,
|
|
orchestratorRowClickAction,
|
|
orchestratorVisibleRowIndexes,
|
|
relativeSessionAge,
|
|
resumableHistory,
|
|
selectedSessionRowStyle,
|
|
sessionRowKindAt,
|
|
sessionsCountLabel
|
|
} from '../components/activeSessionSwitcher.js'
|
|
import type { SessionActiveItem } from '../gatewayTypes.js'
|
|
import type { SessionListItem } from '../gatewayTypes.js'
|
|
import { DEFAULT_THEME } from '../theme.js'
|
|
|
|
describe('session orchestrator helpers', () => {
|
|
it('labels live sessions compactly for tight overlays', () => {
|
|
expect(activeSessionCountLabel(0)).toBe('0 live sessions')
|
|
expect(activeSessionCountLabel(1)).toBe('1 live session')
|
|
expect(activeSessionCountLabel(3)).toBe('3 live sessions')
|
|
expect(activeSessionCountLabel(1)).not.toContain('in this TUI')
|
|
})
|
|
|
|
it('keeps session orchestrator hotkey hints short and contextual', () => {
|
|
expect(orchestratorContextHint(false)).toBe('Session row: Enter switch · Ctrl+D close')
|
|
expect(orchestratorContextHint(true)).toBe('New row: type prompt · Enter start · Tab model')
|
|
expect(orchestratorGlobalHotkeyHint).toBe('↑↓ move · Ctrl+N new · Ctrl+R refresh · Esc close')
|
|
expect(orchestratorGlobalHotkeyHint.length).toBeLessThanOrEqual(56)
|
|
})
|
|
|
|
it('assigns themed colors consistently to orchestrator labels and hotkeys', () => {
|
|
expect(orchestratorContextHintSegments(false)).toEqual([
|
|
{ role: 'label', text: 'Session row:' },
|
|
{ role: 'text', text: ' ' },
|
|
{ role: 'hotkey', text: 'Enter' },
|
|
{ role: 'text', text: ' switch · ' },
|
|
{ role: 'hotkey', text: 'Ctrl+D' },
|
|
{ role: 'text', text: ' close' }
|
|
])
|
|
expect(orchestratorContextHintSegments(true)).toEqual([
|
|
{ role: 'label', text: 'New row:' },
|
|
{ role: 'text', text: ' type prompt · ' },
|
|
{ role: 'hotkey', text: 'Enter' },
|
|
{ role: 'text', text: ' start · ' },
|
|
{ role: 'hotkey', text: 'Tab' },
|
|
{ role: 'text', text: ' model' }
|
|
])
|
|
expect(orchestratorGlobalHotkeyHintSegments.filter(s => s.role === 'hotkey').map(s => s.text)).toEqual([
|
|
'↑↓',
|
|
'Ctrl+N',
|
|
'Ctrl+R',
|
|
'Esc'
|
|
])
|
|
expect(orchestratorHintSegmentColor(DEFAULT_THEME, 'hotkey')).toBe(DEFAULT_THEME.color.accent)
|
|
expect(orchestratorHintSegmentColor(DEFAULT_THEME, 'label')).toBe(DEFAULT_THEME.color.label)
|
|
expect(orchestratorHintSegmentColor(DEFAULT_THEME, 'text')).toBe(DEFAULT_THEME.color.muted)
|
|
expect(newSessionMarkerColor(DEFAULT_THEME, false)).toBe(DEFAULT_THEME.color.label)
|
|
expect(newSessionMarkerColor(DEFAULT_THEME, true)).toBe(DEFAULT_THEME.color.text)
|
|
})
|
|
|
|
it('uses a readable selected row style instead of accent-on-accent inverse text', () => {
|
|
const style = selectedSessionRowStyle(DEFAULT_THEME)
|
|
|
|
expect(style.backgroundColor).toBe(DEFAULT_THEME.color.selectionBg)
|
|
expect(style.color).toBe(DEFAULT_THEME.color.text)
|
|
expect(style.backgroundColor).not.toBe(DEFAULT_THEME.color.accent)
|
|
expect(style.color).not.toBe(DEFAULT_THEME.color.accent)
|
|
})
|
|
|
|
it('turns model picker values into session-scoped draft model args', () => {
|
|
expect(draftModelArgFromPickerValue('kimi-k2.6 --provider ollama-cloud --tui-session')).toBe(
|
|
'kimi-k2.6 --provider ollama-cloud'
|
|
)
|
|
expect(draftModelArgFromPickerValue('openai/gpt-5.5 --provider openai-codex --global')).toBe(
|
|
'openai/gpt-5.5 --provider openai-codex'
|
|
)
|
|
})
|
|
|
|
it('highlights the current live session when the picker opens', () => {
|
|
const sessions = [
|
|
{ id: 'first', status: 'idle' },
|
|
{ id: 'second', status: 'working', current: true },
|
|
{ id: 'third', status: 'idle' }
|
|
] satisfies SessionActiveItem[]
|
|
|
|
expect(currentSessionSelectionIndex(sessions, 'second')).toBe(1)
|
|
expect(
|
|
currentSessionSelectionIndex(
|
|
[
|
|
{ id: 'first', status: 'idle' },
|
|
{ id: 'third', status: 'idle' }
|
|
],
|
|
'third'
|
|
)
|
|
).toBe(1)
|
|
expect(currentSessionSelectionIndex(sessions, 'missing')).toBe(1)
|
|
expect(currentSessionSelectionIndex([], 'missing')).toBe(0)
|
|
})
|
|
|
|
it('adds a selectable New row after the live sessions and gates prompt typing to it', () => {
|
|
expect(newSessionRowIndex(0)).toBe(0)
|
|
expect(newSessionRowIndex(3)).toBe(3)
|
|
expect(clampOrchestratorSelection(-5, 2)).toBe(0)
|
|
expect(clampOrchestratorSelection(99, 2)).toBe(2)
|
|
expect(isNewSessionRow(0, 0)).toBe(true)
|
|
expect(isNewSessionRow(1, 2)).toBe(false)
|
|
expect(isNewSessionRow(2, 2)).toBe(true)
|
|
expect(canTypeOrchestratorPrompt(1, 2)).toBe(false)
|
|
expect(canTypeOrchestratorPrompt(2, 2)).toBe(true)
|
|
expect(orchestratorVisibleRowIndexes(3, 3, 12)).toEqual([0, 1, 2, 3])
|
|
expect(orchestratorVisibleRowIndexes(13, 13, 12)).toContain(13)
|
|
})
|
|
|
|
it('selects a safe fallback after closing the current live session', () => {
|
|
const remaining = [
|
|
{ id: 'next', status: 'idle' },
|
|
{ id: 'other', status: 'working' }
|
|
] satisfies SessionActiveItem[]
|
|
|
|
expect(closeFallbackAfterClose('other', 'current', remaining)).toEqual({ action: 'stay' })
|
|
expect(closeFallbackAfterClose('current', 'current', remaining)).toEqual({ action: 'activate', sessionId: 'next' })
|
|
expect(closeFallbackAfterClose('current', 'current', [])).toEqual({ action: 'new' })
|
|
})
|
|
|
|
it('shows clean draft model labels without picker flags or provider params', () => {
|
|
expect(draftModelDisplayLabel('kimi-k2.6 --provider ollama-cloud --tui-session')).toBe('kimi-k2.6')
|
|
expect(draftModelDisplayLabel('openai/gpt-5.5 --provider openai-codex --global')).toBe('gpt-5.5')
|
|
expect(draftModelDisplayLabel('')).toBe('current/default')
|
|
})
|
|
|
|
it('maps row clicks to existing-session activation or New-row focus', () => {
|
|
const sessions = [
|
|
{ id: 'a', status: 'idle' },
|
|
{ id: 'b', status: 'idle' }
|
|
] satisfies SessionActiveItem[]
|
|
|
|
expect(orchestratorRowClickAction(1, sessions)).toEqual({ action: 'activate', sessionId: 'b' })
|
|
expect(orchestratorRowClickAction(2, sessions)).toEqual({ action: 'select-new' })
|
|
expect(orchestratorRowClickAction(99, sessions)).toEqual({ action: 'select-new' })
|
|
})
|
|
|
|
it('keeps fixed table columns from shrinking into adjacent columns', () => {
|
|
expect(fixedSessionColumnStyle().flexShrink).toBe(0)
|
|
})
|
|
|
|
it('builds a compact title from the orchestrator prompt', () => {
|
|
expect(draftTitleFromPrompt(' Build the websocket orchestrator panel and make it robust. ', 24)).toBe(
|
|
'Build the websocket orc…'
|
|
)
|
|
})
|
|
})
|
|
|
|
describe('unified Sessions overlay helpers', () => {
|
|
it('orders rows as [new][live…][history…]', () => {
|
|
// 2 live sessions, any number of history rows after them.
|
|
expect(sessionRowKindAt(0, 2)).toBe('new')
|
|
expect(sessionRowKindAt(1, 2)).toBe('live')
|
|
expect(sessionRowKindAt(2, 2)).toBe('live')
|
|
expect(sessionRowKindAt(3, 2)).toBe('history')
|
|
expect(sessionRowKindAt(9, 2)).toBe('history')
|
|
// No live sessions: row 0 is new, everything after is history.
|
|
expect(sessionRowKindAt(0, 0)).toBe('new')
|
|
expect(sessionRowKindAt(1, 0)).toBe('history')
|
|
})
|
|
|
|
it('drops already-live sessions from the resumable history (dedupe by id)', () => {
|
|
const history = [
|
|
{ id: 'a', message_count: 1, preview: '', started_at: 0, title: 'A' },
|
|
{ id: 'b', message_count: 2, preview: '', started_at: 0, title: 'B' },
|
|
{ id: 'c', message_count: 3, preview: '', started_at: 0, title: 'C' }
|
|
] satisfies SessionListItem[]
|
|
|
|
const live = [{ id: 'b', status: 'idle' }] satisfies SessionActiveItem[]
|
|
|
|
expect(resumableHistory(history, live).map(h => h.id)).toEqual(['a', 'c'])
|
|
expect(resumableHistory(history, []).map(h => h.id)).toEqual(['a', 'b', 'c'])
|
|
})
|
|
|
|
it('labels live + resumable counts compactly', () => {
|
|
expect(sessionsCountLabel(0, 0)).toBe('0 live · 0 resumable')
|
|
expect(sessionsCountLabel(2, 7)).toBe('2 live · 7 resumable')
|
|
})
|
|
|
|
it('renders relative session age, blank when unknown', () => {
|
|
const nowSec = Math.floor(Date.now() / 1000)
|
|
|
|
expect(relativeSessionAge(nowSec)).toBe('today')
|
|
expect(relativeSessionAge(nowSec - 36 * 3600)).toBe('yesterday')
|
|
expect(relativeSessionAge(nowSec - 3 * 86400)).toBe('3d ago')
|
|
expect(relativeSessionAge(undefined)).toBe('')
|
|
expect(relativeSessionAge(0)).toBe('')
|
|
})
|
|
})
|