mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-04-25 00:51:20 +00:00
c74030a11d
PR #8399 replaced preexec_fn=os.setsid with start_new_session=<bool> in tools/environments/local.py to use CPython's thread-safe POSIX fastpath instead of a between-fork-and-exec callback. Apply the same swap to the other three files covered by tests/tools/test_windows_compat.py so all Popen call sites use a consistent idiom. Also: - Strip a trailing-whitespace line introduced by the original PR. - Update CONTRIBUTING.md + website/docs/developer-guide/contributing.md to recommend start_new_session in the cross-platform process management section. - Fix a stale docstring reference in tools/environments/base.py (_popen_bash). - Extend test_windows_compat.py with a parallel regression guard that rejects bare start_new_session=True (must be gated on _IS_WINDOWS). Scope note: this is code hygiene, not a fix for #8340 — the two forms invoke the same setsid() syscall, so this swap alone does not change behavior for the 'setsid ... & disown' hang scenario in that issue. #8340 remains open. |
||
|---|---|---|
| .. | ||
| _category_.json | ||
| acp-internals.md | ||
| adding-platform-adapters.md | ||
| adding-providers.md | ||
| adding-tools.md | ||
| agent-loop.md | ||
| architecture.md | ||
| context-compression-and-caching.md | ||
| context-engine-plugin.md | ||
| contributing.md | ||
| creating-skills.md | ||
| cron-internals.md | ||
| environments.md | ||
| extending-the-cli.md | ||
| gateway-internals.md | ||
| memory-provider-plugin.md | ||
| prompt-assembly.md | ||
| provider-runtime.md | ||
| session-storage.md | ||
| tools-runtime.md | ||
| trajectory-format.md | ||