mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-05-05 02:31:47 +00:00
c1647dadba
1. Telegram xdist mock pollution (37 tests): Add tests/gateway/conftest.py
with a shared _ensure_telegram_mock() that runs at collection time.
Under pytest-xdist, test_telegram_caption_merge.py (bare top-level
import, no mock) would trigger the ImportError fallback in
gateway/platforms/telegram.py, caching ChatType=None and Update=Any
for the entire worker — cascading into 37 downstream failures.
2. VIRTUAL_ENV env var leak (4 tests): TestDetectVenvDir tests monkeypatched
sys.prefix but didn't clear VIRTUAL_ENV. After commit 50c35dca added a
VIRTUAL_ENV check to _detect_venv_dir(), CI's real venv leaked through.
3. Copilot base_url missing (1 test): _resolve_runtime_from_pool_entry()
set api_mode for copilot but didn't add the base_url fallback — unlike
openrouter, anthropic, and codex which all have one. Production bug.
4. Stale vision model assertion (1 test): _PROVIDER_VISION_MODELS added
zai -> glm-5v-turbo but the test still expected the main model glm-5.1.
5. Reasoning item id intentionally stripped (1 test): Production code at
run_agent.py:3738 deliberately excludes 'id' from reasoning items
(store=False causes API 404). Test was asserting the old behavior.
6. context_length warning not reaching custom_providers (1 test): The test
didn't pass base_url to AIAgent, so self.base_url was empty and the
custom_providers URL comparison at line 1302 never matched.
7. Matrix room ID URL-encoding (1 test): Production code now URL-encodes
room IDs (!room:example.com -> %21room%3Aexample.com) but the test
assertion wasn't updated.
8. Google Workspace calendar tests (2 tests): Tests assert on +agenda CLI
args that don't exist in the production calendar_list() function. They
only 'passed' before because _gws_binary() returned None, the Python
SDK fallback ran, googleapiclient import failed, SystemExit was raised,
and post-exit assertions were never reached. Skip when gws not installed.
Remaining 4 failures (test_run_progress_topics.py) are pre-existing flaky
tests that fail inconsistently under xdist — confirmed on clean main.
66 lines
2.6 KiB
Python
66 lines
2.6 KiB
Python
"""Shared fixtures for gateway tests.
|
|
|
|
The ``_ensure_telegram_mock`` helper guarantees that a minimal mock of
|
|
the ``telegram`` package is registered in :data:`sys.modules` **before**
|
|
any test file triggers ``from gateway.platforms.telegram import ...``.
|
|
|
|
Without this, ``pytest-xdist`` workers that happen to collect
|
|
``test_telegram_caption_merge.py`` (bare top-level import, no per-file
|
|
mock) first will cache ``ChatType = None`` from the production
|
|
ImportError fallback, causing 30+ downstream test failures wherever
|
|
``ChatType.GROUP`` / ``ChatType.SUPERGROUP`` is accessed.
|
|
|
|
Individual test files may still call their own ``_ensure_telegram_mock``
|
|
— it short-circuits when the mock is already present.
|
|
"""
|
|
|
|
import sys
|
|
from unittest.mock import MagicMock
|
|
|
|
|
|
def _ensure_telegram_mock() -> None:
|
|
"""Install a comprehensive telegram mock in sys.modules.
|
|
|
|
Idempotent — skips when the real library is already imported.
|
|
Uses ``sys.modules[name] = mod`` (overwrite) instead of
|
|
``setdefault`` so it wins even if a partial/broken import
|
|
already cached a module with ``ChatType = None``.
|
|
"""
|
|
if "telegram" in sys.modules and hasattr(sys.modules["telegram"], "__file__"):
|
|
return # Real library is installed — nothing to mock
|
|
|
|
mod = MagicMock()
|
|
mod.ext.ContextTypes.DEFAULT_TYPE = type(None)
|
|
mod.constants.ParseMode.MARKDOWN = "Markdown"
|
|
mod.constants.ParseMode.MARKDOWN_V2 = "MarkdownV2"
|
|
mod.constants.ParseMode.HTML = "HTML"
|
|
mod.constants.ChatType.PRIVATE = "private"
|
|
mod.constants.ChatType.GROUP = "group"
|
|
mod.constants.ChatType.SUPERGROUP = "supergroup"
|
|
mod.constants.ChatType.CHANNEL = "channel"
|
|
|
|
# Real exception classes so ``except (NetworkError, ...)`` clauses
|
|
# in production code don't blow up with TypeError.
|
|
mod.error.NetworkError = type("NetworkError", (OSError,), {})
|
|
mod.error.TimedOut = type("TimedOut", (OSError,), {})
|
|
mod.error.BadRequest = type("BadRequest", (Exception,), {})
|
|
mod.error.Forbidden = type("Forbidden", (Exception,), {})
|
|
mod.error.InvalidToken = type("InvalidToken", (Exception,), {})
|
|
mod.error.RetryAfter = type("RetryAfter", (Exception,), {"retry_after": 1})
|
|
mod.error.Conflict = type("Conflict", (Exception,), {})
|
|
|
|
# Update.ALL_TYPES used in start_polling()
|
|
mod.Update.ALL_TYPES = []
|
|
|
|
for name in (
|
|
"telegram",
|
|
"telegram.ext",
|
|
"telegram.constants",
|
|
"telegram.request",
|
|
):
|
|
sys.modules[name] = mod
|
|
sys.modules["telegram.error"] = mod.error
|
|
|
|
|
|
# Run at collection time — before any test file's module-level imports.
|
|
_ensure_telegram_mock()
|