mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-28 18:19:28 +00:00
DEFAULT_CONFIG declared "kanban" twice. Python keeps only the last literal for a duplicate key, so the first kanban block was silently dropped and its "auto_subscribe_on_create": True default never made it into DEFAULT_CONFIG. The consumer in tools/kanban_tools.py masks the miss with cfg_get(..., default=True), but the documented default was absent from DEFAULT_CONFIG (so config templates / 'hermes config show' omit it), and the duplicate key is a standing hazard: any future key added to the first block would also vanish. Merge auto_subscribe_on_create into the single canonical kanban block. Adds a regression test asserting both default sets survive and a guard against any duplicate top-level DEFAULT_CONFIG key. |
||
|---|---|---|
| .. | ||
| emails | ||
| README.md | ||
Contributor email → GitHub login mappings
This directory replaces appending entries to AUTHOR_MAP in
scripts/release.py. The old dict caused constant merge conflicts when
several salvage PRs landed at once — every PR edited the same lines of the
same file. Here, each mapping is its own file, and file additions never
conflict.
Adding a mapping
One file per commit-author email, under emails/:
python3 scripts/add_contributor.py <email> <github-login>
# or by hand:
echo "<github-login>" > contributors/emails/<email>
- File name = the exact commit-author email (as shown by
git log --format='%ae'). - File content = the GitHub login on the first non-comment line.
Lines starting with
#are comments (use them for the PR reference).
Example — contributors/emails/jane.doe@example.com:
janedoe
# PR #12345 salvage (gateway: fix session key routing)
Rules
- Do NOT add new entries to
AUTHOR_MAPinscripts/release.py. That dict is frozen legacy data; the release tooling merges it with this directory (directory entries win on duplicates). - GitHub noreply emails (
<id>+<login>@users.noreply.github.comand<login>@users.noreply.github.com) auto-resolve — no file needed. - The
Contributor Attribution CheckCI job fails a PR whose commits carry an unmapped email; the failure message prints the exact command to run.