mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
88 lines
3.3 KiB
Python
88 lines
3.3 KiB
Python
"""Tests for ``hermes update`` / ``--check`` inside the Docker container.
|
|
|
|
Background: ``.dockerignore`` excludes ``.git``, so the existing git-pull
|
|
update path can never succeed inside the published image. Before this
|
|
fix, ``hermes update`` would fall through to ``"✗ Not a git repository.
|
|
Please reinstall: curl ... install.sh"`` — that script installs a *new*
|
|
host-side Hermes, not an update to the running container, so the message
|
|
was actively misleading.
|
|
|
|
These tests pin the new behaviour: when ``detect_install_method`` reports
|
|
``"docker"`` (stamped by ``docker/stage2-hook.sh``), both the apply path
|
|
(``cmd_update``) and the check path (``_cmd_update_check``) print the
|
|
``docker pull`` guidance from ``format_docker_update_message`` and exit
|
|
with status 1, without running ``git fetch`` / ``subprocess.run``.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
from types import SimpleNamespace
|
|
from unittest.mock import patch
|
|
|
|
import pytest
|
|
|
|
from hermes_cli.main import _cmd_update_check, cmd_update
|
|
|
|
|
|
# ---------- cmd_update (apply path) ----------
|
|
|
|
|
|
@patch("hermes_cli.config.is_managed", return_value=False)
|
|
@patch("hermes_cli.config.detect_install_method", return_value="docker")
|
|
@patch("subprocess.run")
|
|
def test_cmd_update_in_docker_prints_guidance_and_exits(
|
|
mock_run, _mock_method, _mock_managed, capsys
|
|
):
|
|
"""``hermes update`` inside Docker → friendly message + exit 1, no git calls."""
|
|
with pytest.raises(SystemExit) as excinfo:
|
|
cmd_update(SimpleNamespace(check=False))
|
|
|
|
assert excinfo.value.code == 1
|
|
out = capsys.readouterr().out
|
|
# Spot-check the key guidance — exhaustive wording is locked in by the
|
|
# config-module test below to keep these CLI tests resilient to copy edits.
|
|
assert "doesn't apply inside the Docker container" in out
|
|
assert "docker pull nousresearch/hermes-agent:latest" in out
|
|
|
|
# No git invocations — the early-return must beat every git command.
|
|
git_calls = [c for c in mock_run.call_args_list if c.args and c.args[0] and "git" in str(c.args[0][0])]
|
|
assert git_calls == [], f"expected no git calls, got: {git_calls}"
|
|
|
|
|
|
|
|
|
|
# ---------- _cmd_update_check (check path, direct entry) ----------
|
|
|
|
|
|
# ---------- Non-Docker installs unaffected ----------
|
|
|
|
|
|
|
|
|
|
# ---------- format_docker_update_message — content lock ----------
|
|
|
|
|
|
def test_format_docker_update_message_contents():
|
|
"""Lock in the high-value content of the Docker update message.
|
|
|
|
These are the bits a user actually needs to act on; if any of them
|
|
disappear in a copy edit, the message has lost its value. Specific
|
|
wording around them is free to evolve (we don't assert full text).
|
|
"""
|
|
from hermes_cli.config import format_docker_update_message
|
|
|
|
msg = format_docker_update_message()
|
|
|
|
# Primary command — the entire reason this message exists.
|
|
assert "docker pull nousresearch/hermes-agent:latest" in msg
|
|
|
|
# The four key concepts the message must cover:
|
|
assert "restart" in msg.lower(), "must explain that a restart is required"
|
|
assert "--version" in msg, "must show how to verify the new version"
|
|
assert ":latest" in msg, "must mention tag pinning caveat"
|
|
assert "HERMES_HOME" in msg or "/opt/data" in msg, (
|
|
"must address config persistence across upgrades"
|
|
)
|
|
|
|
# Acknowledges that forks exist (build-your-own-image escape hatch).
|
|
assert "fork" in msg.lower() or "Dockerfile" in msg
|