mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-25 17:18:11 +00:00
44f6f8435b
Follow-up hardening for the C13 log-noise cluster: - plugins/platforms/slack/adapter.py: clarify button resolution logged the full chosen option text at INFO (choice=%r). Choice text is user content — log the choice INDEX at INFO and the (truncated, %.100r) text at DEBUG only. Widens #58478's principle: no message content above DEBUG level anywhere in the adapter. - tests/gateway/test_slack_log_noise.py (new): behavioral suite pinning the cluster's invariants: * catch-all ack registered AFTER every named handler (registration order is bolt's dispatch priority — no shadowing); * catch-all fires for an unsubscribed event type (reaction_added), logs only a DEBUG line naming the type, and never logs content; * named handlers still dispatch (message → _handle_slack_message); * end-to-end inbound message run leaves NO message text or block content in any adapter log record (caplog at DEBUG); * #30185's event-arrival diagnostic is metadata-only; * clarify resolution: INFO carries index/user only, text is DEBUG-only (fails with the adapter fix reverted — A/B verified). Content-leak audit of all 139 logger call sites in the adapter found two above-DEBUG leaks: the clarify choice line (fixed here) and none else carrying message text; remaining sites log error strings, URLs via safe_url_for_log, ids, and counts. The block-extraction DEBUG preview was already removed by #58478 (chars= length only). |
||
|---|---|---|
| .. | ||
| __init__.py | ||
| adapter.py | ||
| block_kit.py | ||
| plugin.yaml | ||