mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-06-26 11:12:03 +00:00
1f4c5aed6d
The gateway dispatcher captured kanban.auto_decompose ONCE at boot, so a user who flipped it to false to STOP auto-decompose had no way to make that take effect short of restarting the gateway. Reported (#49638): auto-decompose created and launched tasks the user never intended (while they were still typing the task description), and 'even Hermes Agent couldn't disable this feature' — because the live config edit was silently ignored. Auto-decompose is a safety toggle; turning it off must halt fan-out on the next tick. The dispatcher now re-reads the flag (and auto_decompose_per_tick) from config every tick via the extracted _resolve_auto_decompose_settings(), which fails SAFE (disabled) on a config read error so a transient failure can never re-enable a feature the user turned off. Closes #49638.
83 lines
2.9 KiB
Python
83 lines
2.9 KiB
Python
"""Tests for live auto-decompose settings resolution (issue #49638).
|
|
|
|
The gateway dispatcher used to capture ``kanban.auto_decompose`` once at boot,
|
|
so a user who flipped it to ``false`` to STOP runaway auto-decompose (which had
|
|
created and launched tasks they didn't intend) found the flag had no effect
|
|
without a full gateway restart. ``_resolve_auto_decompose_settings`` is now
|
|
called every tick, reading the current config.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import pytest
|
|
|
|
from gateway.kanban_watchers import _resolve_auto_decompose_settings
|
|
|
|
|
|
def test_enabled_by_default_when_key_absent():
|
|
enabled, per_tick = _resolve_auto_decompose_settings(lambda: {"kanban": {}})
|
|
assert enabled is True
|
|
assert per_tick == 3
|
|
|
|
|
|
def test_disabled_when_flag_false():
|
|
enabled, per_tick = _resolve_auto_decompose_settings(
|
|
lambda: {"kanban": {"auto_decompose": False}}
|
|
)
|
|
assert enabled is False
|
|
|
|
|
|
def test_per_tick_respected_and_clamped():
|
|
enabled, per_tick = _resolve_auto_decompose_settings(
|
|
lambda: {"kanban": {"auto_decompose": True, "auto_decompose_per_tick": 7}}
|
|
)
|
|
assert (enabled, per_tick) == (True, 7)
|
|
|
|
# 0 is treated as "unset" by the `or 3` fallback → default 3 (a 0 per-tick
|
|
# cap would disable progress, so falling back to the default is the safe read).
|
|
_, per_tick_zero = _resolve_auto_decompose_settings(
|
|
lambda: {"kanban": {"auto_decompose_per_tick": 0}}
|
|
)
|
|
assert per_tick_zero == 3
|
|
|
|
# A genuine negative value clamps up to 1.
|
|
_, per_tick_neg = _resolve_auto_decompose_settings(
|
|
lambda: {"kanban": {"auto_decompose_per_tick": -5}}
|
|
)
|
|
assert per_tick_neg == 1
|
|
|
|
|
|
def test_malformed_per_tick_falls_back_to_default():
|
|
_, per_tick = _resolve_auto_decompose_settings(
|
|
lambda: {"kanban": {"auto_decompose_per_tick": "lots"}}
|
|
)
|
|
assert per_tick == 3
|
|
|
|
|
|
def test_config_read_error_fails_safe_disabled():
|
|
"""A transient config read failure must DISABLE auto-decompose, never
|
|
silently fall back to the default-on behaviour the user turned off."""
|
|
|
|
def _boom():
|
|
raise RuntimeError("config read failed")
|
|
|
|
enabled, per_tick = _resolve_auto_decompose_settings(_boom)
|
|
assert enabled is False
|
|
assert per_tick == 3
|
|
|
|
|
|
def test_non_dict_config_fails_safe():
|
|
enabled, _ = _resolve_auto_decompose_settings(lambda: None)
|
|
assert enabled is True # no kanban key → default-on (not an error path)
|
|
enabled2, _ = _resolve_auto_decompose_settings(lambda: ["not", "a", "dict"])
|
|
assert enabled2 is True
|
|
|
|
|
|
def test_live_toggle_takes_effect_between_calls():
|
|
"""Simulate a user flipping the flag while the dispatcher runs: a later
|
|
resolution reflects the new value without any restart."""
|
|
state = {"kanban": {"auto_decompose": True}}
|
|
assert _resolve_auto_decompose_settings(lambda: state)[0] is True
|
|
# User edits config.yaml mid-run.
|
|
state["kanban"]["auto_decompose"] = False
|
|
assert _resolve_auto_decompose_settings(lambda: state)[0] is False
|