mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-06-24 10:52:21 +00:00
The port-announcement clock in waitForDashboardPort starts the instant the backend process is spawned — before uvicorn binds its socket. On a cold install the child first compiles and imports the whole hermes_cli.main -> web_server -> FastAPI/uvicorn chain, and on Windows real-time AV scans every freshly written .pyc. That pre-bind cost can exceed the old hardcoded 45s deadline, so the desktop killed a healthy-but-still-starting backend and respawned it, piling up orphaned processes (#50209). Raise the default to 90s and make it overridable via HERMES_DESKTOP_PORT_ANNOUNCE_TIMEOUT_MS, clamped to a 45s floor so a bad override can't reintroduce the loop. Warm starts still announce in well under a second; both call sites inherit the new default with no change. Adds backend-ready.test.cjs (wired into test:desktop:platforms).
102 lines
3.5 KiB
JavaScript
102 lines
3.5 KiB
JavaScript
const _READY_RE = /^HERMES_DASHBOARD_READY port=(\d+)/m
|
|
|
|
// The announcement clock starts the instant the backend process is spawned —
|
|
// before uvicorn binds its socket. On a cold install the child must first
|
|
// compile and import the whole `hermes_cli.main` → `web_server` → FastAPI/
|
|
// uvicorn chain, and on Windows real-time AV (Defender) scans every freshly
|
|
// written `.pyc`. That pre-bind cost can run 30-60s on a slow disk, so a tight
|
|
// 45s deadline kills a *healthy but still-starting* backend and respawns it,
|
|
// piling up orphaned processes (issue #50209). A roomier default absorbs the
|
|
// cold-start cost; a warm start still announces in well under a second.
|
|
const DEFAULT_PORT_ANNOUNCE_TIMEOUT_MS = 90_000
|
|
// Never trust a deadline tighter than the warm-start path needs; floor at 45s
|
|
// (the historical default) so a malformed override can't reintroduce the loop.
|
|
const MIN_PORT_ANNOUNCE_TIMEOUT_MS = 45_000
|
|
|
|
/**
|
|
* Resolve the port-announcement deadline. Honors the
|
|
* HERMES_DESKTOP_PORT_ANNOUNCE_TIMEOUT_MS env override (for users on slow
|
|
* disks / aggressive AV who need an even longer cold-start window), clamped
|
|
* to a sane floor so a bad value can't make boot flakier than the default.
|
|
*/
|
|
function resolvePortAnnounceTimeoutMs(env = process.env) {
|
|
const parsed = Number(env.HERMES_DESKTOP_PORT_ANNOUNCE_TIMEOUT_MS)
|
|
if (Number.isFinite(parsed) && parsed > 0) {
|
|
return Math.max(MIN_PORT_ANNOUNCE_TIMEOUT_MS, Math.round(parsed))
|
|
}
|
|
return DEFAULT_PORT_ANNOUNCE_TIMEOUT_MS
|
|
}
|
|
|
|
/**
|
|
* Watch a child process's stdout for the `HERMES_DASHBOARD_READY port=<N>`
|
|
* line that web_server.py prints after uvicorn binds its socket.
|
|
*
|
|
* Returns the parsed port. Rejects if:
|
|
* - the child exits before emitting the line
|
|
* - the child emits an `error` event
|
|
* - no line arrives within the timeout
|
|
*
|
|
* The default timeout is cold-start tolerant (see
|
|
* DEFAULT_PORT_ANNOUNCE_TIMEOUT_MS) because the clock starts before the
|
|
* backend has even bound its port. Pass an explicit `timeoutMs` to override.
|
|
*
|
|
* A single `cleanup()` tears down every listener (data/exit/error/timeout)
|
|
* on every terminal path — resolve, reject, or timeout — so repeated
|
|
* backend spawns don't leak listener slots on the child.
|
|
*/
|
|
function waitForDashboardPort(child, timeoutMs = resolvePortAnnounceTimeoutMs()) {
|
|
return new Promise((resolve, reject) => {
|
|
let buf = ''
|
|
let done = false
|
|
|
|
function cleanup() {
|
|
if (done) return
|
|
done = true
|
|
clearTimeout(timer)
|
|
child.stdout.off('data', onData)
|
|
child.off('exit', onExit)
|
|
child.off('error', onError)
|
|
}
|
|
|
|
function onData(chunk) {
|
|
buf += chunk.toString()
|
|
let nl
|
|
while ((nl = buf.indexOf('\n')) !== -1) {
|
|
const line = buf.slice(0, nl)
|
|
buf = buf.slice(nl + 1)
|
|
const m = line.match(_READY_RE)
|
|
if (m) {
|
|
cleanup()
|
|
resolve(parseInt(m[1], 10))
|
|
return
|
|
}
|
|
}
|
|
}
|
|
|
|
function onExit(code, signal) {
|
|
cleanup()
|
|
reject(new Error(`Hermes backend: exited before port announcement (${signal || code})`))
|
|
}
|
|
|
|
function onError(err) {
|
|
cleanup()
|
|
reject(err)
|
|
}
|
|
|
|
const timer = setTimeout(() => {
|
|
cleanup()
|
|
reject(new Error(`Timed out waiting for Hermes backend port announcement (${timeoutMs}ms)`))
|
|
}, timeoutMs)
|
|
|
|
child.stdout.on('data', onData)
|
|
child.on('exit', onExit)
|
|
child.on('error', onError)
|
|
})
|
|
}
|
|
|
|
module.exports = {
|
|
waitForDashboardPort,
|
|
resolvePortAnnounceTimeoutMs,
|
|
DEFAULT_PORT_ANNOUNCE_TIMEOUT_MS,
|
|
MIN_PORT_ANNOUNCE_TIMEOUT_MS,
|
|
}
|