mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-16 14:32:34 +00:00
48788032da
The salvaged guard used a hand-maintained frozenset of 14 platform names — several of which (line, wechat, facebook, imessage, googlechat) aren't actual Hermes Platform values, while real ones (whatsapp_cloud, feishu, wecom, dingtalk, qqbot, yuanbao, plugin platforms like irc) were missing. Resolve the source through gateway.config.Platform instead (built-ins + registered plugin platforms via _missing_), with an explicit exclusion set for self-owned/local sources. Adds tests for the guard and both reap paths.
83 lines
3.2 KiB
Python
83 lines
3.2 KiB
Python
"""Tests for #60609: the TUI backend must not end gateway-owned sessions.
|
|
|
|
``_finalize_session`` (and thus the ws-orphan reaper / session.close paths
|
|
that funnel into it) marks the session ended in state.db. For sessions the
|
|
messaging gateway owns (telegram, discord, ...), that write creates the
|
|
Groundhog Day routing loop described in #60609 — the gateway self-heal
|
|
drops the ended-but-routed entry, recovers hours-old parent context, and
|
|
loops. The TUI is only a viewer of those sessions.
|
|
"""
|
|
|
|
from unittest.mock import MagicMock, patch
|
|
|
|
from tui_gateway.server import _finalize_session, _is_gateway_owned_source
|
|
|
|
|
|
class TestIsGatewayOwnedSource:
|
|
def test_builtin_gateway_platforms_are_owned(self):
|
|
for src in ("telegram", "discord", "whatsapp", "slack", "signal",
|
|
"matrix", "mattermost", "bluebubbles", "sms", "email"):
|
|
assert _is_gateway_owned_source(src) is True, src
|
|
|
|
def test_case_and_whitespace_normalized(self):
|
|
assert _is_gateway_owned_source(" Telegram ") is True
|
|
|
|
def test_tui_owned_sources_are_not(self):
|
|
for src in ("tui", "cli", "webui", "desktop", "cron", "subagent",
|
|
"test", "acp", ""):
|
|
assert _is_gateway_owned_source(src) is False, src
|
|
|
|
def test_local_and_server_endpoints_are_not(self):
|
|
# Platform enum members, but their sessions aren't owned by a remote
|
|
# chat surface — reaping them keeps /resume clean.
|
|
for src in ("local", "webhook", "api_server", "msgraph_webhook"):
|
|
assert _is_gateway_owned_source(src) is False, src
|
|
|
|
def test_arbitrary_strings_are_not(self):
|
|
assert _is_gateway_owned_source("hermesbench-task-xyz") is False
|
|
assert _is_gateway_owned_source(None) is False
|
|
|
|
|
|
def _make_session(session_id="sess_1"):
|
|
agent = MagicMock()
|
|
agent.session_id = session_id
|
|
return {
|
|
"agent": agent,
|
|
"history": [{"role": "user", "content": "x"}],
|
|
"history_lock": None,
|
|
"session_key": session_id,
|
|
}
|
|
|
|
|
|
class TestFinalizeSkipsGatewaySessions:
|
|
@patch("tui_gateway.server._get_db")
|
|
def test_gateway_session_not_ended(self, mock_get_db):
|
|
db = MagicMock()
|
|
db.get_session.return_value = {"id": "sess_1", "source": "telegram"}
|
|
mock_get_db.return_value = db
|
|
|
|
_finalize_session(_make_session(), end_reason="ws_orphan_reap")
|
|
|
|
db.end_session.assert_not_called()
|
|
|
|
@patch("tui_gateway.server._get_db")
|
|
def test_tui_session_still_ended(self, mock_get_db):
|
|
db = MagicMock()
|
|
db.get_session.return_value = {"id": "sess_1", "source": "tui"}
|
|
mock_get_db.return_value = db
|
|
|
|
_finalize_session(_make_session(), end_reason="ws_orphan_reap")
|
|
|
|
db.end_session.assert_called_once_with("sess_1", "ws_orphan_reap")
|
|
|
|
@patch("tui_gateway.server._get_db")
|
|
def test_missing_row_still_ended(self, mock_get_db):
|
|
"""A session with no state.db row can't be gateway-owned — keep the
|
|
pre-existing reap behavior."""
|
|
db = MagicMock()
|
|
db.get_session.return_value = None
|
|
mock_get_db.return_value = db
|
|
|
|
_finalize_session(_make_session(), end_reason="tui_close")
|
|
|
|
db.end_session.assert_called_once_with("sess_1", "tui_close")
|