mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
ebab890ae5
- CapabilityDescriptor.supported_ops + supports_op() with legacy-op-set fallback (additive, contract doc §2 updated) - get_chat_info gated on op discovery (skip round trip on legacy connectors) - _event_from_wire consumes user_display_name/user_handle (§3 fields previously dropped); native display-name parity, session-key stable - /handoff <fronted-platform> works on relay-fronted gateways: CLI pre-check reads the GATEWAY_RELAY_PLATFORMS fronted set; watcher resolves through resolve_delivery_transport and replies via send_for_platform - self-provision forwards displayName (env > skin branding, stock brand suppressed) — the primary name source for gg#171 attribution
68 lines
2.6 KiB
Python
68 lines
2.6 KiB
Python
"""Unit tests for relay wire-field hygiene (Phase 1 parity).
|
|
|
|
Covers _event_from_wire's consumption of the contract §3 user-identity
|
|
enrichment fields the connector has always sent but the gateway used to drop:
|
|
|
|
- ``user_display_name`` — the human-facing display name (native parity: the
|
|
native Discord adapter surfaces ``message.author.display_name`` as
|
|
``user_name``).
|
|
- ``user_handle`` — the raw platform handle, used only as a last resort.
|
|
|
|
Precedence: user_display_name > user_name > user_handle. Session keys derive
|
|
from user_id (never user_name), so this mapping is presentation-only and must
|
|
remain key-stable — asserted here via build_session_key.
|
|
|
|
Pure unit tests: no socket, no websockets dependency.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
from gateway.relay.ws_transport import _event_from_wire
|
|
from gateway.session import build_session_key
|
|
|
|
|
|
def _wire_event(**src_overrides):
|
|
src = {
|
|
"platform": "discord",
|
|
"chat_id": "chan-1",
|
|
"chat_type": "group",
|
|
"user_id": "u-1",
|
|
"user_name": "rawusername",
|
|
"scope_id": "guild-1",
|
|
}
|
|
src.update(src_overrides)
|
|
return {"text": "hello", "message_type": "text", "source": src}
|
|
|
|
|
|
class TestUserIdentityEnrichment:
|
|
def test_display_name_preferred_over_user_name(self):
|
|
ev = _event_from_wire(_wire_event(user_display_name="Ben Display"))
|
|
assert ev.source.user_name == "Ben Display"
|
|
|
|
def test_user_name_when_no_display_name(self):
|
|
ev = _event_from_wire(_wire_event())
|
|
assert ev.source.user_name == "rawusername"
|
|
|
|
def test_handle_is_last_resort(self):
|
|
ev = _event_from_wire(
|
|
_wire_event(user_name=None, user_handle="ben#1234")
|
|
)
|
|
assert ev.source.user_name == "ben#1234"
|
|
|
|
def test_all_absent_yields_none(self):
|
|
ev = _event_from_wire(_wire_event(user_name=None))
|
|
assert ev.source.user_name is None
|
|
|
|
def test_empty_display_name_falls_through(self):
|
|
"""An empty-string enrichment must not shadow a real user_name."""
|
|
ev = _event_from_wire(_wire_event(user_display_name=""))
|
|
assert ev.source.user_name == "rawusername"
|
|
|
|
def test_session_key_is_stable_across_name_shapes(self):
|
|
"""user_name is presentation-only: the same user_id keys the same
|
|
session whether or not the connector sent the enrichment fields."""
|
|
plain = _event_from_wire(_wire_event())
|
|
enriched = _event_from_wire(
|
|
_wire_event(user_display_name="Ben Display", user_handle="ben#1234")
|
|
)
|
|
assert build_session_key(plain.source) == build_session_key(enriched.source)
|