hermes-agent/tests/gateway/relay/test_relay_passthrough.py

"""Relay passthrough-over-WS forwarding (Phase 5 §5.1).

Proves the gateway side of §5.1: a connector-forwarded passthrough request
(Discord interaction, Twilio, …) arrives over the SAME outbound /relay WS as
inbound messages (a hosted gateway has no public inbound port), and the relay
adapter handles it — decoding the byte-preserved body and routing a Discord
interaction through the normal agent path (handle_message).

Mirrors test_relay_interrupt.py's wiring discipline (connect() registers the
connector->gateway handlers on the transport).
"""

from __future__ import annotations

import base64
import json

import pytest

from gateway.config import PlatformConfig
from gateway.relay.adapter import RelayAdapter
from gateway.relay.descriptor import CONTRACT_VERSION, CapabilityDescriptor
from gateway.relay.ws_transport import PassthroughForward, _passthrough_from_wire

from tests.gateway.relay.stub_connector import StubConnector


def _desc() -> CapabilityDescriptor:
    return CapabilityDescriptor(
        contract_version=CONTRACT_VERSION,
        platform="discord",
        label="Discord",
        max_message_length=2000,
        supports_draft_streaming=False,
        supports_edit=True,
        supports_threads=True,
        markdown_dialect="discord",
        len_unit="chars",
    )


@pytest.fixture
def adapter():
    return RelayAdapter(PlatformConfig(), _desc(), transport=StubConnector(_desc()))


def _interaction_forward(payload: dict) -> PassthroughForward:
    body = json.dumps(payload).encode("utf-8")
    return PassthroughForward(
        platform="discord",
        bot_id="appShared",
        method="POST",
        path="/interactions/discord/appShared",
        headers=[("content-type", "application/json")],
        body=body,
    )


def test_passthrough_from_wire_byte_preserves_body():
    """The wire frame's base64 body decodes back to the exact bytes (parity with
    the connector's toPassthroughForward)."""
    original = json.dumps({"type": 2, "data": {"name": "ping"}, "guild_id": "g1"}).encode("utf-8")
    wire = {
        "platform": "discord",
        "botId": "appShared",
        "method": "POST",
        "path": "/interactions/discord/appShared",
        "headers": [["content-type", "application/json"]],
        "bodyB64": base64.b64encode(original).decode("ascii"),
    }
    fwd = _passthrough_from_wire(wire)
    assert fwd.platform == "discord"
    assert fwd.bot_id == "appShared"
    assert fwd.body == original
    assert fwd.headers == [("content-type", "application/json")]


def test_passthrough_from_wire_tolerates_malformed_body():
    """A non-base64 body must not raise (the reader must never crash)."""
    fwd = _passthrough_from_wire({"platform": "x", "bodyB64": "!!!not base64!!!"})
    assert fwd.body == b""


@pytest.mark.asyncio
async def test_connect_wires_passthrough_handler_over_ws(adapter):
    """connect() registers the passthrough handler on the transport so a
    connector-delivered passthrough_forward frame reaches the adapter."""
    await adapter.connect()
    stub = adapter._transport
    assert stub._passthrough is not None


@pytest.mark.asyncio
async def test_discord_interaction_routes_through_handle_message(adapter, monkeypatch):
    """A forwarded Discord application-command interaction is decoded and routed
    through the normal agent path (handle_message) with a correct session source."""
    await adapter.connect()
    stub = adapter._transport

    seen = []

    async def fake_handle(event):
        seen.append(event)

    monkeypatch.setattr(adapter, "handle_message", fake_handle)

    fwd = _interaction_forward(
        {
            "id": "interaction-1",
            "type": 2,  # APPLICATION_COMMAND
            "channel_id": "chan-9",
            "guild_id": "guild-7",
            "data": {"name": "summarize"},
            "member": {"user": {"id": "user-3", "username": "ben"}},
        }
    )
    await stub.push_passthrough(fwd, buffer_id=None)

    assert len(seen) == 1
    ev = seen[0]
    # APPLICATION_COMMAND interactions are normalized to a leading-slash
    # command (the dispatcher's contract), not the bare registered name.
    assert ev.text == "/summarize"
    assert ev.is_command() is True
    assert ev.get_command() == "summarize"
    assert ev.source.chat_id == "chan-9"
    assert ev.source.scope_id == "guild-7"
    assert ev.source.user_id == "user-3"
    assert ev.source.chat_type == "channel"
    # Scope captured so the agent's reply re-asserts scope_id for egress.
    assert adapter._scope_by_chat.get("chan-9") == "guild-7"


@pytest.mark.asyncio
async def test_message_component_interaction_uses_custom_id(adapter, monkeypatch):
    """A MESSAGE_COMPONENT (button) interaction surfaces its custom_id as text."""
    await adapter.connect()
    stub = adapter._transport
    seen = []

    async def fake_handle(event):
        seen.append(event)

    monkeypatch.setattr(adapter, "handle_message", fake_handle)
    fwd = _interaction_forward(
        {
            "id": "i2",
            "type": 3,  # MESSAGE_COMPONENT
            "channel_id": "c2",
            "guild_id": "g2",
            "data": {"custom_id": "approve_btn"},
            "member": {"user": {"id": "u2", "username": "x"}},
        }
    )
    await stub.push_passthrough(fwd)
    assert len(seen) == 1
    assert seen[0].text == "approve_btn"
    # Component interactions stay plain text — only APPLICATION_COMMANDs are
    # normalized to slash commands.
    assert seen[0].is_command() is False


@pytest.mark.asyncio
async def test_application_command_no_options_is_slash_command(adapter, monkeypatch):
    """/new with no options -> text '/new', dispatched as a COMMAND event."""
    from gateway.platforms.base import MessageType

    await adapter.connect()
    stub = adapter._transport
    seen = []

    async def fake_handle(event):
        seen.append(event)

    monkeypatch.setattr(adapter, "handle_message", fake_handle)
    fwd = _interaction_forward(
        {
            "id": "i-new",
            "type": 2,
            "channel_id": "c3",
            "guild_id": "g3",
            "data": {"name": "new"},
            "member": {"user": {"id": "u3", "username": "ben"}},
        }
    )
    await stub.push_passthrough(fwd)
    assert len(seen) == 1
    ev = seen[0]
    assert ev.text == "/new"
    assert ev.message_type == MessageType.COMMAND
    # Behavior contract: the dispatcher must recognize this as command 'new'.
    assert ev.is_command() is True
    assert ev.get_command() == "new"
    assert ev.get_command_args() == ""


@pytest.mark.asyncio
async def test_application_command_scalar_options_append_values(adapter, monkeypatch):
    """Scalar options append their values space-separated: /model gpt-x."""
    await adapter.connect()
    stub = adapter._transport
    seen = []

    async def fake_handle(event):
        seen.append(event)

    monkeypatch.setattr(adapter, "handle_message", fake_handle)
    fwd = _interaction_forward(
        {
            "id": "i-model",
            "type": 2,
            "channel_id": "c4",
            "guild_id": "g4",
            "data": {
                "name": "model",
                "options": [{"name": "name", "type": 3, "value": "gpt-x"}],
            },
            "member": {"user": {"id": "u4", "username": "ben"}},
        }
    )
    await stub.push_passthrough(fwd)
    assert len(seen) == 1
    ev = seen[0]
    assert ev.text == "/model gpt-x"
    assert ev.is_command() is True
    assert ev.get_command() == "model"
    assert ev.get_command_args() == "gpt-x"


@pytest.mark.asyncio
async def test_application_command_subcommand_nesting_renders_names_then_values(
    adapter, monkeypatch
):
    """SUB_COMMAND (type 1) appends its name, then recurses into its options."""
    await adapter.connect()
    stub = adapter._transport
    seen = []

    async def fake_handle(event):
        seen.append(event)

    monkeypatch.setattr(adapter, "handle_message", fake_handle)
    fwd = _interaction_forward(
        {
            "id": "i-sub",
            "type": 2,
            "channel_id": "c5",
            "guild_id": "g5",
            "data": {
                "name": "skill",
                "options": [
                    {
                        "name": "run",
                        "type": 1,  # SUB_COMMAND
                        "options": [{"name": "target", "type": 3, "value": "deploy"}],
                    }
                ],
            },
            "member": {"user": {"id": "u5", "username": "ben"}},
        }
    )
    await stub.push_passthrough(fwd)
    assert len(seen) == 1
    ev = seen[0]
    assert ev.text == "/skill run deploy"
    assert ev.is_command() is True
    assert ev.get_command() == "skill"
    assert ev.get_command_args() == "run deploy"


@pytest.mark.asyncio
async def test_ping_interaction_produces_no_command(adapter, monkeypatch):
    """A PING (type 1) body — never normally forwarded — stays empty TEXT, not
    a phantom command."""
    from gateway.platforms.base import MessageType

    await adapter.connect()
    stub = adapter._transport
    seen = []

    async def fake_handle(event):
        seen.append(event)

    monkeypatch.setattr(adapter, "handle_message", fake_handle)
    fwd = _interaction_forward(
        {
            "id": "i-ping",
            "type": 1,  # PING
            "channel_id": "c6",
            "user": {"id": "u6", "username": "ben"},
        }
    )
    await stub.push_passthrough(fwd)
    assert len(seen) == 1
    ev = seen[0]
    assert ev.text == ""
    assert ev.message_type == MessageType.TEXT
    assert ev.is_command() is False


@pytest.mark.asyncio
async def test_malformed_interaction_body_does_not_raise(adapter, monkeypatch):
    """A non-JSON forward is logged and dropped — never crashes the read loop."""
    await adapter.connect()
    stub = adapter._transport
    called = []

    async def fake_handle(event):
        called.append(event)

    monkeypatch.setattr(adapter, "handle_message", fake_handle)
    bad = PassthroughForward(
        platform="discord",
        bot_id="appShared",
        method="POST",
        path="/x",
        headers=[],
        body=b"not json",
    )
    await stub.push_passthrough(bad)  # must not raise
    assert called == []


@pytest.mark.asyncio
async def test_non_discord_forward_dropped_cleanly(adapter, monkeypatch):
    """A platform with no gateway-side handler yet (e.g. twilio) is dropped, not raised."""
    await adapter.connect()
    stub = adapter._transport
    called = []

    async def fake_handle(event):
        called.append(event)

    monkeypatch.setattr(adapter, "handle_message", fake_handle)
    fwd = PassthroughForward(
        platform="twilio",
        bot_id="bot1",
        method="POST",
        path="/webhooks/twilio/seg",
        headers=[],
        body=b"From=+1&Body=hi",
    )
    await stub.push_passthrough(fwd)  # must not raise
    assert called == []