mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
139 lines
3.4 KiB
Python
139 lines
3.4 KiB
Python
"""Tests for plugins/plugin_utils.py — thread-safe lazy singleton helpers.
|
|
|
|
These exercise the actual concurrency guarantee with real threads (not mocks):
|
|
a barrier releases N threads simultaneously into the accessor, and we assert
|
|
the factory ran exactly once.
|
|
"""
|
|
|
|
import threading
|
|
|
|
import pytest
|
|
|
|
from plugins.plugin_utils import SingletonSlot, lazy_singleton
|
|
|
|
|
|
# --- lazy_singleton -------------------------------------------------------
|
|
|
|
|
|
def test_lazy_singleton_builds_once_and_returns_same_instance():
|
|
calls = []
|
|
|
|
@lazy_singleton
|
|
def get():
|
|
calls.append(1)
|
|
return object()
|
|
|
|
a = get()
|
|
b = get()
|
|
assert a is b
|
|
assert len(calls) == 1
|
|
|
|
|
|
def test_lazy_singleton_reset_rebuilds():
|
|
counter = {"n": 0}
|
|
|
|
@lazy_singleton
|
|
def get():
|
|
counter["n"] += 1
|
|
return counter["n"]
|
|
|
|
assert get() == 1
|
|
assert get() == 1
|
|
get.reset()
|
|
assert get() == 2
|
|
|
|
|
|
|
|
|
|
def test_lazy_singleton_concurrent_first_call_builds_once():
|
|
build_count = {"n": 0}
|
|
build_lock = threading.Lock()
|
|
barrier = threading.Barrier(16)
|
|
results = []
|
|
results_lock = threading.Lock()
|
|
|
|
@lazy_singleton
|
|
def get():
|
|
# Count builds under a lock so the assertion is exact even if the
|
|
# double-checked lock had a bug and let two through.
|
|
with build_lock:
|
|
build_count["n"] += 1
|
|
# Simulate an expensive build so threads genuinely overlap.
|
|
import time
|
|
time.sleep(0.01)
|
|
return object()
|
|
|
|
def worker():
|
|
barrier.wait() # release all threads at once
|
|
obj = get()
|
|
with results_lock:
|
|
results.append(obj)
|
|
|
|
threads = [threading.Thread(target=worker) for _ in range(16)]
|
|
for t in threads:
|
|
t.start()
|
|
for t in threads:
|
|
t.join()
|
|
|
|
assert build_count["n"] == 1, "factory must run exactly once under race"
|
|
assert len(results) == 16
|
|
assert all(r is results[0] for r in results), "all callers share one instance"
|
|
|
|
|
|
# --- SingletonSlot --------------------------------------------------------
|
|
|
|
|
|
def test_slot_caches_first_value():
|
|
slot: SingletonSlot = SingletonSlot()
|
|
assert slot.peek() is None
|
|
v1 = slot.get(lambda: "first")
|
|
assert slot.peek() == "first"
|
|
# Subsequent factory is ignored — first value wins.
|
|
v2 = slot.get(lambda: "second")
|
|
assert v1 == v2 == "first"
|
|
|
|
|
|
|
|
|
|
def test_slot_factory_exception_not_cached():
|
|
slot: SingletonSlot = SingletonSlot()
|
|
|
|
def boom():
|
|
raise ValueError("nope")
|
|
|
|
with pytest.raises(ValueError):
|
|
slot.get(boom)
|
|
assert slot.peek() is None
|
|
assert slot.get(lambda: "recovered") == "recovered"
|
|
|
|
|
|
def test_slot_concurrent_first_call_builds_once():
|
|
build_count = {"n": 0}
|
|
build_lock = threading.Lock()
|
|
barrier = threading.Barrier(16)
|
|
slot: SingletonSlot = SingletonSlot()
|
|
results = []
|
|
results_lock = threading.Lock()
|
|
|
|
def factory():
|
|
with build_lock:
|
|
build_count["n"] += 1
|
|
import time
|
|
time.sleep(0.01)
|
|
return object()
|
|
|
|
def worker():
|
|
barrier.wait()
|
|
obj = slot.get(factory)
|
|
with results_lock:
|
|
results.append(obj)
|
|
|
|
threads = [threading.Thread(target=worker) for _ in range(16)]
|
|
for t in threads:
|
|
t.start()
|
|
for t in threads:
|
|
t.join()
|
|
|
|
assert build_count["n"] == 1
|
|
assert len(results) == 16
|
|
assert all(r is results[0] for r in results)
|