mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-05-04 02:21:47 +00:00
Adds optional per-section overrides on top of the existing global
details_mode (hidden | collapsed | expanded). Lets users keep the
accordion collapsed by default while auto-expanding tools, or hide the
activity panel entirely without touching thinking/tools/subagents.
Config (~/.hermes/config.yaml):
display:
details_mode: collapsed
sections:
thinking: expanded
tools: expanded
activity: hidden
Slash command:
/details show current global + overrides
/details [hidden|collapsed|expanded] set global mode (existing)
/details <section> <mode|reset> per-section override (new)
/details <section> reset clear override
Sections: thinking, tools, subagents, activity.
Implementation:
- ui-tui/src/types.ts SectionName + SectionVisibility
- ui-tui/src/domain/details.ts parseSectionMode / resolveSections /
sectionMode + SECTION_NAMES
- ui-tui/src/app/uiStore.ts +
app/interfaces.ts +
app/useConfigSync.ts sections threaded into UiState
- ui-tui/src/components/
thinking.tsx ToolTrail consults per-section mode for
hidden/expanded behaviour; expandAll
skips hidden sections; floating-alert
fallback respects activity:hidden
- ui-tui/src/components/
messageLine.tsx + appLayout.tsx pass sections through render tree
- ui-tui/src/app/slash/
commands/core.ts /details <section> <mode|reset> syntax
- tui_gateway/server.py config.set details_mode.<section>
writes to display.sections.<section>
(empty value clears the override)
- website/docs/user-guide/tui.md documented
Tests: 14 new (4 domain, 4 useConfigSync, 3 slash, 3 gateway).
Total: 269/269 vitest, all gateway tests pass.
162 lines
4.4 KiB
TypeScript
162 lines
4.4 KiB
TypeScript
import { beforeEach, describe, expect, it, vi } from 'vitest'
|
|
|
|
import { $uiState, resetUiState } from '../app/uiStore.js'
|
|
import { applyDisplay, normalizeStatusBar } from '../app/useConfigSync.js'
|
|
|
|
describe('applyDisplay', () => {
|
|
beforeEach(() => {
|
|
resetUiState()
|
|
})
|
|
|
|
it('fans every display flag out to $uiState and the bell callback', () => {
|
|
const setBell = vi.fn()
|
|
|
|
applyDisplay(
|
|
{
|
|
config: {
|
|
display: {
|
|
bell_on_complete: true,
|
|
details_mode: 'expanded',
|
|
inline_diffs: false,
|
|
show_cost: true,
|
|
show_reasoning: true,
|
|
streaming: false,
|
|
tui_compact: true,
|
|
tui_statusbar: false
|
|
}
|
|
}
|
|
},
|
|
setBell
|
|
)
|
|
|
|
const s = $uiState.get()
|
|
expect(setBell).toHaveBeenCalledWith(true)
|
|
expect(s.compact).toBe(true)
|
|
expect(s.detailsMode).toBe('expanded')
|
|
expect(s.inlineDiffs).toBe(false)
|
|
expect(s.showCost).toBe(true)
|
|
expect(s.showReasoning).toBe(true)
|
|
expect(s.statusBar).toBe('off')
|
|
expect(s.streaming).toBe(false)
|
|
})
|
|
|
|
it('coerces legacy true + "on" alias to top', () => {
|
|
const setBell = vi.fn()
|
|
|
|
applyDisplay({ config: { display: { tui_statusbar: true as unknown as 'on' } } }, setBell)
|
|
expect($uiState.get().statusBar).toBe('top')
|
|
|
|
applyDisplay({ config: { display: { tui_statusbar: 'on' } } }, setBell)
|
|
expect($uiState.get().statusBar).toBe('top')
|
|
})
|
|
|
|
it('applies v1 parity defaults when display fields are missing', () => {
|
|
const setBell = vi.fn()
|
|
|
|
applyDisplay({ config: { display: {} } }, setBell)
|
|
|
|
const s = $uiState.get()
|
|
expect(setBell).toHaveBeenCalledWith(false)
|
|
expect(s.inlineDiffs).toBe(true)
|
|
expect(s.showCost).toBe(false)
|
|
expect(s.showReasoning).toBe(false)
|
|
expect(s.statusBar).toBe('top')
|
|
expect(s.streaming).toBe(true)
|
|
expect(s.sections).toEqual({})
|
|
})
|
|
|
|
it('parses display.sections into per-section overrides', () => {
|
|
const setBell = vi.fn()
|
|
|
|
applyDisplay(
|
|
{
|
|
config: {
|
|
display: {
|
|
details_mode: 'collapsed',
|
|
sections: {
|
|
activity: 'hidden',
|
|
tools: 'expanded',
|
|
thinking: 'expanded',
|
|
bogus: 'expanded'
|
|
}
|
|
}
|
|
}
|
|
},
|
|
setBell
|
|
)
|
|
|
|
const s = $uiState.get()
|
|
expect(s.detailsMode).toBe('collapsed')
|
|
expect(s.sections).toEqual({
|
|
activity: 'hidden',
|
|
tools: 'expanded',
|
|
thinking: 'expanded'
|
|
})
|
|
})
|
|
|
|
it('drops invalid section modes', () => {
|
|
const setBell = vi.fn()
|
|
|
|
applyDisplay(
|
|
{
|
|
config: {
|
|
display: {
|
|
sections: { tools: 'maximised' as unknown as string, activity: 'hidden' }
|
|
}
|
|
}
|
|
},
|
|
setBell
|
|
)
|
|
|
|
expect($uiState.get().sections).toEqual({ activity: 'hidden' })
|
|
})
|
|
|
|
it('treats a null config like an empty display block', () => {
|
|
const setBell = vi.fn()
|
|
|
|
applyDisplay(null, setBell)
|
|
|
|
const s = $uiState.get()
|
|
expect(setBell).toHaveBeenCalledWith(false)
|
|
expect(s.inlineDiffs).toBe(true)
|
|
expect(s.streaming).toBe(true)
|
|
})
|
|
|
|
it('accepts the new string statusBar modes', () => {
|
|
const setBell = vi.fn()
|
|
|
|
applyDisplay({ config: { display: { tui_statusbar: 'bottom' } } }, setBell)
|
|
expect($uiState.get().statusBar).toBe('bottom')
|
|
|
|
applyDisplay({ config: { display: { tui_statusbar: 'top' } } }, setBell)
|
|
expect($uiState.get().statusBar).toBe('top')
|
|
})
|
|
})
|
|
|
|
describe('normalizeStatusBar', () => {
|
|
it('maps legacy bool + on alias to top/off', () => {
|
|
expect(normalizeStatusBar(true)).toBe('top')
|
|
expect(normalizeStatusBar(false)).toBe('off')
|
|
expect(normalizeStatusBar('on')).toBe('top')
|
|
})
|
|
|
|
it('passes through the canonical enum', () => {
|
|
expect(normalizeStatusBar('off')).toBe('off')
|
|
expect(normalizeStatusBar('top')).toBe('top')
|
|
expect(normalizeStatusBar('bottom')).toBe('bottom')
|
|
})
|
|
|
|
it('defaults missing/unknown values to top', () => {
|
|
expect(normalizeStatusBar(undefined)).toBe('top')
|
|
expect(normalizeStatusBar(null)).toBe('top')
|
|
expect(normalizeStatusBar('sideways')).toBe('top')
|
|
expect(normalizeStatusBar(42)).toBe('top')
|
|
})
|
|
|
|
it('trims whitespace and folds case', () => {
|
|
expect(normalizeStatusBar(' Bottom ')).toBe('bottom')
|
|
expect(normalizeStatusBar('TOP')).toBe('top')
|
|
expect(normalizeStatusBar(' on ')).toBe('top')
|
|
expect(normalizeStatusBar('OFF')).toBe('off')
|
|
})
|
|
})
|