mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-20 15:33:54 +00:00
b42c5bf652
The previous test patched ssl.create_default_context globally with a bare SSLContext that has zero CA certs. Both verify_ca_bundle() and the macOS fallback got the same mocked context, so the test verified nothing useful: both paths produced empty get_ca_certs() and the assertion that no exception escaped was vacuously satisfied. Only mock the fallback call (no cafile) — let the certifi call hit the real SSL stack and fail with SSLError on the broken PEM. The mock fallback returns a context with load_default_certs() so the test now verifies the real scenario: broken certifi → SSLConfigurationError, macOS system trust store → success. Also pads the broken PEM past the 1 KB size guard so the size check doesn't short-circuit before ssl.create_default_context(cafile=...) runs. Reported by @liuhao1024 in PR review.
82 lines
3.1 KiB
Python
82 lines
3.1 KiB
Python
"""Tests for the preventive SSL CA bundle guard."""
|
|
|
|
import os
|
|
import ssl
|
|
from pathlib import Path
|
|
from unittest.mock import patch
|
|
|
|
import certifi
|
|
import pytest
|
|
|
|
from agent.errors import SSLConfigurationError
|
|
from agent.ssl_guard import (
|
|
verify_ca_bundle,
|
|
verify_ca_bundle_with_fallback,
|
|
)
|
|
|
|
|
|
def test_healthy_bundle_passes(tmp_path, monkeypatch):
|
|
"""A real, non-empty certifi bundle must verify without raising."""
|
|
# Sanity: certifi.where() must point to a real file in the test venv.
|
|
bundle = Path(certifi.where())
|
|
assert bundle.exists()
|
|
assert bundle.stat().st_size > 1024
|
|
verify_ca_bundle() # should not raise
|
|
|
|
|
|
def test_missing_bundle_raises_ssl_error(monkeypatch, tmp_path):
|
|
"""Point certifi.where() at a non-existent path; expect a clear error."""
|
|
fake = tmp_path / "nope.pem"
|
|
monkeypatch.setattr(certifi, "where", lambda: str(fake))
|
|
with pytest.raises(SSLConfigurationError) as exc:
|
|
verify_ca_bundle()
|
|
assert "not found" in str(exc.value).lower()
|
|
|
|
|
|
def test_empty_bundle_raises_ssl_error(monkeypatch, tmp_path):
|
|
"""Empty file is treated as a corrupted bundle."""
|
|
fake = tmp_path / "empty.pem"
|
|
fake.write_bytes(b"")
|
|
monkeypatch.setattr(certifi, "where", lambda: str(fake))
|
|
with pytest.raises(SSLConfigurationError) as exc:
|
|
verify_ca_bundle()
|
|
assert "corrupted" in str(exc.value).lower() or "empty" in str(exc.value).lower()
|
|
|
|
|
|
def test_skip_env_var_disables_guard(monkeypatch, tmp_path):
|
|
"""HERMES_SKIP_SSL_GUARD=1 must make the guard a no-op."""
|
|
monkeypatch.setenv("HERMES_SKIP_SSL_GUARD", "1")
|
|
fake = tmp_path / "nope.pem" # would raise if guard ran
|
|
monkeypatch.setattr(certifi, "where", lambda: str(fake))
|
|
verify_ca_bundle() # should not raise
|
|
|
|
|
|
def test_macos_fallback_allows_startup(monkeypatch, tmp_path):
|
|
"""On Darwin, an unloadable certifi bundle must fall back to system trust.
|
|
|
|
Only the fallback call (no cafile) is mocked — the certifi call must
|
|
fail naturally with SSLError from the broken PEM. The mock returns a
|
|
context with system CAs loaded, so the fallback succeeds.
|
|
"""
|
|
fake = tmp_path / "broken.pem"
|
|
# > 1024 bytes so the size guard doesn't short-circuit before ssl runs.
|
|
fake.write_bytes(b"not a real bundle" + b" " * 2000)
|
|
monkeypatch.setattr(certifi, "where", lambda: str(fake))
|
|
monkeypatch.setattr("platform.system", lambda: "Darwin")
|
|
|
|
_real_create = ssl.create_default_context
|
|
|
|
def _mock_create(purpose=ssl.Purpose.SERVER_AUTH, **kwargs):
|
|
if kwargs.get("cafile"):
|
|
# Let the certifi call hit the real SSL stack → raises SSLError
|
|
# on the broken PEM, which verify_ca_bundle() wraps as
|
|
# SSLConfigurationError. This is the path the fallback rescues.
|
|
return _real_create(purpose, **kwargs)
|
|
# Fallback call: simulate a healthy system trust store.
|
|
ctx = ssl.SSLContext(ssl.PROTOCOL_TLS_CLIENT)
|
|
ctx.load_default_certs()
|
|
return ctx
|
|
|
|
with patch("ssl.create_default_context", side_effect=_mock_create):
|
|
# Should NOT raise — macOS system trust store covers the broken bundle.
|
|
verify_ca_bundle_with_fallback()
|