mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-05-18 04:41:56 +00:00
Deletes tools/web_providers/{brave_free,ddgs,searxng}.py — the three
providers that moved to plugins/web/ in prior commits. tools/web_tools.py
no longer imports them (registry dispatch as of d8735963f), so removing
them is purely a cleanup pass.
Also migrates the existing tests to the new import paths:
tests/tools/test_web_providers_brave_free.py
tests/tools/test_web_providers_ddgs.py
tests/tools/test_web_providers_searxng.py
Mechanical rewrites:
- `from tools.web_providers.X import YSearchProvider`
-> `from plugins.web.X.provider import YWebSearchProvider`
- `.is_configured()` -> `.is_available()` (legacy method -> new method)
- `.provider_name()` -> `.name` (legacy method -> new property)
- `from tools.web_providers.base import WebSearchProvider`
-> `from agent.web_search_provider import WebSearchProvider`
(the subclass-check asserts membership in the new plugin-facing ABC)
- `sys.modules.delitem("tools.web_providers.ddgs")` updated to point at
`plugins.web.ddgs.provider` (cache-busting for lazy ddgs imports)
The TestXBackendWiring / TestXSearchOnlyErrors classes (covering
_is_backend_available, _get_backend, check_web_api_key, and the
"search-only" error paths in web_extract/web_crawl) are untouched —
those still test web_tools.py's backend-selection logic, which continues
to recognize the names "brave-free" / "ddgs" / "searxng" even after the
modules behind them moved to plugins.
tools/web_providers/base.py is intentionally NOT deleted by this commit
— it's the parent ABC of the legacy modules and shares its name with
agent/web_search_provider.py::WebSearchProvider. Removing it surfaces the
naming collision (see PR description Finding 0); the real migration PR
deletes it in the same commit that drops the _WEB_PLUGIN_SKIPLIST
guards in hermes_cli/tools_config.py.
Test results:
bash scripts/run_tests.sh tests/tools/test_web_providers_*.py
-> 65 passed in 3.41s (all rewritten unit tests + unchanged integration tests)
bash scripts/run_tests.sh tests/tools/test_web_*.py
-> 141 passed in 4.70s (full web test set, post-deletion)
137 lines
4.5 KiB
Python
137 lines
4.5 KiB
Python
"""Brave Search (free tier) — plugin form.
|
|
|
|
Subclasses :class:`agent.web_search_provider.WebSearchProvider` (the
|
|
plugin-facing ABC). The legacy in-tree module
|
|
``tools.web_providers.brave_free`` was removed in the same commit that
|
|
moved this code under ``plugins/``; this file is now the canonical
|
|
implementation.
|
|
|
|
Config keys this provider responds to::
|
|
|
|
web:
|
|
search_backend: "brave-free" # explicit per-capability
|
|
backend: "brave-free" # shared fallback
|
|
|
|
Auth env var::
|
|
|
|
BRAVE_SEARCH_API_KEY=... # https://brave.com/search/api/ (free tier)
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import logging
|
|
import os
|
|
from typing import Any, Dict
|
|
|
|
from agent.web_search_provider import WebSearchProvider
|
|
|
|
logger = logging.getLogger(__name__)
|
|
|
|
_BRAVE_ENDPOINT = "https://api.search.brave.com/res/v1/web/search"
|
|
|
|
|
|
class BraveFreeWebSearchProvider(WebSearchProvider):
|
|
"""Search-only Brave provider using the free-tier Data-for-Search API.
|
|
|
|
Free tier is 2,000 queries/month (1 qps). No content-extraction capability —
|
|
users pair this with Firecrawl/Tavily/Exa for ``web_extract``.
|
|
"""
|
|
|
|
@property
|
|
def name(self) -> str:
|
|
# Hyphen form preserved for backward compat with the existing
|
|
# ``web.search_backend: "brave-free"`` config keys users have set.
|
|
return "brave-free"
|
|
|
|
@property
|
|
def display_name(self) -> str:
|
|
return "Brave Search (Free)"
|
|
|
|
def is_available(self) -> bool:
|
|
"""Return True when ``BRAVE_SEARCH_API_KEY`` is set to a non-empty value."""
|
|
return bool(os.getenv("BRAVE_SEARCH_API_KEY", "").strip())
|
|
|
|
def supports_search(self) -> bool:
|
|
return True
|
|
|
|
def supports_extract(self) -> bool:
|
|
return False
|
|
|
|
def search(self, query: str, limit: int = 5) -> Dict[str, Any]:
|
|
"""Execute a search against the Brave Search API.
|
|
|
|
Returns ``{"success": True, "data": {"web": [{"title", "url", "description", "position"}]}}``
|
|
on success, or ``{"success": False, "error": str}`` on failure.
|
|
"""
|
|
import httpx
|
|
|
|
api_key = os.getenv("BRAVE_SEARCH_API_KEY", "").strip()
|
|
if not api_key:
|
|
return {"success": False, "error": "BRAVE_SEARCH_API_KEY is not set"}
|
|
|
|
# Brave's `count` is capped at 20.
|
|
count = max(1, min(int(limit), 20))
|
|
|
|
try:
|
|
resp = httpx.get(
|
|
_BRAVE_ENDPOINT,
|
|
params={"q": query, "count": count},
|
|
headers={
|
|
"X-Subscription-Token": api_key,
|
|
"Accept": "application/json",
|
|
},
|
|
timeout=15,
|
|
)
|
|
resp.raise_for_status()
|
|
except httpx.HTTPStatusError as exc:
|
|
logger.warning("Brave Search HTTP error: %s", exc)
|
|
return {
|
|
"success": False,
|
|
"error": f"Brave Search returned HTTP {exc.response.status_code}",
|
|
}
|
|
except httpx.RequestError as exc:
|
|
logger.warning("Brave Search request error: %s", exc)
|
|
return {"success": False, "error": f"Could not reach Brave Search: {exc}"}
|
|
|
|
try:
|
|
data = resp.json()
|
|
except Exception as exc: # noqa: BLE001
|
|
logger.warning("Brave Search response parse error: %s", exc)
|
|
return {"success": False, "error": "Could not parse Brave Search response as JSON"}
|
|
|
|
raw_results = (data.get("web") or {}).get("results", []) or []
|
|
truncated = raw_results[:limit]
|
|
|
|
web_results = [
|
|
{
|
|
"title": str(r.get("title", "")),
|
|
"url": str(r.get("url", "")),
|
|
"description": str(r.get("description", "")),
|
|
"position": i + 1,
|
|
}
|
|
for i, r in enumerate(truncated)
|
|
]
|
|
|
|
logger.info(
|
|
"Brave Search '%s': %d results (from %d raw, limit %d)",
|
|
query,
|
|
len(web_results),
|
|
len(raw_results),
|
|
limit,
|
|
)
|
|
|
|
return {"success": True, "data": {"web": web_results}}
|
|
|
|
def get_setup_schema(self) -> Dict[str, Any]:
|
|
return {
|
|
"name": "Brave Search (Free)",
|
|
"badge": "free",
|
|
"tag": "Free-tier API key — 2k queries/mo, search only.",
|
|
"env_vars": [
|
|
{
|
|
"key": "BRAVE_SEARCH_API_KEY",
|
|
"prompt": "Brave Search API key (free tier)",
|
|
"url": "https://brave.com/search/api/",
|
|
},
|
|
],
|
|
}
|