mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
59 lines
1.7 KiB
Python
59 lines
1.7 KiB
Python
"""Tests for send_message action='react'/'unreact' dispatch.
|
|
|
|
Kept separate from ``test_send_message_tool.py`` because that module skips
|
|
wholesale when optional Telegram dependencies are not installed.
|
|
"""
|
|
|
|
import json
|
|
from types import SimpleNamespace
|
|
from unittest.mock import patch
|
|
|
|
import tools.send_message_tool as smt
|
|
|
|
|
|
class _FakePhotonAdapter:
|
|
"""Adapter exposing add_reaction/remove_reaction coroutines."""
|
|
|
|
def __init__(self):
|
|
self.calls = []
|
|
|
|
async def add_reaction(self, chat_id, emoji, message_id=None):
|
|
self.calls.append(("add", chat_id, emoji, message_id))
|
|
return {"success": True, "emoji": emoji}
|
|
|
|
async def remove_reaction(self, chat_id, message_id=None):
|
|
self.calls.append(("remove", chat_id, message_id))
|
|
return {"success": True}
|
|
|
|
|
|
class _NoReactionAdapter:
|
|
"""Adapter with no reaction support at all."""
|
|
|
|
|
|
def _runner_with(adapter):
|
|
from gateway.config import Platform
|
|
|
|
return SimpleNamespace(adapters={Platform("photon"): adapter})
|
|
|
|
|
|
def _call(args):
|
|
return json.loads(smt.send_message_tool(args))
|
|
|
|
|
|
def test_react_dispatches_to_add_reaction():
|
|
adapter = _FakePhotonAdapter()
|
|
with patch("gateway.run._gateway_runner_ref", lambda: _runner_with(adapter)):
|
|
result = _call(
|
|
{"action": "react", "target": "photon:+15551234567", "emoji": "❤️"}
|
|
)
|
|
assert result["success"] is True
|
|
assert adapter.calls == [("add", "+15551234567", "❤️", None)]
|
|
|
|
|
|
def test_react_without_live_gateway():
|
|
with patch("gateway.run._gateway_runner_ref", lambda: None):
|
|
result = _call(
|
|
{"action": "react", "target": "photon:+15551234567", "emoji": "👍"}
|
|
)
|
|
assert result.get("success") is not True
|
|
assert "live" in json.dumps(result)
|