mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
68 lines
2 KiB
Python
68 lines
2 KiB
Python
"""Tests for _verify_console_scripts_installed (issue #52931)."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import textwrap
|
|
from pathlib import Path
|
|
from unittest.mock import patch
|
|
|
|
import pytest
|
|
|
|
|
|
@pytest.fixture
|
|
def temp_pyproject(tmp_path, monkeypatch):
|
|
pyproject = tmp_path / "pyproject.toml"
|
|
pyproject.write_text(
|
|
textwrap.dedent(
|
|
"""\
|
|
[project]
|
|
name = "fake"
|
|
version = "0.0.0"
|
|
|
|
[project.scripts]
|
|
hermes = "hermes_cli.main:main"
|
|
hermes-agent = "run_agent:main"
|
|
hermes-acp = "acp_adapter.entry:main"
|
|
"""
|
|
)
|
|
)
|
|
import hermes_cli.main as main_mod
|
|
|
|
monkeypatch.setattr(main_mod, "PROJECT_ROOT", tmp_path)
|
|
return tmp_path
|
|
|
|
|
|
@pytest.fixture
|
|
def fake_scripts_dir(tmp_path):
|
|
scripts = tmp_path / "venv" / "Scripts"
|
|
scripts.mkdir(parents=True)
|
|
return scripts
|
|
|
|
|
|
class TestVerifyConsoleScriptsInstalled:
|
|
def test_no_action_when_all_shims_present(self, temp_pyproject, fake_scripts_dir):
|
|
for name in ("hermes", "hermes-agent", "hermes-acp"):
|
|
(fake_scripts_dir / f"{name}.exe").write_bytes(b"fake")
|
|
|
|
with patch("hermes_cli.main._is_windows", return_value=True), \
|
|
patch("hermes_cli.main._venv_scripts_dir", return_value=fake_scripts_dir), \
|
|
patch("hermes_cli.main._run_quarantined_install") as mock_install:
|
|
from hermes_cli.main import _verify_console_scripts_installed
|
|
|
|
_verify_console_scripts_installed(["uv", "pip"], env={})
|
|
|
|
mock_install.assert_not_called()
|
|
|
|
|
|
|
|
|
|
def test_quarantine_shims_include_declared_console_scripts(
|
|
self, temp_pyproject, fake_scripts_dir
|
|
):
|
|
import hermes_cli.main as main_mod
|
|
|
|
with patch("hermes_cli.main._is_windows", return_value=True):
|
|
names = {path.name for path in main_mod._hermes_exe_shims(fake_scripts_dir)}
|
|
|
|
assert {"hermes.exe", "hermes-agent.exe", "hermes-acp.exe"} <= names
|
|
assert "hermes-gateway.exe" in names
|