mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-30 19:09:28 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
82 lines
2.5 KiB
Python
82 lines
2.5 KiB
Python
"""The plugin context exposes register_dashboard_auth_provider.
|
|
|
|
Mirrors the image-gen / memory-provider hooks (see plugins.py:531 for prior
|
|
art).
|
|
"""
|
|
from __future__ import annotations
|
|
|
|
import pytest
|
|
|
|
from hermes_cli.dashboard_auth import clear_providers, get_provider
|
|
from hermes_cli.dashboard_auth.base import (
|
|
DashboardAuthProvider, LoginStart, Session,
|
|
)
|
|
from hermes_cli.plugins import PluginContext, PluginManifest
|
|
|
|
|
|
class _Stub(DashboardAuthProvider):
|
|
name = "stub"
|
|
display_name = "Stub IdP"
|
|
|
|
def start_login(self, *, redirect_uri):
|
|
return LoginStart(redirect_url="x", cookie_payload={})
|
|
|
|
def complete_login(self, *, code, state, code_verifier, redirect_uri):
|
|
return Session("u", "e", "n", "o", "stub", 0, "a", "r")
|
|
|
|
def verify_session(self, *, access_token):
|
|
return None
|
|
|
|
def refresh_session(self, *, refresh_token):
|
|
return Session("u", "e", "n", "o", "stub", 0, "a", "r")
|
|
|
|
def revoke_session(self, *, refresh_token):
|
|
return None
|
|
|
|
|
|
class _MinimalManager:
|
|
"""The fixture only needs whatever PluginContext touches at register-time.
|
|
|
|
We don't import the real PluginManager because it pulls in the full
|
|
plugin-discovery surface. The hook we're testing only reads from
|
|
``ctx.manifest``, so the manager attributes don't matter — but we set
|
|
the few that other PluginContext methods touch defensively.
|
|
"""
|
|
|
|
_cli_ref = None
|
|
_context_engine = None
|
|
_tools: dict = {}
|
|
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def _isolated_registry():
|
|
clear_providers()
|
|
yield
|
|
clear_providers()
|
|
|
|
|
|
def _make_ctx(name: str = "dashboard-auth-stub") -> PluginContext:
|
|
manifest = PluginManifest(name=name, version="0.0.1", description="stub")
|
|
return PluginContext(manifest=manifest, manager=_MinimalManager()) # type: ignore[arg-type]
|
|
|
|
|
|
def test_plugin_ctx_exposes_register_dashboard_auth_provider():
|
|
ctx = _make_ctx()
|
|
assert hasattr(ctx, "register_dashboard_auth_provider")
|
|
|
|
|
|
def test_plugin_ctx_silently_ignores_non_provider(caplog):
|
|
"""Mirror image_gen behaviour: log warning, leave registry empty.
|
|
|
|
We do NOT raise — a misbehaving plugin must not crash the host.
|
|
"""
|
|
import logging
|
|
ctx = _make_ctx("dashboard-auth-bad")
|
|
with caplog.at_level(logging.WARNING):
|
|
ctx.register_dashboard_auth_provider("not a provider") # type: ignore[arg-type]
|
|
assert get_provider("stub") is None
|
|
assert any(
|
|
"dashboard-auth-bad" in rec.message
|
|
and "DashboardAuthProvider" in rec.message
|
|
for rec in caplog.records
|
|
)
|