mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
464a0645e7
The guard wasn't firing because Electron tests create their own page
via app.firstWindow(), not via Playwright's default page fixture. The
base.afterEach's page fixture was undefined for Electron tests.
Fix: export installErrorBannerGuard + collectErrorBanners from
e2e/test.ts, call installErrorBannerGuard from launchDesktop() and
setupPackagedApp() in fixtures.ts (both firstWindow() call sites),
and use activePage (set by the guard) in afterEach instead of the
default page fixture.
Verified: the guard now catches the 'Resume failed' error banner
('handler error: str object has no attribute get') that appears
during the large-session-reload e2e test.
|
||
|---|---|---|
| .. | ||
| bootstrap-installer | ||
| desktop | ||
| shared | ||