mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-23 16:36:23 +00:00
7857d8737c
The Desktop app can now sign in to a gated gateway using the user's SYSTEM browser and OAuth 2.0 for Native Apps (RFC 8252) instead of an embedded Electron BrowserWindow, and authenticates with bearer tokens it holds itself instead of relying on HttpOnly browser session cookies. Why brokered: the upstream IDP (Nous Portal) binds client_id to the gateway instance and only permits redirect_uris on the gateway's own origin, so a desktop loopback redirect can't be a direct Portal client. The gateway therefore acts as the authorization server TO the desktop and an OAuth client TO the Portal, reusing the existing PKCE start_login/complete_login provider path unchanged. Server (Ben's dashboard-auth lane): - native_flow.py: in-memory broker — binds the desktop's PKCE challenge to a completed Session, mints a single-use, short-TTL, PKCE-verified gateway authorization code. Constant-time compare, single-use (consumed before the PKCE check so a wrong verifier can't be retried), capacity-bounded. - routes.py: GET /auth/native/authorize (starts the brokered PKCE login, loopback-only redirect_uri, S256-only), POST /auth/native/token (loopback code + verifier -> tokens in the JSON body, never Set-Cookie), POST /auth/native/refresh (desktop-held RT rotation). /auth/callback branches to mint a loopback code + 302 to 127.0.0.1 when a broker_state rides the PKCE cookie; the cookie/SPA path is untouched. - middleware.py: the gate accepts Authorization: Bearer <access_token>, verified via the same verify_session provider stack (no cookie set/read), with the same "provider unreachable -> 503, not logout" semantics. - web_server.py /api/status: advertise auth_flows (["cookie","native_pkce"]) so clients can detect the capability; native_pkce only when a brokerable OAuth provider is registered. Desktop (Ben's lane): - native-oauth.ts: pure PKCE/capability/URL/callback/token helpers. - native-oauth-login.ts: loopback-listener orchestration (system browser via openExternal, ephemeral 127.0.0.1 listener, state/PKCE verification), all I/O injected for testability. - main.ts: capability-gated oauth-login IPC — native flow when advertised, automatic fallback to the existing embedded-webview cookie flow otherwise; tokens stored encrypted (safeStorage/OS keychain), REST + ws-ticket authenticated by bearer, transparent refresh, logout clears both shapes. Tests: 18 server pytest (broker unit + full authorize->callback->token E2E + cookieless bearer auth of a gated route + ws-ticket mint + capability advertisement + refresh); desktop node --test/vitest for both pure modules (PKCE, capability detection, callback CSRF, loopback round trip, timeout, browser-open failure). Electron project typechecks clean. Docs: website/docs/guides/desktop-native-signin.md. |
||
|---|---|---|
| .. | ||
| api.test.ts | ||
| api.ts | ||
| chat-activation.test.ts | ||
| chat-activation.ts | ||
| chat-sidebar-session-params.test.ts | ||
| chat-title.test.ts | ||
| chat-title.ts | ||
| chatImagePaste.test.ts | ||
| chatImagePaste.ts | ||
| clipboard.test.ts | ||
| clipboard.ts | ||
| cron-job.test.ts | ||
| cron-job.ts | ||
| dashboard-flags.ts | ||
| dashboard-modal-shell.test.ts | ||
| dashboard-modal-shell.ts | ||
| format.ts | ||
| fuzzy.ts | ||
| gatewayClient.ts | ||
| mcp-dashboard-oauth.test.ts | ||
| mcp-dashboard-oauth.ts | ||
| mcp-server-create.test.ts | ||
| mcp-server-create.ts | ||
| model-picker-filter.test.ts | ||
| model-picker-filter.ts | ||
| nested.ts | ||
| pty-mobile-input.test.ts | ||
| pty-mobile-input.ts | ||
| pty-reconnect.test.ts | ||
| pty-reconnect.ts | ||
| reasoning-effort.test.ts | ||
| reasoning-effort.ts | ||
| resolve-page-title.ts | ||
| schedule.test.ts | ||
| schedule.ts | ||
| session-import.test.ts | ||
| session-import.ts | ||
| session-refresh.test.ts | ||
| session-refresh.ts | ||
| slashExec.ts | ||
| utils.ts | ||