mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-04-30 01:41:43 +00:00
14dd8e9a72
- resolveEditor() now returns argv (string[]) so EDITOR='code --wait' and VISUAL='emacsclient -t' tokenize correctly into spawnSync's separate command + args. Previously the whole string was passed as argv[0] and would ENOENT. - Skip the POSIX X_OK PATH walk on Windows; return ['notepad.exe'] there since fs.constants.X_OK is not meaningful and PATHEXT-based resolution would need its own implementation. - Surface openEditor() rejections via actions.sys instead of letting them become unhandled promise rejections in the useInput callback. - Hotkey docs/comment now say Cmd/Ctrl+G to match isAction()'s platform-action-modifier behavior (Cmd on macOS, Ctrl elsewhere).
74 lines
2.2 KiB
TypeScript
74 lines
2.2 KiB
TypeScript
import { chmodSync, mkdtempSync, writeFileSync } from 'node:fs'
|
|
import { tmpdir } from 'node:os'
|
|
import { delimiter, join } from 'node:path'
|
|
|
|
import { beforeEach, describe, expect, it } from 'vitest'
|
|
|
|
import { resolveEditor } from './editor.js'
|
|
|
|
const exe = (dir: string, name: string): string => {
|
|
const path = join(dir, name)
|
|
|
|
writeFileSync(path, '#!/bin/sh\nexit 0\n')
|
|
chmodSync(path, 0o755)
|
|
|
|
return path
|
|
}
|
|
|
|
describe('resolveEditor', () => {
|
|
let dir: string
|
|
|
|
beforeEach(() => {
|
|
dir = mkdtempSync(join(tmpdir(), 'editor-test-'))
|
|
})
|
|
|
|
it('honors $VISUAL above all else', () => {
|
|
expect(resolveEditor({ EDITOR: 'vim', PATH: dir, VISUAL: 'helix' })).toEqual(['helix'])
|
|
})
|
|
|
|
it('falls back to $EDITOR when $VISUAL is unset', () => {
|
|
expect(resolveEditor({ EDITOR: 'nvim', PATH: dir })).toEqual(['nvim'])
|
|
})
|
|
|
|
it('shell-tokenizes editors with arguments', () => {
|
|
expect(resolveEditor({ EDITOR: 'code --wait', PATH: dir })).toEqual(['code', '--wait'])
|
|
expect(resolveEditor({ PATH: dir, VISUAL: 'emacsclient -t' })).toEqual(['emacsclient', '-t'])
|
|
})
|
|
|
|
it('ignores whitespace-only env vars', () => {
|
|
const expected = exe(dir, 'editor')
|
|
|
|
expect(resolveEditor({ EDITOR: ' ', PATH: dir, VISUAL: '' })).toEqual([expected])
|
|
})
|
|
|
|
it('prefers `editor` over nano over vi on $PATH', () => {
|
|
exe(dir, 'nano')
|
|
exe(dir, 'vi')
|
|
const expected = exe(dir, 'editor')
|
|
|
|
expect(resolveEditor({ PATH: dir })).toEqual([expected])
|
|
})
|
|
|
|
it('falls back to nano before vi when both exist', () => {
|
|
exe(dir, 'vi')
|
|
const expected = exe(dir, 'nano')
|
|
|
|
expect(resolveEditor({ PATH: dir })).toEqual([expected])
|
|
})
|
|
|
|
it('returns ["vi"] when $PATH is empty', () => {
|
|
expect(resolveEditor({ PATH: '' })).toEqual(['vi'])
|
|
})
|
|
|
|
it('walks multi-entry $PATH', () => {
|
|
const a = mkdtempSync(join(tmpdir(), 'editor-a-'))
|
|
const b = mkdtempSync(join(tmpdir(), 'editor-b-'))
|
|
const expected = exe(b, 'editor')
|
|
|
|
expect(resolveEditor({ PATH: [a, b].join(delimiter) })).toEqual([expected])
|
|
})
|
|
|
|
it('uses notepad.exe on Windows when no env override', () => {
|
|
expect(resolveEditor({ PATH: dir }, 'win32')).toEqual(['notepad.exe'])
|
|
})
|
|
})
|