mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-27 17:58:07 +00:00
Widen the cherry-picked /diff base (#4839 by @SHL0MS) into one cross-surface implementation, folding in the review feedback and the best ideas from the two sibling PRs (#22703, #53527): - tools/working_diff.py: shared git collection layer — unstaged (default), staged, and all (vs HEAD) modes; untracked files folded in via `git diff --no-index` so new files appear as additions (Codex /diff parity); shlex-split arguments preserve quoted paths. - CLI: handler moved to hermes_cli/cli_commands_mixin.py per the current god-file decomposition (dispatch stays in cli.py), renders through the rich console with a 400-line terminal-flood guard. - Gateway: _handle_diff_command in gateway/slash_commands.py + dispatch in gateway/run.py; fenced ```diff output truncated to 60 lines / 3000 chars before the platform senders apply their own per-platform message clamps (tool-progress-style layered truncation). Localized strings in all 17 locale catalogs. - /diff session (from #53527): cumulative checkpoint-baseline diff of everything Hermes changed, via new CheckpointManager.session_diff(); docstring records the retained-baseline approximation caveat from review. Works on both surfaces; degrades with an actionable message when checkpoints are off. - Slack: /diff routed via /hermes diff (50-slash cap; keeps telegram-parity test green and /version native). - Registry: cross-surface CommandDef with staged|all|session subcommands; docs: slash-commands reference (CLI + gateway tables + both-surfaces list) and hermes-agent skill reference. - Tests: tests/tools/test_working_diff.py (real git repos), tests/hermes_cli/test_diff_command.py (real git + stubbed checkpoint manager), tests/gateway/test_diff_command.py (end-to-end handler, real checkpoint store), TestSessionDiff in tests/tools/test_checkpoint_manager.py. Salvaged from the /diff PR cluster #4839 + #22703 + #53527. Co-authored-by: Ninso112 <ninso112@proton.me> Co-authored-by: Harshkamdar67 <harshkamdar67@gmail.com>
130 lines
4.6 KiB
Python
130 lines
4.6 KiB
Python
"""Working-tree git diff collection shared by the CLI and gateway ``/diff``.
|
|
|
|
The ``/diff`` slash command answers "what changed here?" on every surface.
|
|
This module holds the surface-agnostic collection logic so the CLI (colored
|
|
terminal output) and the gateway (fenced, truncated messages) render the same
|
|
underlying data.
|
|
|
|
Modes
|
|
-----
|
|
- ``working`` (default): unstaged changes plus untracked files — what you'd
|
|
lose with ``git checkout . && git clean -fd``.
|
|
- ``staged``: changes already staged for commit (``git diff --cached``).
|
|
- ``all``: everything since HEAD (staged + unstaged) plus untracked files.
|
|
|
|
Untracked files are folded in via ``git diff --no-index /dev/null <file>`` so
|
|
brand-new files show up as additions instead of being silently invisible
|
|
(mirrors Codex CLI's ``/diff`` behaviour).
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import os
|
|
import shutil
|
|
import subprocess
|
|
from typing import Dict, List
|
|
|
|
_GIT_TIMEOUT = 15
|
|
_MAX_UNTRACKED_FILES = 50 # sanity cap so a node_modules explosion can't hang us
|
|
|
|
VALID_MODES = ("working", "staged", "all")
|
|
|
|
|
|
def _run(args: List[str], cwd: str, timeout: int = _GIT_TIMEOUT):
|
|
"""Run git, returning (returncode, stdout). Never raises on git failure."""
|
|
proc = subprocess.run(
|
|
["git", "-c", "core.quotePath=false", *args],
|
|
cwd=cwd, capture_output=True, text=True, timeout=timeout,
|
|
)
|
|
return proc.returncode, proc.stdout
|
|
|
|
|
|
def _untracked_files(cwd: str) -> List[str]:
|
|
code, out = _run(["ls-files", "--others", "--exclude-standard"], cwd)
|
|
if code != 0:
|
|
return []
|
|
return [line for line in out.splitlines() if line.strip()]
|
|
|
|
|
|
def _untracked_diff(cwd: str, files: List[str]) -> str:
|
|
"""Render untracked files as new-file diffs via ``git diff --no-index``."""
|
|
chunks: List[str] = []
|
|
for rel in files[:_MAX_UNTRACKED_FILES]:
|
|
try:
|
|
# --no-index exits 1 when the files differ — that's the success
|
|
# path here, so ignore the return code and keep the output.
|
|
_, out = _run(
|
|
["diff", "--no-index", "--", os.devnull, rel], cwd,
|
|
)
|
|
if out.strip():
|
|
chunks.append(out.rstrip("\n"))
|
|
except (subprocess.TimeoutExpired, OSError):
|
|
continue
|
|
if len(files) > _MAX_UNTRACKED_FILES:
|
|
chunks.append(
|
|
f"... ({len(files) - _MAX_UNTRACKED_FILES} more untracked files not shown)"
|
|
)
|
|
return "\n".join(chunks)
|
|
|
|
|
|
def collect_working_diff(cwd: str, mode: str = "working",
|
|
paths: List[str] | None = None) -> Dict:
|
|
"""Collect a git diff of the working directory.
|
|
|
|
Returns ``{"success", "stat", "diff", "untracked", "empty"}`` on success or
|
|
``{"success": False, "error": ...}`` when git is unavailable / not a repo.
|
|
``paths`` optionally restricts the diff to specific pathspecs (passed
|
|
through to git verbatim, so quoted paths with spaces survive).
|
|
"""
|
|
if mode not in VALID_MODES:
|
|
return {"success": False,
|
|
"error": f"Unknown mode '{mode}'. Use: {', '.join(VALID_MODES)}"}
|
|
|
|
if not shutil.which("git"):
|
|
return {"success": False, "error": "git is not installed or not on PATH."}
|
|
|
|
try:
|
|
code, _ = _run(["rev-parse", "--is-inside-work-tree"], cwd, timeout=5)
|
|
except (subprocess.TimeoutExpired, OSError) as e:
|
|
return {"success": False, "error": f"git failed: {e}"}
|
|
if code != 0:
|
|
return {"success": False, "error": "Not a git repository."}
|
|
|
|
if mode == "staged":
|
|
base_args = ["diff", "--cached"]
|
|
elif mode == "all":
|
|
base_args = ["diff", "HEAD"]
|
|
else: # working
|
|
base_args = ["diff"]
|
|
|
|
pathspec = ["--", *paths] if paths else []
|
|
|
|
try:
|
|
_, stat_out = _run([*base_args, "--stat", *pathspec], cwd)
|
|
_, diff_out = _run([*base_args, *pathspec], cwd, timeout=_GIT_TIMEOUT * 2)
|
|
|
|
untracked: List[str] = []
|
|
untracked_diff = ""
|
|
if mode in ("working", "all") and not paths:
|
|
untracked = _untracked_files(cwd)
|
|
if untracked:
|
|
untracked_diff = _untracked_diff(cwd, untracked)
|
|
except subprocess.TimeoutExpired:
|
|
return {"success": False, "error": "git diff timed out."}
|
|
except OSError as e:
|
|
return {"success": False, "error": f"git failed: {e}"}
|
|
|
|
stat = stat_out.strip()
|
|
diff = diff_out.strip()
|
|
if untracked_diff:
|
|
diff = f"{diff}\n{untracked_diff}".strip()
|
|
|
|
result = {
|
|
"success": True,
|
|
"stat": stat,
|
|
"diff": diff,
|
|
"untracked": untracked,
|
|
}
|
|
if not stat and not diff and not untracked:
|
|
result["empty"] = True
|
|
return result
|