mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-30 19:09:28 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
32 lines
1.6 KiB
Python
32 lines
1.6 KiB
Python
from unittest.mock import patch
|
|
|
|
from tools.environments.local import LocalEnvironment
|
|
|
|
|
|
class TestLocalTempDir:
|
|
def test_uses_os_tmpdir_for_session_artifacts(self, monkeypatch):
|
|
monkeypatch.setenv("TMPDIR", "/data/data/com.termux/files/usr/tmp")
|
|
monkeypatch.delenv("TMP", raising=False)
|
|
monkeypatch.delenv("TEMP", raising=False)
|
|
|
|
with patch.object(LocalEnvironment, "init_session", autospec=True, return_value=None):
|
|
env = LocalEnvironment(cwd=".", timeout=10)
|
|
|
|
assert env.get_temp_dir() == "/data/data/com.termux/files/usr/tmp"
|
|
assert env._snapshot_path == f"/data/data/com.termux/files/usr/tmp/hermes-snap-{env._session_id}.sh"
|
|
assert env._cwd_file == f"/data/data/com.termux/files/usr/tmp/hermes-cwd-{env._session_id}.txt"
|
|
|
|
|
|
def test_falls_back_to_tempfile_when_tmp_missing(self, monkeypatch):
|
|
monkeypatch.delenv("TMPDIR", raising=False)
|
|
monkeypatch.delenv("TMP", raising=False)
|
|
monkeypatch.delenv("TEMP", raising=False)
|
|
|
|
with patch("tools.environments.local.os.path.isdir", return_value=False), \
|
|
patch("tools.environments.local.os.access", return_value=False), \
|
|
patch("tools.environments.local.tempfile.gettempdir", return_value="/cache/tmp"), \
|
|
patch.object(LocalEnvironment, "init_session", autospec=True, return_value=None):
|
|
env = LocalEnvironment(cwd=".", timeout=10)
|
|
assert env.get_temp_dir() == "/cache/tmp"
|
|
assert env._snapshot_path == f"/cache/tmp/hermes-snap-{env._session_id}.sh"
|
|
assert env._cwd_file == f"/cache/tmp/hermes-cwd-{env._session_id}.txt"
|