mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
65 lines
2.3 KiB
Python
65 lines
2.3 KiB
Python
"""Regression: empty-body HTTP 4xx errors must still surface a real provider message.
|
|
|
|
Reported on Windows (#36109): an LLM API call returned HTTP 400 with an *empty*
|
|
parsed SDK ``body`` ({}), so ``_summarize_api_error`` fell through to the bare
|
|
``str(error)`` path and the user saw only "HTTP 400" with no provider detail.
|
|
The SDK leaves ``body`` empty in this case, but the underlying httpx
|
|
``response`` still carries the real payload in ``.text``. These tests lock the
|
|
contract: when ``body`` is empty, fall back to ``response.text`` (parsing a JSON
|
|
``error.message`` / ``message`` when present) so logs and CLI show the real
|
|
provider error. This is a diagnostic improvement and is platform-agnostic.
|
|
"""
|
|
|
|
from types import SimpleNamespace
|
|
from typing import Any
|
|
|
|
import httpx
|
|
|
|
from run_agent import AIAgent
|
|
|
|
|
|
def _make_empty_body_error(response_text: str, status_code: int = 400) -> Exception:
|
|
"""Mimic an OpenAI-SDK error whose parsed body is empty but whose httpx
|
|
response still holds the payload text."""
|
|
err = Exception("") # str(error) is empty/uninformative on this path
|
|
err.status_code = status_code
|
|
err.body = {} # empty dict — the #36109 trigger
|
|
err.response = SimpleNamespace(text=response_text)
|
|
return err
|
|
|
|
|
|
def test_empty_body_falls_back_to_response_json_error_message():
|
|
"""A JSON payload with error.message is surfaced (not a bare HTTP 400)."""
|
|
err = _make_empty_body_error(
|
|
'{"error": {"message": "model `foo` does not exist", "type": "invalid_request_error"}}'
|
|
)
|
|
summary = AIAgent._summarize_api_error(err)
|
|
assert "HTTP 400" in summary
|
|
assert "model `foo` does not exist" in summary
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_unread_streaming_response_does_not_crash_and_falls_back_to_exception_message():
|
|
"""Unread streaming responses must not replace the real provider error."""
|
|
|
|
class _StreamingError(Exception):
|
|
def __init__(self):
|
|
super().__init__("Gemini HTTP 429: quota exceeded")
|
|
self.status_code = 429
|
|
self.response: Any = None
|
|
|
|
err = _StreamingError()
|
|
|
|
class _UnreadStreamingResponse:
|
|
@property
|
|
def text(self):
|
|
raise httpx.ResponseNotRead()
|
|
|
|
err.response = _UnreadStreamingResponse()
|
|
summary = AIAgent._summarize_api_error(err)
|
|
assert "HTTP 429" in summary
|
|
assert "Gemini HTTP 429: quota exceeded" in summary
|
|
|