hermes-agent/tests/run_agent/test_preflight_compression_cap_e2e.py
Teknium 6b81590c55
test: prune low-value tests suite-wide (wave 1) — 46,820 → 28,106 test functions
Systematic prune per AGENTS.md test policy, one pass over every major
test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli,
cron, tui_gateway, honcho/openviking, root-level):

- DELETE: source-reading tests (read_text/getsource on prod files),
  change-detector tests (exact catalog counts, model-name snapshots,
  config version literals), mock-echo tests (assert a mock returns what
  it was told), assertion-free/trivial tests, near-duplicate
  parametrizations (boundaries + one representative kept), async/sync
  twin duplicates, cosmetic within-file variations.
- KEEP (mandatory): security/redaction/approval guards, message-role
  alternation invariants, prompt-caching/deterministic-call-id
  invariants, issue-number regression tests (deduped), E2E tests.
- 6 test files deleted outright (script-style/no-assert or fully
  redundant); conftest.py, fakes/, fixtures/ untouched.
- tests/acp/conftest.py added: autouse fixture stubs the live
  models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server
  tests performed on every session create — test_server.py 147s → 3.4s,
  and the tests are now genuinely hermetic.
- Sleep-based slowness shrunk where safe (codex_ttfb_watchdog,
  compression_concurrent_fork, etc.); no wall-clock assertion tightened.

Verification: full hermetic suite via scripts/run_tests.sh —
2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall
(baseline: 583s wall, 13,564s subprocess CPU).
2026-07-29 13:10:23 -07:00

144 lines
4.9 KiB
Python

"""E2E: compression.max_attempts=6 drives a 4th+ preflight compaction pass.
The turn-start preflight loop in ``agent/turn_context.py`` was hardcoded to
``range(3)``: even when every pass made real progress and the request stayed
over threshold, the 4th pass never ran, regardless of configuration. The
loop now sizes itself from the same resolved ``compression.max_attempts`` cap
as the conversation loop's compression sites.
This test builds a real ``AIAgent`` from a config with
``compression.max_attempts: 6`` (the config-driven path through
``agent_init``), then drives a full ``run_conversation()`` turn in which the
estimated request size keeps shrinking ~10% per compaction but stays above
threshold — the exact "progress, but not enough yet" shape that legitimately
needs more than three rounds. With cap=6 the preflight must run a 4th pass
(and ultimately all six).
"""
from __future__ import annotations
import contextlib
import io
from pathlib import Path
from types import SimpleNamespace
from unittest.mock import MagicMock, patch
from hermes_state import SessionDB
from run_agent import AIAgent
def _config(max_attempts) -> dict:
return {
"compression": {
"enabled": True,
"threshold": 0.50,
"target_ratio": 0.20,
"protect_first_n": 3,
"protect_last_n": 20,
"max_attempts": max_attempts,
},
"prompt_caching": {"cache_ttl": "5m"},
"sessions": {},
"bedrock": {},
}
def _stop_response():
msg = SimpleNamespace(
content="done",
reasoning_content=None,
reasoning=None,
tool_calls=None,
)
choice = SimpleNamespace(message=msg, finish_reason="stop")
return SimpleNamespace(choices=[choice], model="test/model", usage=None)
def _make_agent(monkeypatch, tmp_path: Path, *, max_attempts) -> AIAgent:
from hermes_cli import config as config_mod
monkeypatch.setattr(
config_mod, "load_config", lambda: _config(max_attempts)
)
db = SessionDB(db_path=tmp_path / "state.db")
with (
contextlib.redirect_stdout(io.StringIO()),
patch("run_agent.get_tool_definitions", return_value=[]),
patch("run_agent.check_toolset_requirements", return_value={}),
patch("run_agent.OpenAI"),
):
agent = AIAgent(
base_url="https://openrouter.ai/api/v1",
api_key="test-key",
model="test/model",
enabled_toolsets=[],
disabled_toolsets=[],
quiet_mode=True,
skip_memory=True,
skip_context_files=True,
session_db=db,
session_id="preflight-cap-e2e",
)
agent.client = MagicMock()
agent._cached_system_prompt = "You are helpful."
agent._use_prompt_caching = False
agent._disable_streaming = True
agent.tool_delay = 0
agent.save_trajectories = False
return agent
def test_preflight_runs_fourth_compaction_pass_at_cap_six(monkeypatch, tmp_path):
agent = _make_agent(monkeypatch, tmp_path, max_attempts=6)
# Config-driven attach seam (agent_init) resolved the raised cap.
assert agent.max_compression_attempts == 6
# Keep the request permanently over threshold while every compaction
# makes material (~10% > the 5% progress floor) headway.
compressor = agent.context_compressor
compressor.threshold_tokens = 50_000
estimate_state = {"tokens": 1_000_000.0, "calls": 0}
def _shrinking_estimate(*_args, **_kwargs):
if estimate_state["calls"]:
estimate_state["tokens"] *= 0.9
estimate_state["calls"] += 1
return int(estimate_state["tokens"])
compress_calls = []
def _fake_compress(messages, system_message, **_kwargs):
compress_calls.append(len(messages))
return messages, "compressed prompt"
# 60 messages > protect_first_n + protect_last_n + 1, so the cheap
# preflight count gate opens without patching internals.
history = [
{"role": "user" if i % 2 == 0 else "assistant", "content": f"msg {i}"}
for i in range(60)
]
agent.client.chat.completions.create.return_value = _stop_response()
with (
patch(
"agent.turn_context.estimate_request_tokens_rough",
side_effect=_shrinking_estimate,
),
patch.object(agent, "_compress_context", side_effect=_fake_compress),
patch.object(agent, "_persist_session"),
patch.object(agent, "_save_trajectory"),
patch.object(agent, "_cleanup_task_resources"),
):
result = agent.run_conversation("hello", conversation_history=history)
assert result["completed"] is True
# The old hardcoded range(3) made a 4th pass impossible; cap=6 must
# deliver it (and, with steady progress over threshold, all six).
assert len(compress_calls) >= 4, (
f"expected a 4th preflight compaction pass at cap=6, "
f"got {len(compress_calls)} passes"
)
assert len(compress_calls) == 6