mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
47 lines
1.4 KiB
Python
47 lines
1.4 KiB
Python
"""Tests for agent.api_max_retries config surface.
|
|
|
|
Closes #11616 — make the hardcoded ``max_retries = 3`` in the agent's API
|
|
retry loop user-configurable so fallback-provider setups can fail over
|
|
faster on flaky primaries instead of burning ~3x180s on the same stall.
|
|
"""
|
|
from unittest.mock import patch
|
|
|
|
from run_agent import AIAgent
|
|
|
|
|
|
def _make_agent(api_max_retries=None):
|
|
"""Build an AIAgent with a mocked config.load_config that returns a
|
|
config tree containing the given agent.api_max_retries (or default)."""
|
|
cfg = {"agent": {}}
|
|
if api_max_retries is not None:
|
|
cfg["agent"]["api_max_retries"] = api_max_retries
|
|
|
|
with patch("run_agent.OpenAI"), \
|
|
patch("hermes_cli.config.load_config", return_value=cfg):
|
|
return AIAgent(
|
|
api_key="test-key",
|
|
base_url="https://openrouter.ai/api/v1",
|
|
model="test/model",
|
|
quiet_mode=True,
|
|
skip_context_files=True,
|
|
skip_memory=True,
|
|
)
|
|
|
|
|
|
def test_default_api_max_retries_is_three():
|
|
"""No config override → legacy default of 3 retries preserved."""
|
|
agent = _make_agent()
|
|
assert agent._api_max_retries == 3
|
|
|
|
|
|
def test_api_max_retries_honors_config_override():
|
|
"""Setting agent.api_max_retries in config propagates to the agent."""
|
|
agent = _make_agent(api_max_retries=1)
|
|
assert agent._api_max_retries == 1
|
|
|
|
agent2 = _make_agent(api_max_retries=5)
|
|
assert agent2._api_max_retries == 5
|
|
|
|
|
|
|
|
|