mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-30 19:09:28 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
76 lines
2.8 KiB
Python
76 lines
2.8 KiB
Python
"""Tests for the startup security posture audit (hermes_cli.security_audit_startup)."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import os
|
|
from pathlib import Path
|
|
|
|
import pytest
|
|
|
|
import hermes_cli.security_audit_startup as audit
|
|
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def _reset_audit_sentinel():
|
|
audit._AUDIT_RAN = False
|
|
yield
|
|
audit._AUDIT_RAN = False
|
|
|
|
|
|
# ── root check ────────────────────────────────────────────────────────────
|
|
|
|
|
|
|
|
|
|
# ── SSH password-auth check ─────────────────────────────────────────────────
|
|
|
|
|
|
# ── container / volume-mount check ──────────────────────────────────────────
|
|
|
|
|
|
|
|
|
|
|
|
|
|
# ── network listener without auth ──────────────────────────────────────────
|
|
|
|
|
|
|
|
|
|
# ── orchestration + logging ─────────────────────────────────────────────────
|
|
|
|
|
|
def test_run_security_audit_aggregates(monkeypatch, tmp_path):
|
|
monkeypatch.setattr(audit, "_is_root", lambda: True)
|
|
monkeypatch.setattr(audit, "_iter_sshd_config_lines", lambda: ["PasswordAuthentication yes"])
|
|
monkeypatch.setattr(audit, "_in_container", lambda: False)
|
|
findings = audit.run_security_audit(hermes_home=tmp_path, config={})
|
|
assert len(findings) == 2 # root + ssh
|
|
|
|
|
|
def test_run_security_audit_clean_posture(monkeypatch, tmp_path):
|
|
monkeypatch.setattr(audit, "_is_root", lambda: False)
|
|
monkeypatch.setattr(audit, "_iter_sshd_config_lines", lambda: ["PasswordAuthentication no"])
|
|
monkeypatch.setattr(audit, "_in_container", lambda: False)
|
|
assert audit.run_security_audit(hermes_home=tmp_path, config={}) == []
|
|
|
|
|
|
def test_log_startup_security_warnings_emits_and_is_idempotent(monkeypatch, tmp_path, caplog):
|
|
import logging
|
|
|
|
monkeypatch.setattr(audit, "_is_root", lambda: True)
|
|
monkeypatch.setattr(audit, "_iter_sshd_config_lines", lambda: [])
|
|
monkeypatch.setattr(audit, "_in_container", lambda: False)
|
|
|
|
with caplog.at_level(logging.WARNING, logger="hermes.security_audit"):
|
|
first = audit.log_startup_security_warnings(hermes_home=tmp_path, config={})
|
|
assert len(first) == 1
|
|
assert any("ROOT" in r.message for r in caplog.records)
|
|
|
|
# Second call is a no-op (idempotent within a process) unless forced.
|
|
second = audit.log_startup_security_warnings(hermes_home=tmp_path, config={})
|
|
assert second == []
|
|
forced = audit.log_startup_security_warnings(hermes_home=tmp_path, config={}, force=True)
|
|
assert len(forced) == 1
|
|
|
|
|