mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
37 lines
1.3 KiB
Python
37 lines
1.3 KiB
Python
"""Coverage for _run_with_idle_timeout — the streaming subprocess helper.
|
|
|
|
Kept in a dedicated test file because the tests spawn real ``subprocess.Popen``
|
|
instances; pytest-isolate runs each test file in its own worker process, so
|
|
isolating these here prevents real-Popen state from racing with the
|
|
``subprocess.run`` / ``_run_with_idle_timeout`` patches used by
|
|
``test_web_ui_build.py``.
|
|
|
|
Added for issue #33788: ``hermes update`` got stuck at "webui-build" because
|
|
``npm run build`` ran with ``capture_output=True`` and no timeout. The helper
|
|
fixes both halves — streams output AND idle-kills the process.
|
|
"""
|
|
|
|
import sys as _sys
|
|
import time
|
|
|
|
from hermes_cli.main import _run_with_idle_timeout
|
|
|
|
|
|
def test_streams_output_and_returns_zero_on_success(tmp_path):
|
|
script = tmp_path / "ok.py"
|
|
script.write_text("print('line one'); print('line two')\n")
|
|
result = _run_with_idle_timeout(
|
|
[_sys.executable, str(script)], cwd=tmp_path, idle_timeout_seconds=10
|
|
)
|
|
assert result.returncode == 0
|
|
assert "line one" in result.stdout
|
|
assert "line two" in result.stdout
|
|
|
|
|
|
def test_returns_127_when_binary_missing(tmp_path):
|
|
result = _run_with_idle_timeout(
|
|
["/nonexistent/binary/does/not/exist"],
|
|
cwd=tmp_path,
|
|
idle_timeout_seconds=5,
|
|
)
|
|
assert result.returncode == 127
|