mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-30 19:09:28 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
108 lines
3.5 KiB
Python
108 lines
3.5 KiB
Python
"""Tests for ``_prompt_api_key`` — the shared Keep/Replace/Clear menu used by
|
|
``hermes setup`` / ``hermes model`` when an API key already exists in ``.env``.
|
|
|
|
Regression coverage for #16394: the wizard used to silently skip the key prompt
|
|
when any value was present (even malformed junk), leaving users stuck.
|
|
"""
|
|
from __future__ import annotations
|
|
|
|
from pathlib import Path
|
|
from unittest.mock import patch
|
|
|
|
import pytest
|
|
|
|
|
|
@pytest.fixture
|
|
def profile_env(tmp_path, monkeypatch):
|
|
home = tmp_path / ".hermes"
|
|
home.mkdir()
|
|
monkeypatch.setattr(Path, "home", lambda: tmp_path)
|
|
monkeypatch.setenv("HERMES_HOME", str(home))
|
|
(home / ".env").write_text("")
|
|
return home
|
|
|
|
|
|
def _pconfig(name="deepseek"):
|
|
from hermes_cli.auth import PROVIDER_REGISTRY
|
|
return PROVIDER_REGISTRY[name]
|
|
|
|
|
|
def _run_prompt(existing_key, choice, new_key="", provider_id="", pconfig_name="deepseek"):
|
|
"""Invoke _prompt_api_key with mocked input()/getpass() responses."""
|
|
from hermes_cli import main as m
|
|
|
|
pconfig = _pconfig(pconfig_name)
|
|
with patch("builtins.input", return_value=choice), \
|
|
patch("hermes_cli.secret_prompt.masked_secret_prompt", return_value=new_key):
|
|
return m._prompt_api_key(pconfig, existing_key, provider_id=provider_id)
|
|
|
|
|
|
def test_pool_only_key_does_not_offer_or_execute_clear(profile_env, monkeypatch, capsys):
|
|
from hermes_cli import main as m
|
|
|
|
pconfig = _pconfig("deepseek")
|
|
prompts = []
|
|
|
|
def choose_clear(prompt):
|
|
prompts.append(prompt)
|
|
return "c"
|
|
|
|
monkeypatch.setattr("builtins.input", choose_clear)
|
|
with patch("hermes_cli.config.save_env_value") as save_env:
|
|
key, abort = m._prompt_api_key(
|
|
pconfig,
|
|
"pool-secret",
|
|
provider_id="deepseek",
|
|
existing_source="credential_pool:deepseek",
|
|
)
|
|
|
|
assert key == "pool-secret"
|
|
assert abort is False
|
|
assert prompts and "[C]lear" not in prompts[0]
|
|
assert "[K]eep / [R]eplace" in prompts[0]
|
|
save_env.assert_not_called()
|
|
assert "API key cleared" not in capsys.readouterr().out
|
|
|
|
|
|
# First-time entry ────────────────────────────────────────────────────────────
|
|
|
|
|
|
|
|
# Already configured — K / R / C ───────────────────────────────────────────────
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_clear_wipes_env_and_aborts(profile_env):
|
|
from hermes_cli.config import get_env_value, save_env_value
|
|
save_env_value("DEEPSEEK_API_KEY", "sk-existing")
|
|
save_env_value("OTHER_VAR", "keep-me")
|
|
|
|
key, abort = _run_prompt(existing_key="sk-existing", choice="c")
|
|
assert key == ""
|
|
assert abort is True
|
|
# Cleared, but sibling entries untouched.
|
|
assert not get_env_value("DEEPSEEK_API_KEY")
|
|
assert get_env_value("OTHER_VAR") == "keep-me"
|
|
|
|
|
|
|
|
|
|
# LM Studio no-auth placeholder ────────────────────────────────────────────────
|
|
|
|
def test_lmstudio_first_time_empty_uses_placeholder(profile_env):
|
|
from hermes_cli.auth import LMSTUDIO_NOAUTH_PLACEHOLDER
|
|
from hermes_cli.config import get_env_value
|
|
|
|
key, abort = _run_prompt(
|
|
existing_key="", choice="", new_key="",
|
|
provider_id="lmstudio", pconfig_name="lmstudio",
|
|
)
|
|
assert key == LMSTUDIO_NOAUTH_PLACEHOLDER
|
|
assert abort is False
|
|
assert get_env_value("LM_API_KEY") == LMSTUDIO_NOAUTH_PLACEHOLDER
|
|
|
|
|