mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-30 19:09:28 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
57 lines
1.9 KiB
Python
57 lines
1.9 KiB
Python
"""Tests for `hermes memory status` CLI command.
|
|
|
|
Covers:
|
|
- Status output shows config-aware indicators instead of hardcoded 'always active'
|
|
- memory_enabled, user_profile_enabled, and memory tool are each reflected
|
|
- Memory tool resolution uses the canonical _get_platform_tools resolver
|
|
- Original issue: 'Built-in: always active' was misleading when features were disabled
|
|
"""
|
|
|
|
import pytest
|
|
from unittest.mock import patch
|
|
|
|
|
|
def _run_cmd_status(capfd, mem_config=None, memory_tools=None):
|
|
"""Run cmd_status with a mocked config and return captured stdout.
|
|
|
|
Args:
|
|
mem_config: The "memory" section of config.
|
|
memory_tools: Set of tool names returned by _get_platform_tools.
|
|
Defaults to {"memory"} (tool enabled).
|
|
"""
|
|
from hermes_cli.memory_setup import cmd_status
|
|
|
|
config = {"memory": mem_config or {}}
|
|
if memory_tools is None:
|
|
memory_tools = {"memory"}
|
|
|
|
with patch("hermes_cli.config.load_config", return_value=config):
|
|
with patch("hermes_cli.memory_setup._get_available_providers", return_value=[]):
|
|
with patch(
|
|
"hermes_cli.tools_config._get_platform_tools",
|
|
return_value=memory_tools,
|
|
):
|
|
cmd_status(args=None)
|
|
|
|
captured = capfd.readouterr()
|
|
return captured.out
|
|
|
|
|
|
class TestMemoryStatusLabels:
|
|
"""Status output should reflect actual config, not a hardcoded string."""
|
|
|
|
|
|
def test_shows_memory_injection_enabled_by_default(self, capfd):
|
|
"""Memory injection defaults to enabled."""
|
|
out = _run_cmd_status(capfd)
|
|
assert "Memory injection:" in out
|
|
assert "enabled ✓" in out
|
|
|
|
def test_shows_memory_injection_disabled(self, capfd):
|
|
"""When memory_enabled is false, status reflects it."""
|
|
out = _run_cmd_status(capfd, mem_config={"memory_enabled": False})
|
|
assert "Memory injection:" in out
|
|
assert "disabled ✗" in out
|
|
|
|
|
|
|