mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-30 19:09:28 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
67 lines
1.9 KiB
Python
67 lines
1.9 KiB
Python
"""Tests for explicit ownership by a wrapped external gateway supervisor."""
|
|
|
|
from types import SimpleNamespace
|
|
|
|
import pytest
|
|
|
|
import hermes_cli.gateway as gateway
|
|
|
|
|
|
def _clear_native_supervisor_markers(monkeypatch):
|
|
monkeypatch.delenv("INVOCATION_ID", raising=False)
|
|
monkeypatch.delenv("HERMES_S6_SUPERVISED_CHILD", raising=False)
|
|
monkeypatch.setenv("XPC_SERVICE_NAME", "0")
|
|
|
|
|
|
def test_external_marker_identifies_supervisor_process(monkeypatch):
|
|
_clear_native_supervisor_markers(monkeypatch)
|
|
monkeypatch.setenv(gateway.EXTERNAL_GATEWAY_SUPERVISOR_ENV, "1")
|
|
|
|
assert gateway._running_under_gateway_supervisor() is True
|
|
|
|
|
|
def test_gateway_run_external_supervisor_flag_marks_process(monkeypatch):
|
|
monkeypatch.delenv(gateway.EXTERNAL_GATEWAY_SUPERVISOR_ENV, raising=False)
|
|
monkeypatch.setattr(
|
|
gateway, "_maybe_redirect_run_to_s6_supervision", lambda _args: False
|
|
)
|
|
observed = []
|
|
monkeypatch.setattr(
|
|
gateway,
|
|
"run_gateway",
|
|
lambda *_args, **_kwargs: observed.append(
|
|
gateway.os.environ.get(gateway.EXTERNAL_GATEWAY_SUPERVISOR_ENV)
|
|
),
|
|
)
|
|
|
|
gateway._gateway_command_inner(
|
|
SimpleNamespace(gateway_command="run", external_supervisor=True)
|
|
)
|
|
|
|
assert observed == ["1"]
|
|
|
|
|
|
def test_update_hands_external_supervisor_gateway_back_without_watcher(monkeypatch):
|
|
monkeypatch.setattr(
|
|
gateway,
|
|
"_capture_gateway_argv",
|
|
lambda _pid: [
|
|
"python",
|
|
"-m",
|
|
"hermes_cli.main",
|
|
"gateway",
|
|
"run",
|
|
"--external-supervisor",
|
|
],
|
|
)
|
|
monkeypatch.setattr(
|
|
gateway,
|
|
"launch_detached_profile_gateway_restart",
|
|
lambda *_args: pytest.fail("detached watcher must not be launched"),
|
|
)
|
|
|
|
assert gateway._prepare_profile_gateway_update_restart("work", 1234) == (
|
|
"external-supervisor"
|
|
)
|
|
|
|
|