mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
59 lines
2.2 KiB
Python
59 lines
2.2 KiB
Python
"""`hermes debug` must not report a shell-only API key as plainly "set".
|
|
|
|
The dump reads ``os.getenv`` — the invoking terminal's environment — but the
|
|
managed backends (launchd / systemd / the desktop-spawned ``serve`` process)
|
|
load credentials from ``~/.hermes/.env``, not the login shell. A key exported
|
|
in the shell but absent from ``.env`` is invisible to the backend, yet the dump
|
|
used to print a bare "set", sending support down a phantom "the key is
|
|
configured" path (the real cause behind gated tools like ``web_search`` going
|
|
missing on Desktop). The dump now flags that mismatch.
|
|
"""
|
|
|
|
from pathlib import Path
|
|
from types import SimpleNamespace
|
|
|
|
|
|
def _api_key_line(out: str, label: str) -> str:
|
|
for line in out.splitlines():
|
|
if line.strip().startswith(f"{label} "):
|
|
return line
|
|
raise AssertionError(f"no '{label}' api_keys line in dump output:\n{out}")
|
|
|
|
|
|
def test_dump_flags_shell_only_key_not_in_dotenv(monkeypatch, capsys, tmp_path):
|
|
from hermes_cli import dump
|
|
from hermes_cli.config import get_hermes_home
|
|
|
|
monkeypatch.setattr(dump, "get_project_root", lambda: tmp_path / "noproject")
|
|
|
|
home = get_hermes_home()
|
|
home.mkdir(parents=True, exist_ok=True)
|
|
# .env has some OTHER key but NOT firecrawl.
|
|
(home / ".env").write_text("OPENROUTER_API_KEY=sk-or-xxxx\n")
|
|
# firecrawl is exported in the (test) shell only.
|
|
monkeypatch.setenv("FIRECRAWL_API_KEY", "fc-shell-only")
|
|
|
|
dump.run_dump(SimpleNamespace(show_keys=False))
|
|
|
|
line = _api_key_line(capsys.readouterr().out, "firecrawl")
|
|
assert "set" in line
|
|
assert "shell only" in line
|
|
assert ".env" in line
|
|
|
|
|
|
def test_dump_leaves_unset_key_untouched(monkeypatch, capsys, tmp_path):
|
|
from hermes_cli import dump
|
|
from hermes_cli.config import get_hermes_home
|
|
|
|
monkeypatch.setattr(dump, "get_project_root", lambda: tmp_path / "noproject")
|
|
monkeypatch.delenv("TAVILY_API_KEY", raising=False)
|
|
|
|
home = get_hermes_home()
|
|
home.mkdir(parents=True, exist_ok=True)
|
|
(home / ".env").write_text("OPENROUTER_API_KEY=sk-or-xxxx\n")
|
|
|
|
dump.run_dump(SimpleNamespace(show_keys=False))
|
|
|
|
line = _api_key_line(capsys.readouterr().out, "tavily")
|
|
assert "not set" in line
|
|
assert "shell only" not in line
|