mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
88 lines
2.8 KiB
Python
88 lines
2.8 KiB
Python
"""Tests for hermes_cli.auth._default_verify platform-aware fallback.
|
|
|
|
On macOS with Homebrew Python, the system OpenSSL cannot locate the
|
|
system trust store, so we explicitly load certifi's bundle. On other
|
|
platforms we defer to httpx's own default (which itself uses certifi).
|
|
|
|
Most tests use monkeypatching — no real SSL handshakes. A handful use
|
|
an openssl-generated self-signed cert via the `real_bundle_file`
|
|
fixture because `ssl.create_default_context(cafile=...)` parses the
|
|
bundle and refuses stubs.
|
|
"""
|
|
|
|
import shutil
|
|
import ssl
|
|
import subprocess
|
|
import sys
|
|
from pathlib import Path
|
|
|
|
import pytest
|
|
|
|
|
|
from hermes_cli.auth import _default_verify, _resolve_verify
|
|
|
|
|
|
@pytest.fixture
|
|
def real_bundle_file(tmp_path: Path) -> str:
|
|
"""Return a path to a real openssl-generated self-signed cert.
|
|
|
|
Skips the test when the `openssl` binary isn't on PATH, so CI images
|
|
without it degrade gracefully instead of erroring out.
|
|
"""
|
|
if shutil.which("openssl") is None:
|
|
pytest.skip("openssl binary not available")
|
|
cert = tmp_path / "ca.pem"
|
|
key = tmp_path / "key.pem"
|
|
result = subprocess.run(
|
|
[
|
|
"openssl", "req", "-x509", "-newkey", "rsa:2048",
|
|
"-keyout", str(key), "-out", str(cert),
|
|
"-sha256", "-days", "1", "-nodes",
|
|
"-subj", "/CN=test",
|
|
],
|
|
capture_output=True,
|
|
timeout=10,
|
|
)
|
|
if result.returncode != 0:
|
|
pytest.skip(f"openssl failed: {result.stderr.decode('utf-8', 'ignore')[:200]}")
|
|
return str(cert)
|
|
|
|
|
|
class TestDefaultVerify:
|
|
def test_returns_ssl_context_on_darwin(self, monkeypatch):
|
|
monkeypatch.setattr(sys, "platform", "darwin")
|
|
result = _default_verify()
|
|
assert isinstance(result, ssl.SSLContext)
|
|
|
|
|
|
def test_darwin_falls_back_to_true_when_certifi_missing(self, monkeypatch):
|
|
monkeypatch.setattr(sys, "platform", "darwin")
|
|
|
|
real_import = __import__
|
|
|
|
def fake_import(name, *args, **kwargs):
|
|
if name == "certifi":
|
|
raise ImportError("simulated missing certifi")
|
|
return real_import(name, *args, **kwargs)
|
|
|
|
monkeypatch.setattr("builtins.__import__", fake_import)
|
|
assert _default_verify() is True
|
|
|
|
|
|
class TestResolveVerifyIntegration:
|
|
"""_resolve_verify should defer to _default_verify in the no-CA path."""
|
|
|
|
|
|
def test_no_ca_uses_default_verify_on_linux(self, monkeypatch):
|
|
monkeypatch.setattr(sys, "platform", "linux")
|
|
for var in ("HERMES_CA_BUNDLE", "SSL_CERT_FILE", "REQUESTS_CA_BUNDLE"):
|
|
monkeypatch.delenv(var, raising=False)
|
|
assert _resolve_verify() is True
|
|
|
|
|
|
|
|
def test_insecure_wins_over_everything(self, monkeypatch, tmp_path):
|
|
bundle = tmp_path / "ca.pem"
|
|
bundle.write_text("stub")
|
|
monkeypatch.setenv("HERMES_CA_BUNDLE", str(bundle))
|
|
assert _resolve_verify(insecure=True) is False
|