mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
81 lines
2.9 KiB
Python
81 lines
2.9 KiB
Python
"""Regression tests for the Telegram text-batch adaptive-delay fast-path
|
|
and _env_float_clamped helper introduced by PR #10388 (Telegram latency
|
|
tuning).
|
|
|
|
The fast-path lets short replies stream near-instantly while keeping the
|
|
configured cap as the upper bound, so an operator who tightens the cap
|
|
gets the lower number on every tier.
|
|
|
|
The env-clamped helper guarantees float env vars never produce NaN/Inf
|
|
or out-of-bounds values that could break asyncio.sleep().
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import math
|
|
|
|
import pytest
|
|
|
|
from plugins.platforms.telegram.adapter import TelegramAdapter
|
|
|
|
|
|
@pytest.fixture
|
|
def adapter():
|
|
"""Build a TelegramAdapter shell without going through __init__'s
|
|
network-touching setup. Just need the class for static-method access
|
|
and the instance for instance-method tests."""
|
|
return TelegramAdapter.__new__(TelegramAdapter)
|
|
|
|
|
|
class TestEnvFloatClamped:
|
|
"""_env_float_clamped is the fence around every float env var the
|
|
adapter reads — must reject NaN/Inf and honor min/max bounds."""
|
|
|
|
|
|
def test_rejects_nan(self, monkeypatch):
|
|
monkeypatch.setenv("HERMES_TEST_VAR", "nan")
|
|
result = TelegramAdapter._env_float_clamped("HERMES_TEST_VAR", 0.5)
|
|
assert math.isfinite(result)
|
|
assert result == 0.5
|
|
|
|
|
|
def test_clamps_below_min(self, monkeypatch):
|
|
monkeypatch.setenv("HERMES_TEST_VAR", "0.01")
|
|
assert TelegramAdapter._env_float_clamped(
|
|
"HERMES_TEST_VAR", 0.5, min_value=0.1,
|
|
) == 0.1
|
|
|
|
|
|
class TestAdaptiveTextBatchTiers:
|
|
"""The fast-path tiers cap delay for short / medium messages. Tier
|
|
constants must compose with the configured cap (operators who set a
|
|
lower cap get the lower number on every tier)."""
|
|
|
|
def test_class_constants_are_sensible(self):
|
|
"""Sanity check that the tier constants form a non-overlapping
|
|
ascending ladder."""
|
|
assert TelegramAdapter._TEXT_BATCH_FAST_LEN < TelegramAdapter._TEXT_BATCH_SHORT_LEN
|
|
assert TelegramAdapter._TEXT_BATCH_FAST_DELAY_S < TelegramAdapter._TEXT_BATCH_SHORT_DELAY_S
|
|
assert TelegramAdapter._TEXT_BATCH_FAST_DELAY_S > 0
|
|
assert TelegramAdapter._TEXT_BATCH_SHORT_DELAY_S > 0
|
|
|
|
def test_fast_tier_uses_min_with_configured_cap(self, adapter):
|
|
"""A short message picks the lower of the fast-tier delay and
|
|
the operator's configured cap."""
|
|
# Operator set a generous cap (0.6s); fast tier should win.
|
|
adapter._text_batch_delay_seconds = 0.6
|
|
delay = min(
|
|
adapter._text_batch_delay_seconds,
|
|
TelegramAdapter._TEXT_BATCH_FAST_DELAY_S,
|
|
)
|
|
assert delay == TelegramAdapter._TEXT_BATCH_FAST_DELAY_S
|
|
|
|
# Operator tightened the cap below the fast-tier delay; cap wins.
|
|
adapter._text_batch_delay_seconds = 0.10
|
|
delay = min(
|
|
adapter._text_batch_delay_seconds,
|
|
TelegramAdapter._TEXT_BATCH_FAST_DELAY_S,
|
|
)
|
|
assert delay == 0.10
|
|
|
|
|