mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
62 lines
2.4 KiB
Python
62 lines
2.4 KiB
Python
"""Phase 0 regression harness for the relay/connector work.
|
|
|
|
Locks the *behavioral contract* that the future ``RelayAdapter`` must reproduce:
|
|
the gateway's ``stream_consumer`` and ``BasePlatformAdapter`` read per-platform
|
|
capabilities through a small, stable surface. A relay adapter that exposes the
|
|
same surface (``MAX_MESSAGE_LENGTH`` attribute, ``message_len_fn`` property,
|
|
``supports_draft_streaming`` probe, and only the abstract methods) slots into
|
|
the existing consumer with no consumer changes.
|
|
|
|
These are deliberately *behavioral* (construct an adapter, drive the code,
|
|
assert the observable outcome) rather than source-string snapshots, per the
|
|
repo's "don't write change-detector tests" rule. They pass on ``main`` before
|
|
any ``RelayAdapter`` exists — they describe the contract, not the relay.
|
|
"""
|
|
|
|
import inspect
|
|
|
|
from gateway.config import Platform, PlatformConfig
|
|
from gateway.platforms.base import BasePlatformAdapter
|
|
|
|
|
|
class _MinAdapter(BasePlatformAdapter):
|
|
"""Smallest concrete adapter: implements exactly the abstract methods."""
|
|
|
|
async def connect(self, *, is_reconnect: bool = False): # pragma: no cover - not called
|
|
return True
|
|
|
|
async def disconnect(self): # pragma: no cover - not called
|
|
return None
|
|
|
|
async def send(self, *args, **kwargs): # pragma: no cover - not called
|
|
return None
|
|
|
|
async def get_chat_info(self, chat_id): # pragma: no cover - not called
|
|
return {}
|
|
|
|
|
|
def _make() -> BasePlatformAdapter:
|
|
return _MinAdapter(PlatformConfig(), Platform.LOCAL)
|
|
|
|
|
|
def test_abstract_methods_are_the_known_set():
|
|
"""The relay adapter must implement exactly this set of abstract methods.
|
|
|
|
Everything else on BasePlatformAdapter has a default, so ONE generic
|
|
RelayAdapter overriding the right subset is feasible without per-platform
|
|
gateway classes. If a new abstractmethod is added here, the relay design
|
|
(and the cross-repo contract) must be revisited — hence the lock.
|
|
|
|
NOTE: this is four methods, not three — ``get_chat_info`` is abstract too
|
|
(defined far below the connect/disconnect/send cluster in base.py). The
|
|
RelayAdapter must implement it (proxying a chat-info lookup to the
|
|
connector, or returning a descriptor-derived stub).
|
|
"""
|
|
abstract = {
|
|
name
|
|
for name, member in inspect.getmembers(BasePlatformAdapter)
|
|
if getattr(member, "__isabstractmethod__", False)
|
|
}
|
|
assert abstract == {"connect", "disconnect", "send", "get_chat_info"}
|
|
|
|
|