mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
55 lines
1.6 KiB
Python
55 lines
1.6 KiB
Python
"""Tests for _resolve_requests_verify() env var precedence.
|
|
|
|
Verifies that custom provider `/models` fetches honour the three supported
|
|
CA bundle env vars (HERMES_CA_BUNDLE, REQUESTS_CA_BUNDLE, SSL_CERT_FILE)
|
|
in the documented priority order, and that non-existent paths are
|
|
skipped gracefully rather than breaking the request.
|
|
|
|
No filesystem or network I/O required — we use tmp_path to create real
|
|
CA bundle stand-in files and monkeypatch env vars.
|
|
"""
|
|
|
|
from pathlib import Path
|
|
|
|
|
|
import pytest
|
|
|
|
from agent.model_metadata import _resolve_requests_verify
|
|
|
|
|
|
_CA_ENV_VARS = ("HERMES_CA_BUNDLE", "REQUESTS_CA_BUNDLE", "SSL_CERT_FILE")
|
|
|
|
|
|
@pytest.fixture
|
|
def clean_env(monkeypatch):
|
|
"""Clear all three SSL env vars so each test starts from a known state."""
|
|
for var in _CA_ENV_VARS:
|
|
monkeypatch.delenv(var, raising=False)
|
|
return monkeypatch
|
|
|
|
|
|
@pytest.fixture
|
|
def bundle_file(tmp_path: Path) -> str:
|
|
"""Create a placeholder CA bundle file and return its absolute path."""
|
|
path = tmp_path / "ca.pem"
|
|
path.write_text("-----BEGIN CERTIFICATE-----\nstub\n-----END CERTIFICATE-----\n")
|
|
return str(path)
|
|
|
|
|
|
class TestResolveRequestsVerify:
|
|
def test_no_env_returns_true(self, clean_env):
|
|
assert _resolve_requests_verify() is True
|
|
|
|
|
|
|
|
|
|
def test_priority_hermes_over_requests(self, clean_env, tmp_path, bundle_file):
|
|
other = tmp_path / "other.pem"
|
|
other.write_text("stub")
|
|
clean_env.setenv("HERMES_CA_BUNDLE", bundle_file)
|
|
clean_env.setenv("REQUESTS_CA_BUNDLE", str(other))
|
|
assert _resolve_requests_verify() == bundle_file
|
|
|
|
|
|
|
|
|