mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
90 lines
2.9 KiB
Python
90 lines
2.9 KiB
Python
"""compression.max_attempts — config-driven compression retry cap.
|
|
|
|
The conversation loop's compression retry cap was hardcoded to 3, stranding
|
|
sessions that legitimately need more rounds — e.g. a restart history reload
|
|
whose incompressible tool schemas keep the request estimate above the
|
|
threshold while the messages themselves compress fine (the #62605 failure
|
|
class). The cap is now parsed from ``compression.max_attempts`` in
|
|
``agent_init`` and read by the loop via
|
|
``getattr(agent, "max_compression_attempts", 3)``.
|
|
|
|
These tests pin the parse/validate/attach seam: default preserved, custom
|
|
value honored, floor and ceiling enforced, garbage tolerated.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import contextlib
|
|
import io
|
|
from pathlib import Path
|
|
|
|
from hermes_state import SessionDB
|
|
from run_agent import AIAgent
|
|
|
|
|
|
def _config(max_attempts=None) -> dict:
|
|
compression = {
|
|
"enabled": True,
|
|
"threshold": 0.50,
|
|
"target_ratio": 0.20,
|
|
"protect_first_n": 3,
|
|
"protect_last_n": 20,
|
|
}
|
|
if max_attempts is not None:
|
|
compression["max_attempts"] = max_attempts
|
|
return {
|
|
"compression": compression,
|
|
"prompt_caching": {"cache_ttl": "5m"},
|
|
"sessions": {},
|
|
"bedrock": {},
|
|
}
|
|
|
|
|
|
def _make_agent(monkeypatch, tmp_path: Path, *, max_attempts=None):
|
|
from hermes_cli import config as config_mod
|
|
|
|
monkeypatch.setattr(
|
|
config_mod, "load_config", lambda: _config(max_attempts=max_attempts)
|
|
)
|
|
db = SessionDB(db_path=tmp_path / "state.db")
|
|
with contextlib.redirect_stdout(io.StringIO()):
|
|
agent = AIAgent(
|
|
base_url="https://chatgpt.com/backend-api/codex",
|
|
api_key="test-key",
|
|
provider="openai-codex",
|
|
model="gpt-5.5",
|
|
enabled_toolsets=[],
|
|
disabled_toolsets=[],
|
|
quiet_mode=True,
|
|
skip_memory=True,
|
|
session_db=db,
|
|
session_id="max-attempts-test",
|
|
)
|
|
return agent
|
|
|
|
|
|
class TestCompressionMaxAttemptsConfig:
|
|
def test_default_is_three_when_unset(self, monkeypatch, tmp_path):
|
|
agent = _make_agent(monkeypatch, tmp_path)
|
|
assert agent.max_compression_attempts == 3
|
|
|
|
def test_custom_value_is_honored(self, monkeypatch, tmp_path):
|
|
agent = _make_agent(monkeypatch, tmp_path, max_attempts=6)
|
|
assert agent.max_compression_attempts == 6
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_loop_pickup_degrades_to_default_when_attribute_missing(
|
|
self, monkeypatch, tmp_path
|
|
):
|
|
# The loop reads getattr(agent, "max_compression_attempts", 3): a
|
|
# configured agent exposes its value, and an object without the
|
|
# attribute (older pickle / minimal stub) degrades to the prior
|
|
# hardcoded behavior.
|
|
agent = _make_agent(monkeypatch, tmp_path, max_attempts=7)
|
|
assert getattr(agent, "max_compression_attempts", 3) == 7
|
|
assert getattr(object(), "max_compression_attempts", 3) == 3
|