mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
78 lines
2.4 KiB
Python
78 lines
2.4 KiB
Python
"""Regression tests for Bedrock Converse empty/whitespace text block rejection.
|
|
|
|
Bedrock's Converse API raises::
|
|
|
|
ValidationException: The model returned the following errors: messages:
|
|
text content blocks must contain non-whitespace text
|
|
|
|
for ANY text content block that is empty OR whitespace-only. Anthropic's native
|
|
API tolerates these; Bedrock does not. Such blocks most often appear after
|
|
context compression rewrites an assistant/tool turn into a blank string — once
|
|
in history the block is re-sent on every call and fails deterministically
|
|
(all retries fail identically). Ref: issue #9486.
|
|
|
|
These tests assert convert_messages_to_converse never emits a blank text block
|
|
(including inside toolResult content) and never uses a whitespace-only
|
|
placeholder (a lone space would be rejected by the same validation).
|
|
"""
|
|
import pytest
|
|
|
|
from agent.bedrock_adapter import (
|
|
convert_messages_to_converse,
|
|
_convert_content_to_converse,
|
|
_safe_text,
|
|
_EMPTY_TEXT_PLACEHOLDER,
|
|
)
|
|
|
|
|
|
def _iter_text_blocks(msgs):
|
|
"""Yield every text string that will be sent to Bedrock, incl. toolResult."""
|
|
for m in msgs:
|
|
for b in m["content"]:
|
|
if "text" in b:
|
|
yield b["text"]
|
|
if "toolResult" in b:
|
|
for tb in b["toolResult"]["content"]:
|
|
if "text" in tb:
|
|
yield tb["text"]
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_safe_text_preserves_real_content():
|
|
assert _safe_text("hello") == "hello"
|
|
assert _safe_text(" padded ") == " padded " # inner content kept verbatim
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_real_content_is_preserved_alongside_blank_siblings():
|
|
messages = [
|
|
{"role": "user", "content": [
|
|
{"type": "text", "text": " "},
|
|
{"type": "text", "text": "real question"},
|
|
]},
|
|
]
|
|
_system, msgs = convert_messages_to_converse(messages)
|
|
texts = list(_iter_text_blocks(msgs))
|
|
assert "real question" in texts
|
|
assert all(t.strip() for t in texts)
|
|
|
|
|
|
def test_blank_system_blocks_dropped_not_blanked():
|
|
messages = [
|
|
{"role": "system", "content": [
|
|
{"type": "text", "text": "keep me"},
|
|
{"type": "text", "text": " "},
|
|
]},
|
|
{"role": "user", "content": "hi"},
|
|
]
|
|
system, _msgs = convert_messages_to_converse(messages)
|
|
assert system is not None
|
|
for block in system:
|
|
assert block["text"].strip()
|
|
assert any(b["text"] == "keep me" for b in system)
|