mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
329 lines
11 KiB
Python
329 lines
11 KiB
Python
"""Tests for acp_adapter.session — SessionManager and SessionState."""
|
|
|
|
import contextlib
|
|
import io
|
|
import json
|
|
import time
|
|
from types import SimpleNamespace
|
|
import pytest
|
|
from unittest.mock import MagicMock, patch
|
|
|
|
from acp_adapter import session as acp_session
|
|
from acp_adapter.session import SessionManager, SessionState
|
|
from hermes_state import SessionDB
|
|
|
|
|
|
def _mock_agent():
|
|
return MagicMock(name="MockAIAgent")
|
|
|
|
|
|
@pytest.fixture()
|
|
def manager():
|
|
"""SessionManager with a mock agent factory (avoids needing API keys)."""
|
|
return SessionManager(agent_factory=_mock_agent)
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# create / get
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
class TestCreateSession:
|
|
def test_create_session_returns_state(self, manager):
|
|
state = manager.create_session(cwd="/tmp/work")
|
|
assert isinstance(state, SessionState)
|
|
assert state.cwd == "/tmp/work"
|
|
assert state.session_id
|
|
assert state.history == []
|
|
assert state.agent is not None
|
|
|
|
|
|
|
|
def test_register_task_cwd_translates_windows_drive_for_wsl_tools(self, monkeypatch):
|
|
captured = {}
|
|
|
|
def fake_register_task_env_overrides(task_id, overrides):
|
|
captured["task_id"] = task_id
|
|
captured["overrides"] = overrides
|
|
|
|
monkeypatch.setattr("hermes_constants._wsl_detected", True)
|
|
monkeypatch.setattr(
|
|
"tools.terminal_tool.register_task_env_overrides",
|
|
fake_register_task_env_overrides,
|
|
)
|
|
|
|
acp_session._register_task_cwd("session-1", r"E:\Projects\AI\paperclip")
|
|
|
|
assert captured == {
|
|
"task_id": "session-1",
|
|
"overrides": {"cwd": "/mnt/e/Projects/AI/paperclip"},
|
|
}
|
|
|
|
|
|
def test_get_session(self, manager):
|
|
state = manager.create_session()
|
|
fetched = manager.get_session(state.session_id)
|
|
assert fetched is state
|
|
|
|
|
|
def test_make_agent_stamps_session_cwd_for_codex_runtime(self, monkeypatch):
|
|
class FakeAgent:
|
|
model = "fake-model"
|
|
|
|
def __init__(self, **kwargs):
|
|
self.kwargs = kwargs
|
|
|
|
monkeypatch.setattr("run_agent.AIAgent", FakeAgent)
|
|
monkeypatch.setattr(
|
|
"acp_adapter.session.load_config",
|
|
lambda: {
|
|
"model": {
|
|
"default": "fake-model",
|
|
"provider": "fake-provider",
|
|
},
|
|
"mcp_servers": {},
|
|
},
|
|
raising=False,
|
|
)
|
|
monkeypatch.setattr(
|
|
"hermes_cli.config.load_config",
|
|
lambda: {
|
|
"model": {
|
|
"default": "fake-model",
|
|
"provider": "fake-provider",
|
|
},
|
|
"mcp_servers": {},
|
|
},
|
|
)
|
|
monkeypatch.setattr(
|
|
"hermes_cli.runtime_provider.resolve_runtime_provider",
|
|
lambda requested=None: {
|
|
"provider": requested,
|
|
"api_mode": "codex_app_server",
|
|
"base_url": "https://example.invalid",
|
|
"api_key": "test-key",
|
|
},
|
|
)
|
|
monkeypatch.setattr("acp_adapter.session._register_task_cwd", lambda task_id, cwd: None)
|
|
|
|
state = SessionManager(db=None).create_session(cwd="/tmp/project")
|
|
|
|
assert state.agent.session_cwd == "/tmp/project"
|
|
|
|
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# WSL cwd translation
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
class TestWslCwdTranslation:
|
|
def test_translate_acp_cwd_converts_windows_drive_path_when_wsl(self, monkeypatch):
|
|
monkeypatch.setattr("hermes_constants._wsl_detected", True)
|
|
|
|
assert acp_session._translate_acp_cwd(r"E:\Projects\AI\paperclip") == "/mnt/e/Projects/AI/paperclip"
|
|
|
|
|
|
|
|
|
|
|
|
def test_fork_session_stores_translated_cwd_on_wsl(self, manager, monkeypatch):
|
|
monkeypatch.setattr("hermes_constants._wsl_detected", True)
|
|
original = manager.create_session(cwd="/tmp/base")
|
|
|
|
forked = manager.fork_session(original.session_id, cwd=r"D:\work\project")
|
|
|
|
assert forked is not None
|
|
assert forked.cwd == "/mnt/d/work/project"
|
|
|
|
def test_update_cwd_stores_translated_cwd_on_wsl(self, manager, monkeypatch):
|
|
monkeypatch.setattr("hermes_constants._wsl_detected", True)
|
|
state = manager.create_session(cwd="/tmp/old")
|
|
|
|
updated = manager.update_cwd(state.session_id, cwd=r"C:\Users\foo\project")
|
|
|
|
assert updated is not None
|
|
assert updated.cwd == "/mnt/c/Users/foo/project"
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# fork
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# list / cleanup / remove
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
class TestListAndCleanup:
|
|
def test_list_sessions_empty(self, manager):
|
|
assert manager.list_sessions() == []
|
|
|
|
|
|
|
|
def test_save_session_preserves_existing_messages_on_encode_failure(self, manager):
|
|
"""Regression for #13675: a bad message in state.history must not
|
|
clobber the previously-persisted transcript. replace_messages()
|
|
wraps DELETE + INSERT in a single rolled-back-on-exception txn.
|
|
"""
|
|
state = manager.create_session()
|
|
state.history.append({"role": "user", "content": "original"})
|
|
manager.save_session(state.session_id)
|
|
|
|
# Now swap history with a message whose tool_calls is non-JSON-serializable.
|
|
# _execute_write rolls back; the previously persisted "original" stays.
|
|
state.history = [
|
|
{"role": "user", "content": "replacement"},
|
|
{
|
|
"role": "assistant",
|
|
"content": None,
|
|
"tool_calls": [{"bad": object()}],
|
|
},
|
|
]
|
|
manager.save_session(state.session_id)
|
|
|
|
db = manager._get_db()
|
|
messages = db.get_messages_as_conversation(state.session_id)
|
|
assert len(messages) == 1
|
|
assert messages[0]["role"] == "user"
|
|
assert messages[0]["content"] == "original"
|
|
assert isinstance(messages[0].get("timestamp"), (int, float))
|
|
|
|
|
|
|
|
|
|
def test_cleanup_clears_all(self, manager):
|
|
s1 = manager.create_session()
|
|
s2 = manager.create_session()
|
|
s1.history.append({"role": "user", "content": "one"})
|
|
s2.history.append({"role": "user", "content": "two"})
|
|
assert len(manager.list_sessions()) == 2
|
|
manager.cleanup()
|
|
assert manager.list_sessions() == []
|
|
|
|
def test_remove_session(self, manager):
|
|
state = manager.create_session()
|
|
assert manager.remove_session(state.session_id) is True
|
|
assert manager.get_session(state.session_id) is None
|
|
# Removing again returns False
|
|
assert manager.remove_session(state.session_id) is False
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# persistence — sessions survive process restarts (via SessionDB)
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
class TestPersistence:
|
|
"""Verify that sessions are persisted to SessionDB and can be restored."""
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_only_restores_acp_sessions(self, manager):
|
|
"""get_session should not restore non-ACP sessions from DB."""
|
|
db = manager._get_db()
|
|
# Manually create a CLI session in the DB.
|
|
db.create_session(session_id="cli-session-123", source="cli", model="test")
|
|
# Should not be found via ACP SessionManager.
|
|
assert manager.get_session("cli-session-123") is None
|
|
|
|
def test_sessions_searchable_via_fts(self, manager):
|
|
"""ACP sessions stored in SessionDB are searchable via FTS5."""
|
|
state = manager.create_session()
|
|
state.history.append({"role": "user", "content": "how do I configure nginx"})
|
|
state.history.append({"role": "assistant", "content": "Here is the nginx config..."})
|
|
manager.save_session(state.session_id)
|
|
|
|
db = manager._get_db()
|
|
results = db.search_messages("nginx")
|
|
assert len(results) > 0
|
|
session_ids = {r["session_id"] for r in results}
|
|
assert state.session_id in session_ids
|
|
|
|
|
|
def test_assistant_reasoning_fields_persisted(self, manager):
|
|
"""ACP session restore should preserve assistant reasoning context."""
|
|
state = manager.create_session()
|
|
state.history.append({
|
|
"role": "assistant",
|
|
"content": "hello",
|
|
"reasoning": "step-by-step",
|
|
"reasoning_details": [
|
|
{"type": "thinking", "thinking": "first thought"},
|
|
],
|
|
"codex_reasoning_items": [
|
|
{"type": "reasoning", "id": "rs_123", "encrypted_content": "enc_blob"},
|
|
],
|
|
})
|
|
manager.save_session(state.session_id)
|
|
|
|
with manager._lock:
|
|
del manager._sessions[state.session_id]
|
|
|
|
restored = manager.get_session(state.session_id)
|
|
assert restored is not None
|
|
msg = restored.history[0]
|
|
assert isinstance(msg.pop("timestamp", None), (int, float))
|
|
assert restored.history == [{
|
|
"role": "assistant",
|
|
"content": "hello",
|
|
"reasoning": "step-by-step",
|
|
"reasoning_details": [
|
|
{"type": "thinking", "thinking": "first thought"},
|
|
],
|
|
"codex_reasoning_items": [
|
|
{"type": "reasoning", "id": "rs_123", "encrypted_content": "enc_blob"},
|
|
],
|
|
}]
|
|
|
|
|
|
def test_acp_agents_route_human_output_to_stderr(self, tmp_path, monkeypatch):
|
|
"""ACP agents must keep stdout clean for JSON-RPC stdio transport."""
|
|
|
|
def fake_resolve_runtime_provider(requested=None, **kwargs):
|
|
return {
|
|
"provider": "openrouter",
|
|
"api_mode": "chat_completions",
|
|
"base_url": "https://openrouter.example/v1",
|
|
"api_key": "test-key",
|
|
"command": None,
|
|
"args": [],
|
|
}
|
|
|
|
def fake_agent(**kwargs):
|
|
return SimpleNamespace(model=kwargs.get("model"), _print_fn=None)
|
|
|
|
monkeypatch.setattr("hermes_cli.config.load_config", lambda: {
|
|
"model": {"provider": "openrouter", "default": "test-model"}
|
|
})
|
|
monkeypatch.setattr(
|
|
"hermes_cli.runtime_provider.resolve_runtime_provider",
|
|
fake_resolve_runtime_provider,
|
|
)
|
|
db = SessionDB(tmp_path / "state.db")
|
|
|
|
with patch("run_agent.AIAgent", side_effect=fake_agent):
|
|
manager = SessionManager(db=db)
|
|
state = manager.create_session(cwd="/work")
|
|
|
|
stdout_buf = io.StringIO()
|
|
stderr_buf = io.StringIO()
|
|
with contextlib.redirect_stdout(stdout_buf), contextlib.redirect_stderr(stderr_buf):
|
|
state.agent._print_fn("ACP noise")
|
|
|
|
assert stdout_buf.getvalue() == ""
|
|
assert stderr_buf.getvalue() == "ACP noise\n"
|