mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-05-01 01:51:44 +00:00
5a1d4f6804
Adds Vercel Sandbox as a supported Hermes terminal backend alongside existing providers (Local, Docker, Modal, SSH, Daytona, Singularity). Uses the Vercel Python SDK to create/manage cloud microVMs, supports snapshot-based filesystem persistence keyed by task_id, and integrates with the existing BaseEnvironment shell contract and FileSyncManager for credential/skill syncing. Based on #17127 by @scotttrinh, cherry-picked onto current main.
316 lines
12 KiB
Python
316 lines
12 KiB
Python
import importlib
|
|
import logging
|
|
|
|
import pytest
|
|
|
|
terminal_tool_module = importlib.import_module("tools.terminal_tool")
|
|
|
|
|
|
def _clear_terminal_env(monkeypatch):
|
|
"""Remove terminal env vars that could affect requirements checks."""
|
|
keys = [
|
|
"TERMINAL_ENV",
|
|
"TERMINAL_CONTAINER_CPU",
|
|
"TERMINAL_CONTAINER_DISK",
|
|
"TERMINAL_CONTAINER_MEMORY",
|
|
"TERMINAL_DOCKER_FORWARD_ENV",
|
|
"TERMINAL_DOCKER_VOLUMES",
|
|
"TERMINAL_LIFETIME_SECONDS",
|
|
"TERMINAL_MODAL_MODE",
|
|
"TERMINAL_SSH_HOST",
|
|
"TERMINAL_SSH_PORT",
|
|
"TERMINAL_SSH_USER",
|
|
"TERMINAL_TIMEOUT",
|
|
"TERMINAL_VERCEL_RUNTIME",
|
|
"MODAL_TOKEN_ID",
|
|
"MODAL_TOKEN_SECRET",
|
|
"VERCEL_OIDC_TOKEN",
|
|
"VERCEL_TOKEN",
|
|
"VERCEL_PROJECT_ID",
|
|
"VERCEL_TEAM_ID",
|
|
"HOME",
|
|
"USERPROFILE",
|
|
]
|
|
for key in keys:
|
|
monkeypatch.delenv(key, raising=False)
|
|
# Default: no Nous subscription — patch both the terminal_tool local
|
|
# binding and tool_backend_helpers (used by resolve_modal_backend_state).
|
|
monkeypatch.setattr(terminal_tool_module, "managed_nous_tools_enabled", lambda: False)
|
|
import tools.tool_backend_helpers as _tbh
|
|
monkeypatch.setattr(_tbh, "managed_nous_tools_enabled", lambda: False)
|
|
|
|
|
|
def test_local_terminal_requirements(monkeypatch, caplog):
|
|
"""Local backend uses Hermes' own LocalEnvironment wrapper."""
|
|
_clear_terminal_env(monkeypatch)
|
|
monkeypatch.setenv("TERMINAL_ENV", "local")
|
|
|
|
with caplog.at_level(logging.ERROR):
|
|
ok = terminal_tool_module.check_terminal_requirements()
|
|
|
|
assert ok is True
|
|
assert "Terminal requirements check failed" not in caplog.text
|
|
|
|
|
|
def test_unknown_terminal_env_logs_error_and_returns_false(monkeypatch, caplog):
|
|
_clear_terminal_env(monkeypatch)
|
|
monkeypatch.setenv("TERMINAL_ENV", "unknown-backend")
|
|
|
|
with caplog.at_level(logging.ERROR):
|
|
ok = terminal_tool_module.check_terminal_requirements()
|
|
|
|
assert ok is False
|
|
assert any(
|
|
"Unknown TERMINAL_ENV 'unknown-backend'" in record.getMessage()
|
|
for record in caplog.records
|
|
)
|
|
|
|
|
|
def test_ssh_backend_without_host_or_user_logs_and_returns_false(monkeypatch, caplog):
|
|
_clear_terminal_env(monkeypatch)
|
|
monkeypatch.setenv("TERMINAL_ENV", "ssh")
|
|
|
|
with caplog.at_level(logging.ERROR):
|
|
ok = terminal_tool_module.check_terminal_requirements()
|
|
|
|
assert ok is False
|
|
assert any(
|
|
"SSH backend selected but TERMINAL_SSH_HOST and TERMINAL_SSH_USER" in record.getMessage()
|
|
for record in caplog.records
|
|
)
|
|
|
|
|
|
def test_modal_backend_without_token_or_config_logs_specific_error(monkeypatch, caplog, tmp_path):
|
|
_clear_terminal_env(monkeypatch)
|
|
monkeypatch.setenv("TERMINAL_ENV", "modal")
|
|
monkeypatch.setenv("HOME", str(tmp_path))
|
|
monkeypatch.setenv("USERPROFILE", str(tmp_path))
|
|
monkeypatch.setattr(terminal_tool_module, "is_managed_tool_gateway_ready", lambda _vendor: False)
|
|
monkeypatch.setattr(terminal_tool_module.importlib.util, "find_spec", lambda _name: object())
|
|
|
|
with caplog.at_level(logging.ERROR):
|
|
ok = terminal_tool_module.check_terminal_requirements()
|
|
|
|
assert ok is False
|
|
assert any(
|
|
"Modal backend selected but no direct Modal credentials/config was found" in record.getMessage()
|
|
for record in caplog.records
|
|
)
|
|
|
|
|
|
def test_modal_backend_with_managed_gateway_does_not_require_direct_creds_or_minisweagent(monkeypatch, tmp_path):
|
|
_clear_terminal_env(monkeypatch)
|
|
monkeypatch.setattr(terminal_tool_module, "managed_nous_tools_enabled", lambda: True)
|
|
import tools.tool_backend_helpers as _tbh
|
|
monkeypatch.setattr(_tbh, "managed_nous_tools_enabled", lambda: True)
|
|
monkeypatch.setenv("TERMINAL_ENV", "modal")
|
|
monkeypatch.setenv("HOME", str(tmp_path))
|
|
monkeypatch.setenv("USERPROFILE", str(tmp_path))
|
|
monkeypatch.setenv("TERMINAL_MODAL_MODE", "managed")
|
|
monkeypatch.setattr(terminal_tool_module, "is_managed_tool_gateway_ready", lambda _vendor: True)
|
|
monkeypatch.setattr(
|
|
terminal_tool_module.importlib.util,
|
|
"find_spec",
|
|
lambda _name: (_ for _ in ()).throw(AssertionError("should not be called")),
|
|
)
|
|
|
|
assert terminal_tool_module.check_terminal_requirements() is True
|
|
|
|
|
|
def test_modal_backend_auto_mode_prefers_managed_gateway_over_direct_creds(monkeypatch, tmp_path):
|
|
_clear_terminal_env(monkeypatch)
|
|
monkeypatch.setattr(terminal_tool_module, "managed_nous_tools_enabled", lambda: True)
|
|
import tools.tool_backend_helpers as _tbh
|
|
monkeypatch.setattr(_tbh, "managed_nous_tools_enabled", lambda: True)
|
|
monkeypatch.setenv("TERMINAL_ENV", "modal")
|
|
monkeypatch.setenv("MODAL_TOKEN_ID", "tok-id")
|
|
monkeypatch.setenv("MODAL_TOKEN_SECRET", "tok-secret")
|
|
monkeypatch.setenv("HOME", str(tmp_path))
|
|
monkeypatch.setenv("USERPROFILE", str(tmp_path))
|
|
monkeypatch.setattr(terminal_tool_module, "is_managed_tool_gateway_ready", lambda _vendor: True)
|
|
monkeypatch.setattr(
|
|
terminal_tool_module.importlib.util,
|
|
"find_spec",
|
|
lambda _name: (_ for _ in ()).throw(AssertionError("should not be called")),
|
|
)
|
|
|
|
assert terminal_tool_module.check_terminal_requirements() is True
|
|
|
|
|
|
def test_modal_backend_direct_mode_does_not_fall_back_to_managed(monkeypatch, caplog, tmp_path):
|
|
_clear_terminal_env(monkeypatch)
|
|
monkeypatch.setenv("TERMINAL_ENV", "modal")
|
|
monkeypatch.setenv("TERMINAL_MODAL_MODE", "direct")
|
|
monkeypatch.setenv("HOME", str(tmp_path))
|
|
monkeypatch.setenv("USERPROFILE", str(tmp_path))
|
|
monkeypatch.setattr(terminal_tool_module, "is_managed_tool_gateway_ready", lambda _vendor: True)
|
|
|
|
with caplog.at_level(logging.ERROR):
|
|
ok = terminal_tool_module.check_terminal_requirements()
|
|
|
|
assert ok is False
|
|
assert any(
|
|
"TERMINAL_MODAL_MODE=direct" in record.getMessage()
|
|
for record in caplog.records
|
|
)
|
|
|
|
|
|
def test_modal_backend_managed_mode_does_not_fall_back_to_direct(monkeypatch, caplog, tmp_path):
|
|
_clear_terminal_env(monkeypatch)
|
|
monkeypatch.setenv("TERMINAL_ENV", "modal")
|
|
monkeypatch.setenv("TERMINAL_MODAL_MODE", "managed")
|
|
monkeypatch.setenv("MODAL_TOKEN_ID", "tok-id")
|
|
monkeypatch.setenv("MODAL_TOKEN_SECRET", "tok-secret")
|
|
monkeypatch.setenv("HOME", str(tmp_path))
|
|
monkeypatch.setenv("USERPROFILE", str(tmp_path))
|
|
monkeypatch.setattr(terminal_tool_module, "is_managed_tool_gateway_ready", lambda _vendor: False)
|
|
|
|
with caplog.at_level(logging.ERROR):
|
|
ok = terminal_tool_module.check_terminal_requirements()
|
|
|
|
assert ok is False
|
|
assert any(
|
|
"paid Nous subscription is required" in record.getMessage()
|
|
for record in caplog.records
|
|
)
|
|
|
|
|
|
def test_modal_backend_managed_mode_without_feature_flag_logs_clear_error(monkeypatch, caplog, tmp_path):
|
|
_clear_terminal_env(monkeypatch)
|
|
monkeypatch.setenv("TERMINAL_ENV", "modal")
|
|
monkeypatch.setenv("TERMINAL_MODAL_MODE", "managed")
|
|
monkeypatch.setenv("HOME", str(tmp_path))
|
|
monkeypatch.setenv("USERPROFILE", str(tmp_path))
|
|
monkeypatch.setattr(terminal_tool_module, "is_managed_tool_gateway_ready", lambda _vendor: False)
|
|
|
|
with caplog.at_level(logging.ERROR):
|
|
ok = terminal_tool_module.check_terminal_requirements()
|
|
|
|
assert ok is False
|
|
assert any(
|
|
"paid Nous subscription is required" in record.getMessage()
|
|
for record in caplog.records
|
|
)
|
|
|
|
|
|
def test_vercel_backend_without_sdk_logs_specific_error(monkeypatch, caplog):
|
|
_clear_terminal_env(monkeypatch)
|
|
monkeypatch.setenv("TERMINAL_ENV", "vercel_sandbox")
|
|
monkeypatch.setattr(terminal_tool_module.importlib.util, "find_spec", lambda _name: None)
|
|
|
|
with caplog.at_level(logging.ERROR):
|
|
ok = terminal_tool_module.check_terminal_requirements()
|
|
|
|
assert ok is False
|
|
assert any(
|
|
"vercel is required for the Vercel Sandbox terminal backend" in record.getMessage()
|
|
for record in caplog.records
|
|
)
|
|
|
|
|
|
def test_vercel_backend_without_auth_logs_specific_error(monkeypatch, caplog):
|
|
_clear_terminal_env(monkeypatch)
|
|
monkeypatch.setenv("TERMINAL_ENV", "vercel_sandbox")
|
|
monkeypatch.setattr(terminal_tool_module.importlib.util, "find_spec", lambda _name: object())
|
|
|
|
with caplog.at_level(logging.ERROR):
|
|
ok = terminal_tool_module.check_terminal_requirements()
|
|
|
|
assert ok is False
|
|
assert any(
|
|
"no supported auth configuration was found" in record.getMessage()
|
|
for record in caplog.records
|
|
)
|
|
|
|
|
|
def test_vercel_backend_accepts_oidc_auth(monkeypatch):
|
|
_clear_terminal_env(monkeypatch)
|
|
monkeypatch.setenv("TERMINAL_ENV", "vercel_sandbox")
|
|
monkeypatch.setenv("VERCEL_OIDC_TOKEN", "oidc-token")
|
|
monkeypatch.setattr(terminal_tool_module.importlib.util, "find_spec", lambda _name: object())
|
|
|
|
assert terminal_tool_module.check_terminal_requirements() is True
|
|
|
|
|
|
def test_vercel_backend_accepts_token_tuple_auth(monkeypatch):
|
|
_clear_terminal_env(monkeypatch)
|
|
monkeypatch.setenv("TERMINAL_ENV", "vercel_sandbox")
|
|
monkeypatch.setenv("VERCEL_TOKEN", "token")
|
|
monkeypatch.setenv("VERCEL_PROJECT_ID", "project")
|
|
monkeypatch.setenv("VERCEL_TEAM_ID", "team")
|
|
monkeypatch.setattr(terminal_tool_module.importlib.util, "find_spec", lambda _name: object())
|
|
|
|
assert terminal_tool_module.check_terminal_requirements() is True
|
|
|
|
|
|
@pytest.mark.parametrize("runtime", ["node24", "node22", "python3.13"])
|
|
def test_vercel_backend_accepts_supported_runtimes(monkeypatch, runtime):
|
|
_clear_terminal_env(monkeypatch)
|
|
monkeypatch.setenv("TERMINAL_ENV", "vercel_sandbox")
|
|
monkeypatch.setenv("TERMINAL_VERCEL_RUNTIME", runtime)
|
|
monkeypatch.setenv("VERCEL_OIDC_TOKEN", "oidc-token")
|
|
monkeypatch.setattr(terminal_tool_module.importlib.util, "find_spec", lambda _name: object())
|
|
|
|
assert terminal_tool_module.check_terminal_requirements() is True
|
|
|
|
|
|
def test_vercel_backend_accepts_blank_runtime(monkeypatch):
|
|
_clear_terminal_env(monkeypatch)
|
|
monkeypatch.setenv("TERMINAL_ENV", "vercel_sandbox")
|
|
monkeypatch.setenv("TERMINAL_VERCEL_RUNTIME", " ")
|
|
monkeypatch.setenv("VERCEL_OIDC_TOKEN", "oidc-token")
|
|
monkeypatch.setattr(terminal_tool_module.importlib.util, "find_spec", lambda _name: object())
|
|
|
|
assert terminal_tool_module.check_terminal_requirements() is True
|
|
|
|
|
|
def test_vercel_backend_rejects_unsupported_runtime(monkeypatch, caplog):
|
|
_clear_terminal_env(monkeypatch)
|
|
monkeypatch.setenv("TERMINAL_ENV", "vercel_sandbox")
|
|
monkeypatch.setenv("TERMINAL_VERCEL_RUNTIME", "node20")
|
|
monkeypatch.setenv("VERCEL_OIDC_TOKEN", "oidc-token")
|
|
monkeypatch.setattr(terminal_tool_module.importlib.util, "find_spec", lambda _name: object())
|
|
|
|
with caplog.at_level(logging.ERROR):
|
|
ok = terminal_tool_module.check_terminal_requirements()
|
|
|
|
assert ok is False
|
|
assert any(
|
|
"Vercel Sandbox runtime 'node20' is not supported" in record.getMessage()
|
|
and "node24, node22, python3.13" in record.getMessage()
|
|
for record in caplog.records
|
|
)
|
|
|
|
|
|
def test_vercel_backend_rejects_nondefault_disk(monkeypatch, caplog):
|
|
_clear_terminal_env(monkeypatch)
|
|
monkeypatch.setenv("TERMINAL_ENV", "vercel_sandbox")
|
|
monkeypatch.setenv("TERMINAL_CONTAINER_DISK", "8192")
|
|
monkeypatch.setenv("VERCEL_OIDC_TOKEN", "oidc-token")
|
|
monkeypatch.setattr(terminal_tool_module.importlib.util, "find_spec", lambda _name: object())
|
|
|
|
with caplog.at_level(logging.ERROR):
|
|
ok = terminal_tool_module.check_terminal_requirements()
|
|
|
|
assert ok is False
|
|
assert any(
|
|
"does not support custom TERMINAL_CONTAINER_DISK=8192" in record.getMessage()
|
|
for record in caplog.records
|
|
)
|
|
|
|
|
|
def test_vercel_backend_rejects_malformed_disk_without_raising(monkeypatch, caplog):
|
|
_clear_terminal_env(monkeypatch)
|
|
monkeypatch.setenv("TERMINAL_ENV", "vercel_sandbox")
|
|
monkeypatch.setenv("TERMINAL_CONTAINER_DISK", "large")
|
|
monkeypatch.setenv("VERCEL_OIDC_TOKEN", "oidc-token")
|
|
monkeypatch.setattr(terminal_tool_module.importlib.util, "find_spec", lambda _name: object())
|
|
|
|
with caplog.at_level(logging.ERROR):
|
|
ok = terminal_tool_module.check_terminal_requirements()
|
|
|
|
assert ok is False
|
|
assert any(
|
|
"Invalid value for TERMINAL_CONTAINER_DISK" in record.getMessage()
|
|
for record in caplog.records
|
|
)
|