mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
64 lines
2.3 KiB
Python
64 lines
2.3 KiB
Python
"""`hermes debug` must report the EFFECTIVE terminal backend.
|
|
|
|
``terminal.backend`` in config.yaml is bridged to the ``TERMINAL_ENV`` env var,
|
|
but a ``TERMINAL_ENV`` set in .env / the shell overrides config and is what
|
|
``terminal_tool`` actually uses. The dump used to print only the config value,
|
|
which hid the override and made users believe the agent was running ``local``
|
|
while it was really jailed in a docker/podman sandbox (and vice-versa).
|
|
"""
|
|
|
|
from pathlib import Path
|
|
from types import SimpleNamespace
|
|
|
|
|
|
def _terminal_line(out: str) -> str:
|
|
for line in out.splitlines():
|
|
if line.startswith("terminal:"):
|
|
return line
|
|
raise AssertionError(f"no 'terminal:' line in dump output:\n{out}")
|
|
|
|
|
|
def _seed(home: Path, *, config_yaml: str, env_text: str) -> None:
|
|
home.mkdir(parents=True, exist_ok=True)
|
|
(home / "config.yaml").write_text(config_yaml)
|
|
(home / ".env").write_text(env_text)
|
|
|
|
|
|
def test_dump_surfaces_terminal_env_override(monkeypatch, capsys, tmp_path):
|
|
from hermes_cli import dump
|
|
from hermes_cli.config import get_hermes_home
|
|
|
|
monkeypatch.delenv("TERMINAL_ENV", raising=False)
|
|
# Keep run_dump's project-.env fallback from touching the real repo.
|
|
monkeypatch.setattr(dump, "get_project_root", lambda: tmp_path / "noproject")
|
|
|
|
home = get_hermes_home()
|
|
_seed(home, config_yaml="terminal:\n backend: local\n", env_text="TERMINAL_ENV=docker\n")
|
|
|
|
dump.run_dump(SimpleNamespace(show_keys=False))
|
|
|
|
line = _terminal_line(capsys.readouterr().out)
|
|
# Effective backend (docker) is what actually runs, not the config 'local'.
|
|
assert "docker" in line
|
|
assert "overrides config.yaml" in line
|
|
# The shadowed config value is still shown so the mismatch is obvious.
|
|
assert "terminal.backend=local" in line
|
|
|
|
|
|
def test_dump_reports_config_backend_when_no_override(monkeypatch, capsys, tmp_path):
|
|
from hermes_cli import dump
|
|
from hermes_cli.config import get_hermes_home
|
|
|
|
monkeypatch.delenv("TERMINAL_ENV", raising=False)
|
|
monkeypatch.setattr(dump, "get_project_root", lambda: tmp_path / "noproject")
|
|
|
|
home = get_hermes_home()
|
|
_seed(home, config_yaml="terminal:\n backend: docker\n", env_text="")
|
|
|
|
dump.run_dump(SimpleNamespace(show_keys=False))
|
|
|
|
line = _terminal_line(capsys.readouterr().out)
|
|
assert "docker" in line
|
|
assert "overrides" not in line
|
|
|
|
|