mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
140 lines
3.8 KiB
Python
140 lines
3.8 KiB
Python
"""Tests for the core Relay-managed Hermes tool adapter."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import contextvars
|
|
import json
|
|
|
|
import pytest
|
|
|
|
pytest.importorskip("nemo_relay")
|
|
|
|
from agent import relay_runtime, relay_tools
|
|
|
|
|
|
@pytest.fixture()
|
|
def relay_turn(tmp_path, monkeypatch):
|
|
monkeypatch.setenv("HERMES_HOME", str(tmp_path / "profile"))
|
|
relay_runtime._reset_for_tests()
|
|
lease = relay_runtime.SESSION_COORDINATOR.acquire_conversation(
|
|
profile_key=relay_runtime.current_profile_key(),
|
|
session_id="session-1",
|
|
platform="cli",
|
|
)
|
|
turn = relay_runtime.SESSION_COORDINATOR.begin_turn(
|
|
lease,
|
|
turn_id="turn-1",
|
|
task_id="task-1",
|
|
)
|
|
lease.host.retain_managed_execution("test.relay_tools")
|
|
try:
|
|
yield lease.host.relay
|
|
finally:
|
|
lease.host.release_managed_execution("test.relay_tools")
|
|
relay_runtime.SESSION_COORDINATOR.end_turn(turn, outcome="success")
|
|
relay_runtime.SESSION_COORDINATOR.release_conversation(lease)
|
|
relay_runtime._reset_for_tests()
|
|
|
|
|
|
def test_tool_adapter_bypasses_relay_without_an_active_consumer(
|
|
relay_turn, monkeypatch
|
|
):
|
|
relay = relay_turn
|
|
runtime = relay_runtime.get_runtime()
|
|
assert runtime is not None
|
|
runtime.release_managed_execution("test.relay_tools")
|
|
args = {"command": "pwd"}
|
|
|
|
monkeypatch.setattr(
|
|
relay.tools,
|
|
"execute",
|
|
lambda *_args, **_kwargs: (_ for _ in ()).throw(
|
|
AssertionError("inactive Relay must not manage the tool call")
|
|
),
|
|
)
|
|
|
|
result, final_args = relay_tools.execute(
|
|
"terminal",
|
|
args,
|
|
lambda value: value,
|
|
session_id="session-1",
|
|
)
|
|
|
|
assert result is args
|
|
assert final_args is args
|
|
|
|
|
|
|
|
|
|
def test_request_rewrite_reaches_authorized_callback_once(relay_turn):
|
|
relay = relay_turn
|
|
callback_args = []
|
|
|
|
def rewrite_request(_name, args):
|
|
return {**args, "path": "/approved/path"}
|
|
|
|
async def wrap_execution(_name, args, next_call):
|
|
result = await next_call(args)
|
|
return relay.ToolExecutionInterceptOutcome({**result, "wrapped": True})
|
|
|
|
relay.intercepts.register_tool_request(
|
|
"hermes-test-tool-request", 1, False, rewrite_request
|
|
)
|
|
relay.intercepts.register_tool_execution(
|
|
"hermes-test-tool-execution", 1, wrap_execution
|
|
)
|
|
try:
|
|
result, observed_args = relay_tools.execute(
|
|
"write_file",
|
|
{"path": "/original/path"},
|
|
lambda args: callback_args.append(args) or {"ok": True},
|
|
session_id="session-1",
|
|
metadata={"tool_call_id": "call-1"},
|
|
)
|
|
finally:
|
|
relay.intercepts.deregister_tool_execution("hermes-test-tool-execution")
|
|
relay.intercepts.deregister_tool_request("hermes-test-tool-request")
|
|
|
|
assert callback_args == [{"path": "/approved/path"}]
|
|
assert observed_args == {"path": "/approved/path"}
|
|
assert isinstance(result, str)
|
|
assert json.loads(result) == {"ok": True, "wrapped": True}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_tool_error_is_preserved_from_relay_wrapper_suffix(relay_turn, monkeypatch):
|
|
relay = relay_turn
|
|
|
|
class ToolError(Exception):
|
|
pass
|
|
|
|
tool_error = ToolError("dispatch failed")
|
|
|
|
async def wrapping_execute(_name, args, callback, **_kwargs):
|
|
try:
|
|
return callback(args)
|
|
except Exception as exc:
|
|
raise RuntimeError(
|
|
f"internal error: {type(exc).__name__}: {exc} (worker trace)"
|
|
) from None
|
|
|
|
monkeypatch.setattr(relay.tools, "execute", wrapping_execute)
|
|
|
|
with pytest.raises(ToolError) as caught:
|
|
relay_tools.execute(
|
|
"terminal",
|
|
{"command": "false"},
|
|
lambda _args: (_ for _ in ()).throw(tool_error),
|
|
session_id="session-1",
|
|
)
|
|
|
|
assert caught.value is tool_error
|
|
|
|
|
|
|
|
|
|
|
|
|